2016-03-15, 11:57
(2016-03-15, 11:44)dmdsoftware Wrote: [ -> ](2016-03-15, 09:38)dabinn Wrote: [ -> ](2016-03-14, 17:07)dmdsoftware Wrote: [ -> ]Can you test out v0.7.46? I've implemented behaviour for 1-5 without having to toggle a setting. I tested them with a few test cases and looks good.
http://dmdsoftware.net/repository.ddurdl...0.7.46.zip
v0.7.46 (2016-03-14)
- SRT - merge contribution by dabinn (dealing with TV series in a single directory)
- add ability to toggle caching of thumbnails and SRT on/off
- fix cache of SRT
- rework SRT logic
1) list of files (multiple languages) from the same folder that exactly match the title of the video
2) list of candidate files that are from the same folder but don't match the title of the video (if exceeds 4, ask user to select -- likely TV series or folder containing multiple movies)
Many thanks, I will test 0.7.46 later today.
I am still testing on Unicode file name issue (File name in Traditional Chinese, Simplified Chinese, Japanese). Something is strange but I am not very sure right now.
If you are interesting in this, here is an .ass subtitle file with 3 Chinese words in the file name.
https://drive.google.com/file/d/0B-IpAlZ...E2ZWc/view
thanks, I will test with the subtitle
I have roughly tested 0.7.46 and found some problem.
* Too many subtitle files are loaded.
If a directory contained 10 video files (file_01~file10.avi), and I played file_08.avi.
- In some directories, subtitle with filename file08~file10 will be loaded.
- In other directories, subtitle with filename file01~file08 will be loaded.
* file name escaping causes problem
In default.py
Code:
files = cache.getSRT(service)
for file in files:
if file != '':
try:
xbmc.log('gdrive_file_before: '+file, xbmc.LOGNOTICE)
#file = file.decode('unicode-escape')
file = file.encode('utf-8')
xbmc.log('gdrive_file_after: '+file, xbmc.LOGNOTICE)- file name escaping issue 1: Chinese characters in file name are messed up.
Code:
16:37:06 T:9408 NOTICE: gdrive_file_before: D:\tmp\/0B-IpAlZeDhMOLU9mYkdRamhzWDQ/[Anifan][現視研][GENSHIKEN][01].sub
16:37:06 T:9408 NOTICE: gdrive_file_after: D: mp\/0B-IpAlZeDhMOLU9mYkdRamhzWDQ/[Anifan][c??e|?c??][GENSHIKEN][01].sub(In this case "\t" seems to be changed into tab character.)
Code:
17:12:57 T:11296 NOTICE: gdrive_file_before: D:\tmp\/0B-IpAlZeDhMOaDEtczlJd0VMZGM/[file][08][X264_AAC].ass
17:12:57 T:11296 NOTICE: gdrive_file_after: D: mp\/0B-IpAlZeDhMOaDEtczlJd0VMZGM/[file][08][X264_AAC].ass* When cache is turned off
- Windows path and Chinese charactor are OK since filenames are not used when cache is off.
- Each subtitle loaded with a 10 seconds timeout.
While video loading, subtiles cause UI stopped on "Buffering..." message. 1 subtitle takes 10 seconds, 15 subtitles take 150 seconds.
while video playing, switching subtitle (click on KODI UI, subtitle icon --> Next) causes another 10 second timeout before subtitle loaded.
Code:
16:30:19 T:6916 ERROR: CCurlFile::Stat - Failed: Timeout was reached(28) for https://doc-14-c4-docs.googleusercontent.com/docs/securesc/rncrrl446vt43p34xxxxx....