Ok folks I tried a helix nightly last night.
Cleaning my (quite large) library results in:
1. Machine initally appears to hang, mouse freexes etc and xbmc is non responsive
2. No modal pop up, no toast notification either - nothing visible at all
3. Checking log it appears to be cleaning
4. XBMC remains non responsive
5. It finishes ok but it's remarkably slower than Gotham - 20 secs is now several minutes (running on same machine with same DB)
Updating the library also seems a LOT slower than previously.
Using Windows/NFS/MySQL
One very cool thing about Gotham was the quicker updates/cleans.
Can anyon e confirm they are seeing similar?
(NB I have confirmed the behaviour on two separate machines as well)
same problem. but only when using a keyboard shortcut for CleanLibrary(video) (or music). when using the skin shortcut (Aeon Nox 5) it works ok. Updating the database it's the same. Using Linux / NFS/ MySQL
In recent builds progress dialogs are only shown when we're sure that the user triggered the action.
This was changed because add-ons may run these actions automatically and the user:
a) is doing something else and was forced to wait for it to complete before continuing;
b) doesn't really care.
That affects JSON-RPC calls and built-in functions. (There are a couple other reasons, but you don't care here.) So if you have a button mapped to CleanLibrary or UpdateLibrary, you'd need to add a second parameter:
CleanLibrary(<type>, true)
UpdateLibrary needs to be changed like this:
* to scan all directories: UpdateLibrary(<type>, "", true)
* if you have "UpdateLibrary(video, /my/directory)" this needs to be changed to: UpdateLibrary(<type>, /my/directory, true)
The slowness and/or freezing are unrelated and I can't help with that, as I can't even reproduce that behavior.
Well a user pressing a key is a pretty clear sign of a user triggering an action, no?
You should really consider setting the default behaviour to the old for the large number of folks who will have this mapped to a remote key. At the moment it basically looks like XBMC is crashing/hanging & no feedback means this feels like a big bug.
There's no slowness from the skin shortcut here either which is a nice catch @franocovilar. Adding those parameters does seem to restore behaviour.
(Also, the wiki needs an update, I can't find a reference to these parameters in bultin functions
http://kodi.wiki/view/List_of_built-in_functions)
(2014-11-01, 01:33)bossanova808 Wrote: [ -> ]There's no slowness from the skin shortcut
Are you sure about this?
They call exactly the same function, but one shows dialogs, while the other doesn't.
Yep, I am sure. If I used it via keyboard without those parameters - slow, no modal - but with shortcut I get a pop up and it's the same speed as gotham. Once I then added those parameters, the keyboard behaviour matches the skin behaviour - fast, and with a modal.
I took a look at the code and I wasn't able to find out how hiding the dialogs could slow down the process. Can you please provide 2 debug logs so I can compare? One with a button mapped to CleanLibrary(video) and another one with the same button mapped to CleanLibrary(video,true).
Ok so I looked through my logs a bit - there were numerous repeated errors throughout the clean with XFILE::CFileFactory::CreateLoader and references to plugins I had uninstalled from this testing machine years ago.
So I went into the videodb and cleaned all references to plugins from the paths and files tables. Not sure how they got in there (plugins like youtube, dailymotion etc) - I don't use favourites and don't scan anything like that in to the library (if you even can??). Just seems like cruft...might be good if helix had some sort of tidy up script maybe? I use mysql although that shouldn't change anything in this area I would think.
Cleaning with params - takes about 10 to 15 secounds, modal
Cleaning without params - now takes also about 15 seconds. Xbmc is non responsive the whole time, no visual feedback, it just feels 'locked'. It's much better than before now that I have manually cleaned out that stuff, but it's still an unpleasant experience for the user that might convince less patient people it's crashed.
Logs:
Clean with parameters (modal dialogue) -
http://pastebin.com/Z4Db8dqS
Clean without parameters (hang behaviour) -
http://pastebin.com/57ZBJRvH
(2014-11-01, 01:33)bossanova808 Wrote: [ -> ]Well a user pressing a key is a pretty clear sign of a user triggering an action, no?
You should really consider setting the default behaviour to the old for the large number of folks who will have this mapped to a remote key. At the moment it basically looks like XBMC is crashing/hanging & no feedback means this feels like a big bug.
+1 .
I also searched the wiki and didn find any change
+1
Not even the official Kodi remote shows the dialogue. Also have the freezing effect since the feedback message disappeared.
tbh I think scanning speed/response speed is faster , but then again started with a new configuration for helix, not some upgrade and noted that I never run stable versions only nightlies. My libraries though have been upkept by texturecache.py and mainly via that as I feel it is more solid than default kodi behaviour and trash collection which sucks otherwise.
This
https://github.com/xbmc/xbmc/pull/5324 has gone in but that only affect libary updates when started via script remotely, so you for one dont get scan dialog pop ups while playing video.
Im wholeheartedly generally happy with how Helix is shaping up but also disappointed to see some real longer time bugs (unrelated to most issues reported here) still being left for up to 2 years before they get addressed if they ever get addressed even though fixes for them already exist.
(2014-11-01, 21:50)uNi Wrote: [ -> ]Message in a bottle.
Then along comes a White Knight, riding this magnificent "magical" stead and holdings a shield with a kodi makings. - Made of pure c++ and some "bs" like -> https://github.com/xbmc/xbmc/pull/5625 and on his right hand yielding a shard of purest light, who cut through the fabric of this cyberworld, where unforgettable adventures seem to happen.! This shall remain just outside your grasp... These things they stand together, though slightly -inebriated by the flood of utter "bs" spewed on this _short_ but non apologetic, trip to my "cb" world.
A trip to remember 31/10
uNi
Pull request looks great.
I do think, though, that even IF triggered via JSON remotely, it shouldn't freeze the system so severely.
(2014-11-02, 01:57)bossanova808 Wrote: [ -> ]Pull request looks great.
I do think, though, that even IF triggered via JSON remotely, it shouldn't freeze the system so severely.
yeah it even frooze video playback. will be looked into
