Might be something addon related in combination with Kodi 17.4/17.5 but doubtful, event viewer seems pretty empty but what we can do is include the .pdb file in the Kodi directory so that it will report more debug info upon crash:
- Download the pdb archive:
https://mega.nz/#!vxpAUYxL!dRIS-saetoKFD...rqaE8KwtX4
- Copy the Kodi.pdb file from the archive to:
C:\Program Files (x86)\Kodi
Now you will have Kodi.exe and Kodi.pdb file in the same folder, afterwards can test again and in either the Kodi log or event viewer it should have additional debug information.
OK. Just after I get back from work today (in 2 hours) I'll test it and report back.
BTW. Which components to log should I turn on in Kodi?
Only the top debug option in the logging section like so:
And after several hours of testing just everything I've got this nasty bug!
I used MKVToolnix to open one of crashing files and this file contains:
* video track
* AC3 audio track
* DTS audio track
* SRT subtitles
* chapters
I've prepared a file that is 15 seconds long but it contains *ONLY* video track. Bingo! No crash this time. So this is not nvidia driver fault or Kodi fault. Then I added AC3 and DTS audio tracks to MKV. Still no crash. Next I added SRT subtitles track. And... no crash!
It is chapters track that crashes Kodi all the time. So it looks like LAV splitter or Kodi goes here? I don't know which of them processess chapters from file. But what could be wrong?
Could be something wrong in current non-DSplayer Kodi build in combination with that file (maybe chapter / mediainfo readouts?), to rule this out could you try this nightly Kodi which the current build is based off:
http://mirrors.kodi.tv/nightlies/windows...on-x86.exe
Odd that it didn't log anything, .pdb should have added some extra trace info but probably happens before it can actually log anything then.
Nightly lav-filters with dx11 - check
Latest madvr - check
inputstream.adaptive working with drm streams - check
Thanks for updating the DSPlayer build!
OK I've tested those:
* Official stable/final Kodi 17.4 x86 build
without DSplayer: plays this file without any issues or crashes
* Kodi nigthly provided by You (
http://mirrors.kodi.tv/nightlies/windows...on-x86.exe): plays this file without any issues or crashes!
Here is mediainfo readout:
Code:
General
Unique ID : 210773614258743992202764760003040780444 (0x9E91858240F36C73A11784E41794209C)
Complete name : C:\Users\rafal\Downloads\Test (1)-001 (1)-001.mkv
Format : Matroska
Format version : Version 4 / Version 2
File size : 13.2 MiB
Duration : 19 s 979 ms
Overall bit rate : 5 527 kb/s
Encoded date : UTC 2017-09-02 14:50:06
Writing application : mkvmerge v15.0.0 ('Duel with the Devil') 64-bit
Writing library : libebml v1.3.5 + libmatroska v1.4.5
Video
ID : 1
Format : AVC
Format/Info : Advanced Video Codec
Format profile : [email protected]
Format settings, CABAC : Yes
Format settings, RefFrames : 4 frames
Codec ID : V_MPEG4/ISO/AVC
Duration : 19 s 979 ms
Bit rate : 5 523 kb/s
Nominal bit rate : 12.0 Mb/s
Width : 1 920 pixels
Height : 1 080 pixels
Display aspect ratio : 16:9
Frame rate mode : Constant
Frame rate : 23.976 (23976/1000) FPS
Original frame rate : 23.976 (24000/1001) FPS
Color space : YUV
Chroma subsampling : 4:2:0
Bit depth : 8 bits
Scan type : Progressive
Bits/(Pixel*Frame) : 0.111
Stream size : 13.2 MiB (100%)
Writing library : x264 core 142 r2431+42 c69a006 tMod [8-bit@all X86_64]
Encoding settings : cabac=1 / ref=4 / deblock=1:-3:-3 / analyse=0x3:0x113 / me=umh / subme=10 / psy=1 / fade_compensate=0.00 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=32 / chroma_me=1 / trellis=2 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=0 / chroma_qp_offset=-2 / threads=18 / lookahead_threads=3 / sliced_threads=0 / nr=0 / decimate=0 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / fgo=0 / bframes=8 / b_pyramid=2 / b_adapt=2 / b_bias=0 / direct=3 / weightb=1 / open_gop=0 / weightp=2 / keyint=240 / keyint_min=23 / scenecut=40 / intra_refresh=0 / rc_lookahead=60 / rc=2pass / mbtree=0 / bitrate=12000 / ratetol=1.0 / qcomp=0.60 / qpmin=0:0:0 / qpmax=34:34:34 / qpstep=4 / cplxblur=20.0 / qblur=0.5 / vbv_maxrate=30000 / vbv_bufsize=38000 / nal_hrd=none / filler=0 / ip_ratio=1.40 / pb_ratio=1.30 / aq=4:0.90 / aq-sensitivity=10.00 / aq-factor=1.00:1.00:1.00 / aq2=0 / aq3=0
Language : English
Default : Yes
Forced : No
Color range : Limited
Color primaries : BT.709
Transfer characteristics : BT.709
Matrix coefficients : BT.709
Menu
00:00:00.000 : en:
So as You can see there is only one entry for chapter track in this MKV test file and it looks like this in MKVToolnix:
https://imgur.com/a/0kEwB
I'm attaching this 15 seconds "crashing" mkv here:
https://mega.nz/#!S8I3jTrC!uKzBYTuItxuME...jEIrqTzPgA
It's 13 MB only.
Can reproduce it with that file and attached to Visual Studio it reports a nulPtr for chaptername but no exact file and line yet:
The thread 0x4518 has exited with code 0 (0x0).
Unhandled exception thrown: read access violation.
chapterName was nullptr.
Might be something in code that is changed specifically for DSPlayer and will do some more debugging, tested a few BDs and rips with chapters but can't get the same error so definitely something specific about that file as well.
// Edit
Found the bug in ChapterManager:
g_charsetConverter.wToUTF8(chapterName, infos->name);
SysFreeString(chapterName);
Fix:
https://github.com/RickDB/xbmc/commit/cc...31fd596ba9
It's null there so added check and will post a new build later, why it wouldn't affect non-DSPlayer build I'm not 100% sure though.
Once aracnoz returns will cherry pick these changes in a PR
Yay! Wonderful Rick! Will this new build contain newly added "native D3D11 DXVA hardware decoding" option in DSPlayer UI You mentiond few posts earlier?
Unofficial build based on Kodi 17.5RC1 below,
recommend making backups beforehand as this my first go at building Kodi so errors may occur.
This is just a stop-gap measure till the developer returns as I can only do basic patches and builds like this.
Changelog since 17.3 DSPlayer:
- Updated to 17.5RC1 (git commit: 94bf83f)
- Latest LAV Filters included which support D3D11 HW accel, needs latest madVR version to work properly and doesn't work in combination with NNEDI (at least with my Nvidia setup).
- D3D11 added as LAV HW accel option from within UI.
- Bugfix for invalid chapter names resulting in crash, thanks @
Kolabor for debugging and spotting this error.
It's a bit early to include LAV Filters as they are from the nightly but already had the UI changes in place and seems to run just fine, if anyone runs into problems will revert it
Setup 32bit: DSPlayer 17.5RC1 Krypton - build (20170902-d83d21cd44)
Setup 64bit: Fails to compile.
Fork repo used in build for reference:
https://github.com/RickDB/xbmc/commits/Krypton_dsplayer
All credits go to @
aracnoz as this is just a build merged with all his changes.
<3 testing this build in a moment.
Re-uploaded build as I noticed Nev released a new LAV filter version today so used that because it included some D3D11 changes.
It installed and seems to be working, but when I tried to install it I got an error with the uninstall.exe, clicked retry and it did install. Just wanted to let you know.
(2017-09-02, 20:19)RickDB Wrote: [ -> ]Unofficial build based on Kodi 17.5RC1 below, recommend making backups beforehand as this my first go at building Kodi so errors may occur.
This is just a stop-gap measure till the developer returns as I can only do basic patches and builds like this.
Changelog since 17.3 DSPlayer:
- Updated to 17.5RC1 (git commit: 94bf83f)
- Latest LAV Filters included which support D3D11 HW accel, needs latest madVR version to work properly and doesn't work in combination with NNEDI (at least with my Nvidia setup).
- D3D11 added as LAV HW accel option from within UI.
- Bugfix for invalid chapter names resulting in crash, thanks @Kolabor for debugging and spotting this error.
It's a bit early to include LAV Filters as they are from the nightly but already had the UI changes in place and seems to run just fine, if anyone runs into problems will revert it
Setup 32bit: DSPlayer 17.5RC1 Krypton - build (20170902-d83d21cd44)
Setup 64bit: Fails to compile.
Fork repo used in build for reference:
https://github.com/RickDB/xbmc/commits/Krypton_dsplayer
All credits go to @aracnoz as this is just a build merged with all his changes.
Nice build, and not sure what else has changed as now bringing up the OSD is a lot smoother.
K