Kodi Community Forum

Full Version: VideoPlayer: expose stream player info to GUI - Info label names?
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
Could somebody tell me the correct info label names for this new feature, please? Tried everything but nothing seems to work.

Code:
const infomap player_process[] =
{
{ "videodecoder", PLAYER_PROCESS_VIDEODECODER },
{ "deintmethod", PLAYER_PROCESS_DEINTMETHOD },
{ "pixformat", PLAYER_PROCESS_PIXELFORMAT },
{ "videowidth", PLAYER_PROCESS_VIDEOWIDTH },
{ "videoheight", PLAYER_PROCESS_VIDEOHEIGHT },
{ "videofps", PLAYER_PROCESS_VIDEOFPS },
{ "videodar", PLAYER_PROCESS_VIDEODAR },
{ "videohwdecoder", PLAYER_PROCESS_VIDEOHWDECODER },
{ "audiodecoder", PLAYER_PROCESS_AUDIODECODER },
{ "audiochannels", PLAYER_PROCESS_AUDIOCHANNELS },
{ "audiosamplerate", PLAYER_PROCESS_AUDIOSAMPLERATE },
{ "audiobitspersample", PLAYER_PROCESS_AUDIOBITSPERSAMPLE }
};

See:
https://github.com/xbmc/xbmc/pull/9976

I know it's weekend and I assume that Ronie wasn't able to update the changes thread until now, but I have some spare time atm and want to implement this infos. Maybe someone can help me out Smile
I was curious too so gave it a try with the July 3 nightly, but no luck for me either. I tried Player.VideoDecoder and Player.Process(videodecoder).
(2016-07-03, 07:56)sualfred Wrote: [ -> ]I know it's weekend and I assume that Ronie wasn't able to update the changes thread until now, but I have some spare time atm and want to implement this infos. Maybe someone can help me out Smile

i have no weekends ;-)

to the best of my knowledge, these are VideoPlayer infolabels.
try VideoPlayer.VideoDecoder and so on...
(2016-07-03, 09:42)ronie Wrote: [ -> ]i have no weekends ;-)

to the best of my knowledge, these are VideoPlayer infolabels.
try VideoPlayer.VideoDecoder and so on...

Me neither, that's why I said some spare time Wink

Already tried a lot of combinations

No luck with:
VideoPlayer.XXX
Player.XXX
Player.Process(XXX)
VideoPlayer.Process(XXX)
ProcessInfo.XXX
etc.
should be player_process.xxx
(2016-07-03, 12:07)FernetMenta Wrote: [ -> ]should be player_process.xxx

Thanks, but something went wrong Wink

Label results:
videodecoder = Movie name
deintmethod = Movie genre
pixformat = a country value
videowidth = another movie name value
videofps = year or episodename

These and all the others are filled incorrectly.
^. same here.
(2016-07-03, 12:07)FernetMenta Wrote: [ -> ]should be player_process.xxx

Can I suggest we keep to the current standard?

Code:
VideoPlayer.xxx

Thanks.
Try with latest master (still using player_process.xxx but should give the correct information now)
fix is in master, thanks to Memphiz
(2016-07-03, 15:05)Hitcher Wrote: [ -> ]
(2016-07-03, 12:07)FernetMenta Wrote: [ -> ]should be player_process.xxx

Can I suggest we keep to the current standard?

Code:
VideoPlayer.xxx

Thanks.

Nope, because paplayer is not VideoPlayer
I would suggest to use "Player.Process(%s)", but I'm fine with Player_Process.

Just the "_" is tingeling my OSD a bit Wink

Thanks for the fast fix.
(2016-07-03, 16:01)sualfred Wrote: [ -> ]I would suggest to use "Player.Process(%s)", but I'm fine with Player_Process.

Just the "_" is tingeling my OSD a bit Wink

Thanks for the fast fix.

Can be changed. No a big deal.
In my eyes - and to be consistent - it should be changed, because we do not have any other "Foo_Bar.XXX" info label.

It's up to you and the other team members.
+1 to Player.Process(xxx) to keep consistency.

Or even Player.xxx
Pages: 1 2