Kodi Community Forum

Full Version: EMINENCE 2 MOD (REVIVED)
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
(2017-07-10, 10:49)Alanon Wrote: [ -> ]
(2017-07-09, 22:50)taurus35 Wrote: [ -> ]Hi Alanon,

Thanks for reviving this mod, I had been using the old version on Jarvis but today tried switching to this new version & upgrading to Krypton with Libreelec.

I have come across a few issues & not sure if they are bugs, settings I can't find to change or a carry over from the old version.

The first, is there appears to be some sort of dark overlay over the main movie information making the fanart very dark compared to the previous window, It also seems to cover the logo at the top of the screen & the movie info icons at the bottom but not the poster. Is there a setting for this, a bug or something you can remove or add a setting for?

The second, is the ratio of the posters on the Poster shift screen seem to be wrong, they are being cut off top & bottom. If you look at the two images below, you can see a comparison with the movie info screen which shows more image.

Also the following image is of the custom poster covers I made for collections which you can see are being cropped top & bottom.

The third, is related to the movie age rating. The rating is showing up correctly with the UK rating in the movie info page but on the poster shift page & under the movie info at the bottom, you can see it is showing what I assume is the US rating & is wrong. Storks is showing U in movie info but R below & previous view. Suicide Squad is showing 15 in movie info but R below & in previous view. I'm pretty sure Storks & Suicide Squad shouldn't both be R rated Smile

Cheers & keep up the great work.

Welcome to the skin. Wink

If you're transitioning from Jarvis, it will take some time to get used to this version. it might look the same, but there's a lot of stuff under the hood. You can always refer to the skin settings explanations, that give a bit more detail as to what each setting does. It's far from perfect, but it should help get you on the right track.

1. The darkness you see is an added background layer to ensure readability. The problem is, with all the custom colours and stuff across the skin, there are many setups that can be problematic. This background was added because people using the info on widgets found it unreadable, since the info screen simply overlayed over the home screen. Similar problems exist if you use a very light fanart background colour overall. So, for example, if you use a near-clear background colour and the light interface, you might have a hard time reading the text on certain occasions. Sadly, I can't distinguish all the user configurations and plan against them, so it's more of an "all or nothing at all" situation. In this instance, I can, of course, add the background to appear on widget use only, but I'm not sure if that .

2. The posters are a sore spot for me. Kodi gives us three options - stretch, scale and keep (the aspect ratio). Posters come in all variety of shapes and sizes and there are always subtle variances, especially with the custom ones. Problem is, I have to keep the interface consistent. If I choose to keep the AR then nothing would be consistent for ))% of the users and the borders and margins (which are not flexible in Kodi) would be larger on some posters and smaller on others. That's just plain ugly. So, that leaves us with stretch or scale. Stretch is abhorrent, or at least I despise it. That would indeed display the whole poster, but condensed into the space available. So it would in effect warp the image in order to fit it into the allocated space, which can look plain bad on beautiful posters. A few people notice it, but I've always found it very annoying. So I opted for scale, and the Kodi algorithm crops some of the bits off without touching the integrity of the image, while keeping everything looking uniform.

3. As for the ratings, I'm a bit confused. It looks like a bug and it could be due to several factors, but I'd need to know more of your setup and any patter you could discern related to the flags. Firstly, if you scraped the films using UK ratings, you shouldn't see R rating flags in the bottom, since the skin flags do include UK rating images. On the other hand, the "ghosting" of ratings from one film to another can happen if the rating field is somehow not scraped or otherwise empty, and the skin is performing an online lookup, which can take a while based on the condition of the APIs Skin Helper uses. This can also happen because of caching issues, when the values aren't properly placed for whatever reason and the skin thinks that the field is empty and fills it with the previous one.

Alanon, Thanks for your reply.

1. Are you saying there is currently no setting to turn off the dark overlay on the movie info screen? In my opinion it doesn't look very good, especially covering the logo, weather & time at the top & icons along the bottom. I don't really see the need for it if it's not required on the previous poster shift screen to read any text. It would be great if there was a setting to turn it off or change the transparency of it so it can be changed to zero if needed.

2. Sorry to hear about your issues with posters. I undestand there being a need to be able to crop, stretch or whatever for posters that are an unusual ratio. My issue is that the the poster ratio is different on the two screens shown above. If there is no cutoff on the movie info screen, surely the poster should be the same ratio on the poster shift screen & clearly it's being cutoff? If you look at the Suicice Squad images you can see that both posters are different. My custom posters are made to the same ratio as the ones that are downloaded with artwork downloader & aren't cutoff in other skins.

3. Not sure what else I can add except that yes, I did scrape the movies using the UK ratings. I have seen the ghosting from previous screens you mentioned on other things in the past but it doesn't seem to be that. I'll have a play around & see if I can figure anything out but it either seems to be R rated or nothing, there's nothing inbetween.

4. I have also discovered what appears to be another bug tonight.....sorry. When pressing up from the home screen to activate the currently running TV shows widget & then clicking on an item to play, instead of playing straight away it brings up the episode info window over the top of the widget screen which can be seen throught it with the option to play selected.

Keep up the great work.
(2017-07-10, 22:49)taurus35 Wrote: [ -> ]1. Are you saying there is currently no setting to turn off the dark overlay on the movie info screen? In my opinion it doesn't look very good, especially covering the logo, weather & time at the top & icons along the bottom. I don't really see the need for it if it's not required on the previous poster shift screen to read any text. It would be great if there was a setting to turn it off or change the transparency of it so it can be changed to zero if needed.

2. Sorry to hear about your issues with posters. I undestand there being a need to be able to crop, stretch or whatever for posters that are an unusual ratio. My issue is that the the poster ratio is different on the two screens shown above. If there is no cutoff on the movie info screen, surely the poster should be the same ratio on the poster shift screen & clearly it's being cutoff? If you look at the Suicice Squad images you can see that both posters are different. My custom posters are made to the same ratio as the ones that are downloaded with artwork downloader & aren't cutoff in other skins.

3. Not sure what else I can add except that yes, I did scrape the movies using the UK ratings. I have seen the ghosting from previous screens you mentioned on other things in the past but it doesn't seem to be that. I'll have a play around & see if I can figure anything out but it either seems to be R rated or nothing, there's nothing inbetween.

4. I have also discovered what appears to be another bug tonight.....sorry. When pressing up from the home screen to activate the currently running TV shows widget & then clicking on an item to play, instead of playing straight away it brings up the episode info window over the top of the widget screen which can be seen throught it with the option to play selected.

Keep up the great work.

1. I'm trying to cut back on settings for the moment, there seem to be too many, people are starting to get confused, and that's not good. But I will switch it off and leave it on the widgets only.

2. The problem is, different sites have different standards. And while fanart.tv might use images with 1.5 dimension ratio, TMDB uses something like 1,445 or less. The difference between these ratios is pretty much the cut-off point for the posters you experienced. I believe the skin itself was always using dimensions more appropriate for the TMDb posters. (I think season posters are the best gauge for this, they are almost always 1.45) There's no way to differentiate between them, and no way to make them both display properly. No matter what setting or poster dimensions are used, they will be incompatible with the other one.

Even if I manually changed the dimensions of every poster display in the skin to match the 1.5 ratio - which would necessitate a painstaking redesign of many other elements - in the end, that still wouldn't fix the issue for everyone else using different posters. Don't get me wrong, I have no problem changing things, and since I don't use the poster list very much, I'll gladly change it to stretch the posters for the available dimensions. But, I fear that if you're detail-oriented enough to notice the poster cut-off, you'll be able to see and cringe over the pixels worth of stretching done to the image in order to make it fit.

3. Wait, just the R rating, or none whatsoever? Huh

4. I can't reproduce that bug. On the keyboard, enter always plays the episode directly from the widget, it plays everything directly, and "i" always displays the info. The only way I can think of for it to display the info screen on pressing play, is if you changed the default select behaviour in Kodi settings, and set it to "Show information"?
I have noticed that sometimes the skin will randomly switch the list view type to thumbnail. This is very annoying because the people who use my build aren't savvy enough to fix it. Any idea why this happens and how to fix it?


This doesn't seem to happen when I set my view type to other stuff.
(2017-07-11, 09:42)Alanon Wrote: [ -> ]1. I'm trying to cut back on settings for the moment, there seem to be too many, people are starting to get confused, and that's not good. But I will switch it off and leave it on the widgets only.

2. The problem is, different sites have different standards. And while fanart.tv might use images with 1.5 dimension ratio, TMDB uses something like 1,445 or less. The difference between these ratios is pretty much the cut-off point for the posters you experienced. I believe the skin itself was always using dimensions more appropriate for the TMDb posters. (I think season posters are the best gauge for this, they are almost always 1.45) There's no way to differentiate between them, and no way to make them both display properly. No matter what setting or poster dimensions are used, they will be incompatible with the other one.

Even if I manually changed the dimensions of every poster display in the skin to match the 1.5 ratio - which would necessitate a painstaking redesign of many other elements - in the end, that still wouldn't fix the issue for everyone else using different posters. Don't get me wrong, I have no problem changing things, and since I don't use the poster list very much, I'll gladly change it to stretch the posters for the available dimensions. But, I fear that if you're detail-oriented enough to notice the poster cut-off, you'll be able to see and cringe over the pixels worth of stretching done to the image in order to make it fit.

3. Wait, just the R rating, or none whatsoever? Huh

4. I can't reproduce that bug. On the keyboard, enter always plays the episode directly from the widget, it plays everything directly, and "i" always displays the info. The only way I can think of for it to display the info screen on pressing play, is if you changed the default select behaviour in Kodi settings, and set it to "Show information"?

Alanon,

1. Thanks, that would be great. I agree there are a lot of settings but I have seen skins with a lot, lot more & it's always good to be able please more of the people more of the time Big Grin

2. I don't think I'm explaining it very well. I understand there are slightly different ratios of posters that can be downloaded which makes your life a nightmare & the skin look iffy at times, my issue is that all the posters throughout the skin should be the exact same ratio & I don't see a reason why they are not but I'm not a skinner. If you look closely & compare top & bottom at the Suicide Squad posters above, both screenshots from your skin & the same poster, one is cropped off & the other is not. Surely the one in the poster shift view can be the same ratio as the one in the movie info screen? Or is this a Krypton issue as it didn't use to happen in the in the previous mod of the skin.

3. Yes, that's all I have seen so far but haven't gone through every movie. I'll have a play & see if I can see a pattern.

4. I haven't changed any default behaviour as far as I know. My setting has always been to show movie info when clicking on a movie poster & not to play it. But when doing that on a widget poster it has always just played the file straight away or brought up the resume/play from start sub menu. I noticed today that if I select & hold the OK button it will bring up the resume sub menu but if I just click it will bring up movie info (with a very pale background) over the top of widget menu & looks a horrible mess. Unfortunately when I try to take a screenshot the movie info page vanishes instantly & I'm just left with the widgets page captured.

Thanks for all your help & great work.


EDIT: To add to 3. above, I have just been going through the movies & found a pattern.
If there is no UK rating on the movie info page then there is no rating icon at the bottom of screen.
If the UK rating is either Rated, Rated U, Rated 12, Rated 12A, Rated 15 or Rated 18 then the rating at the bottom is R
If the UK Rating is Rated PG then the rating at the bottom is PG
Hope this helps diagnose the problem.
(2017-07-11, 15:37)wonslung Wrote: [ -> ]I have noticed that sometimes the skin will randomly switch the list view type to thumbnail. This is very annoying because the people who use my build aren't savvy enough to fix it. Any idea why this happens and how to fix it?


This doesn't seem to happen when I set my view type to other stuff.

did you set a default view for your "movies " "shows" and "clips " ? if not , do so and it should be good to go.
(2017-07-11, 15:37)wonslung Wrote: [ -> ]I have noticed that sometimes the skin will randomly switch the list view type to thumbnail. This is very annoying because the people who use my build aren't savvy enough to fix it. Any idea why this happens and how to fix it?


This doesn't seem to happen when I set my view type to other stuff.

First, I've made a bunch of changes in the latest version, soon to be released, and I believe this might be fixed.

If it's not what I think it is, without any logs, best I could guess is that some add-ons might have specialised force view settings that get triggered and bleed through to the regular view types. Add-on forced views are strange and force the skin to behave in unpredictable ways.
(2017-07-11, 16:29)taurus35 Wrote: [ -> ]Alanon,

1. Thanks, that would be great. I agree there are a lot of settings but I have seen skins with a lot, lot more & it's always good to be able please more of the people more of the time Big Grin

2. I don't think I'm explaining it very well. I understand there are slightly different ratios of posters that can be downloaded which makes your life a nightmare & the skin look iffy at times, my issue is that all the posters throughout the skin should be the exact same ratio & I don't see a reason why they are not but I'm not a skinner. If you look closely & compare top & bottom at the Suicide Squad posters above, both screenshots from your skin & the same poster, one is cropped off & the other is not. Surely the one in the poster shift view can be the same ratio as the one in the movie info screen? Or is this a Krypton issue as it didn't use to happen in the in the previous mod of the skin.

3. Yes, that's all I have seen so far but haven't gone through every movie. I'll have a play & see if I can see a pattern.

4. I haven't changed any default behaviour as far as I know. My setting has always been to show movie info when clicking on a movie poster & not to play it. But when doing that on a widget poster it has always just played the file straight away or brought up the resume/play from start sub menu. I noticed today that if I select & hold the OK button it will bring up the resume sub menu but if I just click it will bring up movie info (with a very pale background) over the top of widget menu & looks a horrible mess. Unfortunately when I try to take a screenshot the movie info page vanishes instantly & I'm just left with the widgets page captured.

Thanks for all your help & great work.


EDIT: To add to 3. above, I have just been going through the movies & found a pattern.
If there is no UK rating on the movie info page then there is no rating icon at the bottom of screen.
If the UK rating is either Rated, Rated U, Rated 12, Rated 12A, Rated 15 or Rated 18 then the rating at the bottom is R
If the UK Rating is Rated PG then the rating at the bottom is PG
Hope this helps diagnose the problem.

1. I honestly don't mind the settings, but I'm simply running out of logical, well thought-out places to put them...

2. Well, the simple answer would be that it depends on the way the image dimensions are given in the skin, i.e, it's not the same if you define all four sides, as opposed to defining the height only, and then using a percentile, or parameter, etc. Some of the differences might stem from that, as not all of these methods are ideal to use in all views and setups. Now, I haven't really delved into the dimensions of the posters myself, but I'd venture a guess that some were simply accidental picks, or modified to fit better within a view type's overall design. The difference you noticed is definitely due to different poster dimensions. I'd say that they were made so because of the overall list flow and the border frames and that the video info simply had the more appropriate dimensions for your poster from the get-go. It might be that they could be a reverse case, with the poster being cut off in the info screen and not in the view. As the original skin always almost always preferred to stretch, it was of no consequence. Anyways, long story short, I'll look into the posters and see if I can't make them more consistent with anything resembling a Kodi standard to minimise scaling.

3. I think I know why this happens, and it should be fixed in the next update.

4. I believe a single click is counted as select. I think there might have been some change in Krypton settings. Try going to Skin Settings /Library /Video, there's a setting called "Default select action". That should determine the library single click action.
I was wondering if there was anyway to prevent the library screen shown in the screenshot below from showing when launching an addon? I don't know if this is a skin specific thing or just how kodi works but i'd really like to hide it somehow


when i select a menu item or back out of the menu, i'd rather it happen cleanly

Image
(2017-07-12, 05:11)wonslung Wrote: [ -> ]I was wondering if there was anyway to prevent the library screen shown in the screenshot below from showing when launching an addon? I don't know if this is a skin specific thing or just how kodi works but i'd really like to hide it somehow


when i select a menu item or back out of the menu, i'd rather it happen cleanly

Normally, it is a Kodi quirk and nothing can be done. However, if you enable the setting "Enable onback command" in the Skin Settings /library section, it will allow you some control over that behaviour. Bear in mind that it's more of a hack/workaround, and uses only what Kodi gives it. It will work, fo example, when you are using shortcuts or browsing add-ons from any other shortcut - QuickNav, submenu or main menu. The setting will allow you to return to your point of origin when you press back. It won't work always, and it will only work with the back command - the dots at the top of most content menus will always have the same result.

I believe that the behaviour might also be changed on a more in-depth level by using the Library Node Editor add-on, although I'm not sure since I haven't done any research on the matter.
Alanon, the new Showcase widgets are sweet!!
Is there a shortcut to the Showcase widget so i can make it a homescreen tab? What would the custom command be to make it open as a home screen tab, rather than pressing down in a spot with no submenu? Thanks!
(2017-07-12, 01:09)Alanon Wrote: [ -> ]1. I honestly don't mind the settings, but I'm simply running out of logical, well thought-out places to put them...

2. Well, the simple answer would be that it depends on the way the image dimensions are given in the skin, i.e, it's not the same if you define all four sides, as opposed to defining the height only, and then using a percentile, or parameter, etc. Some of the differences might stem from that, as not all of these methods are ideal to use in all views and setups. Now, I haven't really delved into the dimensions of the posters myself, but I'd venture a guess that some were simply accidental picks, or modified to fit better within a view type's overall design. The difference you noticed is definitely due to different poster dimensions. I'd say that they were made so because of the overall list flow and the border frames and that the video info simply had the more appropriate dimensions for your poster from the get-go. It might be that they could be a reverse case, with the poster being cut off in the info screen and not in the view. As the original skin always almost always preferred to stretch, it was of no consequence. Anyways, long story short, I'll look into the posters and see if I can't make them more consistent with anything resembling a Kodi standard to minimise scaling.

3. I think I know why this happens, and it should be fixed in the next update.

4. I believe a single click is counted as select. I think there might have been some change in Krypton settings. Try going to Skin Settings /Library /Video, there's a setting called "Default select action". That should determine the library single click action.

Hi Alanon,

1. I appreciate your efforts & don't mind which way you do as long as I can get rid of that dark overlay & have the backgrounds look consistent from page to page.

2. Again I appreciate it & hope there is something you can do to prevent cut off on the Poster List view. If they are still the same ratio as in the previous MOD then stretch is fine by me as I didn't notice anything & there is quite a thin border around 3 sides of my sets posters.

3. Great, look forward to the next update.

4. I believe that's the setting that's always been in Kodi, although I think there is a couple more options now. I have always had that set to Show Movie Info, so that when in Poster ist view it didn't start playing the movie. With it set this way, on the widget it still used play straight away. Maybe this is not possible now in Krypton & I will have to remember to hold instead of single press.....unless there's something you can do for widgets. Below is what I get when I single click on a widget poster, so if that's the way it has to be, that view needs some workas you can see.

Image


Image


Cheers.
Interesting bug, occured after listening to music:

Image

First 2 pics show the bug, third pic shows how it should be (fixed after reboot)

Could not reproduce it since it happened.
(2017-07-12, 21:29)taurus35 Wrote: [ -> ]4. I believe that's the setting that's always been in Kodi, although I think there is a couple more options now. I have always had that set to Show Movie Info, so that when in Poster ist view it didn't start playing the movie. With it set this way, on the widget it still used play straight away. Maybe this is not possible now in Krypton & I will have to remember to hold instead of single press.....unless there's something you can do for widgets. Below is what I get when I single click on a widget poster, so if that's the way it has to be, that view needs some workas you can see.

Cheers.

Now that you mentioned it, there was an issue way back when I first started modding the skin, when folks were unable to anything with the widgets, as the skin just ignored all clicks on them. I forget the details, but Krypton definitely changed something in those settings, which broke the previous method, and I don't think that anything short of tying it to the default worked. Things like that are tricky as they're usually built into Kodi. The only thing that comes to mind with regards to a workaround would be a custom keymap, but even if a click could be added there, it would be universal.

(2017-07-12, 23:01)VelvetKevorkian Wrote: [ -> ]Interesting bug, occured after listening to music:

First 2 pics show the bug, third pic shows how it should be (fixed after reboot)

Could not reproduce it since it happened.

That and also hanging fanart fits what I've seen, though I can't say if it's been after music playback specifically. Usually, it was after multiple skin reloads and/or skin tweaking in one Kodi session. Sometimes the cache seems to simply get confused and mix things up. I believe I've also seen it in a different skin once. Anyways, since my logs were always pretty much silent on the issue, I blamed it on the gremlins.
(2017-07-12, 21:17)jdig4240 Wrote: [ -> ]Alanon, the new Showcase widgets are sweet!!
Is there a shortcut to the Showcase widget so i can make it a homescreen tab? What would the custom command be to make it open as a home screen tab, rather than pressing down in a spot with no submenu? Thanks!

Whoops, just saw the post. Sorry for skipping you. Big Grin

You can use "ActivateWindow(1131)" as a custom action. That will have an effect of a separate window.
(2017-07-13, 01:04)Alanon Wrote: [ -> ]
(2017-07-12, 21:17)jdig4240 Wrote: [ -> ]Alanon, the new Showcase widgets are sweet!!
Is there a shortcut to the Showcase widget so i can make it a homescreen tab? What would the custom command be to make it open as a home screen tab, rather than pressing down in a spot with no submenu? Thanks!

Whoops, just saw the post. Sorry for skipping you. Big Grin

You can use "ActivateWindow(1131)" as a custom action. That will have an effect of a separate window.

Perfecto! Thanks bud! Love the showcase.