(2017-11-03, 12:09)ZERO Wrote: [ -> ]The problem at least from what I saw was that as long as the conntrollabel 4420 existed you could never view normal fan art in the skin at all. I will do some more testing but I would worry about creating a condition where as new users have some sort of complicated setup just to get normal fan art to load such as installing and disabling Artwork Beef.
Perhaps I am not seeing normal behavior, it also could just be that you can not have the ListItem.Art(fanart) directly in the 4420 control.
It could also be something stupid that I have a bug with kodi itself on my end. I will continue retests until I can get it to work without completely removing 4420
Well, most people don't use Artwork Beef, so they won't have it installed at all, ever. The majority of users are simply used to using Skin Helper + Artwork Downloader combo. That's the way most skins set up their artwork management, and that's what's in all the Kodi beginner tutorials. Artwork Beef was always intended as an addition to the regular option - that provides some more complicated options and benefits for the people who need them - as there aren't many skins that support it and it requires a procedure and understanding that most users aren't used to. Granted, the solution is far from ideal, but I really couldn't think of anything that would allow for maximum ease, compatibility and reliability, and this ought to work 99% of the time for 99% of users.
Basically, I'm betting on the fact that you have to know about the add-on first to get the idea to try and use it at all. xD Any automatic artwork management solution requires some setting up, but Artwork Downloader's is simply the norm these days. Of course, if all else fails, I can add a skin setting that switches between Artwork Downloader and Artwork Beef, and we can then use the setting as a surefire condition for the fadelabel, but that is bound to cause confusion among ordinary, non-tinkering users, who will then want to know what this Artwork Beef is, and maybe try it out without properly understanding how it works, and be forced to repair their libraries because of it. Setting up Artwork Beef properly is a process, regardless if you come from Artwork Downloader or not. I'd like to avoid this potential pitfall, if possible.
The bug, however, confuses me. Aside from the add-on presence check, there are also conditions that check if either the fanart1 or tvshow.fanart1 that Beef sets up is empty, which should further ensure that if you don't use it, it won't trigger. Even more so, since the mere presence of a control in the variable list should not negate everything -
unless it is triggered for some reason, which would only happen if all the conditions were true. The only explanation for that would be that 1) You still have Artwork beef installed, and 2) At some point you ran a partial setup with Beef which left some traces, and thus left some info filed? In that case, the variable would trigger, but since there was no proper setup, it would be broken for almost everything.
Regardless, I'm 90% certain that simply disabling or uninstalling the add-on should cut through all those potential issues and just make the whole line invalid...