I am developing a new skin, which is currently in a private beta stage. One of the testers have submitted a bug report where switching from my skin to Estuary crashes Kodi (on Windows 10). I can reproduce the problem 100% (on OSX).
So far it seems to happen exclusively when switching to Estuary. I am at a loss as to what could be causing it. I can of course submit debug logs and crash reports, but as it seems to be skin related, what would be the best place? Here, trac, Git?
Cheers
(2017-05-15, 02:06)ronie Wrote: [ -> ]that's not a Debug Log ;-)
The second one isn't? Not sure what I'm missing then
log
As the crash happens when switching from my skin to Estuary, what stages does Kodi go through between unloading one skin and loading the other? Which xml's play a part in this process? DialogSelect.xml, as it is the last window in use before switching? Could it be something in my addon.xml?
I just have no idea where to begin looking for the cause of this.
On a (possibly) related note: what could be cause of an entry like:
Code:
09:43:39.476 T:1752810480 WARNING: CSkinInfo: failed to load skin settings
When attempting to install a skin from zip? (this is on 17.1)
edit: seems like that failed to load skin setting is safe to ignore, going by some previous forum posts about this
I would start by eliminating any addons from the equation. Start with a fresh install, only the skin without dependencies. See if it still crashes then when switching to Estuary. It seems hard to believe its skin code from your skin as that's unloaded already when it crashes.
(2017-05-15, 12:44)BigNoid Wrote: [ -> ]I would start by eliminating any addons from the equation. Start with a fresh install, only the skin without dependencies. See if it still crashes then when switching to Estuary. It seems hard to believe its skin code from your skin as that's unloaded already when it crashes.
I'll try that tonight, thanks. I don't have a whole lot of dependencies, but hopefully that will get me a step further. It's just so strange to me that it only happens when switching to Estuary. Switching to any other skin that I tried, no issues
And the "biggest" add-ons I use (skin shortcuts, service helper) aren't used in Estuary afaik.
So I deleted my entire Kodi installation, all the add-ons, anything related. Unfortunately I am no closer to a solution.
The crash still occurs, only when switching to Estuary:
https://pastebin.com/kdjVZkLN
Restarted Kodi, switched from my skin to Estouchy, no crash:
https://pastebin.com/EycBfFSk
Also updated to a nightly just in case and tried replacing DialogSelect.xml with a barebones version
I could take a look if you want. Just need a link to the skin than.
Thanks, sent you an invitation on Github (it's currently on a private repo)
Okay, it's because Estuary uses a custom window with id 1100 as window. If that's changed to type="dialog" or if you remove 1100 from your skin, the crash is gone.
EDIT:
The crash is also gone when you only remove the visibility line in 1100 on ln 3. I bet the custom windows are kept in memory and it can't handle the change from window type to dialog type.
Awesome that you were able to pinpoint the cause, it will be no problem to just use a different window ID. Huge thanks !
This is fixed in Kodi master (v18 nightly builds).