Kodi Community Forum

Full Version: Light IMDb Ratings Update 5.1.3
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Axlt, this is it. I've changed manually addon id to script.light.imdb.ratings.update in:
service.light.imdb.ratings.update/addon.xml
service.light.imdb.ratings.update/service.py
service.light.imdb.ratings.update/resources/support/autoconf.py
service.light.imdb.ratings.update/resources/library/common.py

and addon is working now on 8.1.1

There is also (new?) bug. After changed to scheduled time I must deactivate/activate addon for starting this background work in new time.
And only then in log shows:
DEBUG: [Light IMDb Ratings Update] - Service scheduled the 2017-09-27 at 10:50

I will give more info, but addon is working now (scheduled update) and must wait to end.
(2017-09-20, 11:07)dziobak Wrote: [ -> ]Axlt, this is it. I've changed manually addon id to script.light.imdb.ratings.update in:
service.light.imdb.ratings.update/addon.xml
service.light.imdb.ratings.update/service.py
service.light.imdb.ratings.update/resources/support/autoconf.py
service.light.imdb.ratings.update/resources/library/common.py

and addon is working now on 8.1.1

There is also (new?) bug. After changed to scheduled time I must deactivate/activate addon for starting this background work in new time.
And only then in log shows:
DEBUG: [Light IMDb Ratings Update] - Service scheduled the 2017-09-27 at 10:50

Ok, this sounds really weird but if it works is good! Confused Did you make the modifications directly to the files whitout reinstalling the add-on?

So, it seems we can say that the add-on works on LibreELEC 8.1.1 (Kodi 17.4) with that modification. Before going ahead with a new release I would also have a feedback from djhifi...may be that modification will solve his issue too.

Anyway it is clear that LibreELEC users experienced different issues with the same add-on version as well as the same LibreELEC version (see your case and the on of djhifi)...this is still something that I can not explain to myself...

About the scheduled time I dind't have that issue. Please note that such debug string actually appears when you change the schedule time and press the OK button in the settings. When the service is just launched at Kodi start, that strings does not appear in the log. I have tried it right now and the scheduled time is updated without having to deactivate/reactivate the add-on.

Btw, thanks for your interest! Nod I'm waiting for some good news from djhifi now...
(2017-09-12, 14:39)axlt2002 Wrote: [ -> ]
(2017-09-10, 14:58)tmacca Wrote: [ -> ]Thanks Alex, I'll leave it with you. Would be great if we could get this working on OSMC :-)

Hi tmacca and Jelf10,

Can you please try the following command to download the php binary on your platform?

Code:
$ sudo apt-get install php7.0-cgi

Please refer also to this page for more details for Debian 8 (jessie).

Once downloaded, can you provide me that file so I can write a test build of the add-on?

Thanks in advance for any help.

Alex

Hi tmacca and Jelf10,

Do you have any news on the point above? Would be nice to progress on OSMC too...

Cheers,

Alex
(2017-09-20, 11:42)axlt2002 Wrote: [ -> ]Ok, this sounds really weird but if it works is good! Confused Did you make the modifications directly to the files whitout reinstalling the add-on?

Yes, this is fastest way Smile
I run addon and follow errors in logs, change one file and run again. Also with scheduled.

(2017-09-20, 11:42)axlt2002 Wrote: [ -> ]About the scheduled time I dind't have that issue. Please note that such debug string actually appears when you change the schedule time and press the OK button in the settings. When the service is just launched at Kodi start, that strings does not appear in the log. I have tried it right now and the scheduled time is updated without having to deactivate/reactivate the add-on.

I checked this very strictly (few times). Scheduled work not start (8.1.1) after change, press OK, disable/enable in addon config and so on. Only deactivate/activate of addon gives scheduled work (and gives line log about settings this scheduled work). After addon activation there is PHP update, then window with info appears and after click this info -> log line about settings of schedule job shows. And only then scheduled work start at time.
(2017-09-20, 11:58)dziobak Wrote: [ -> ]
(2017-09-20, 11:42)axlt2002 Wrote: [ -> ]Ok, this sounds really weird but if it works is good! Confused Did you make the modifications directly to the files whitout reinstalling the add-on?

Yes, this is fastest way Smile
I run addon and follow errors in logs, change one file and run again. Also with scheduled.

Ok, may be there have been some changes with respect to the previous versions of LibreELEC (even if it sounds really strange to me!). And I can not understand why the same issue was not experienced by djhifi...

(2017-09-20, 11:58)dziobak Wrote: [ -> ]
(2017-09-20, 11:42)axlt2002 Wrote: [ -> ]About the scheduled time I dind't have that issue. Please note that such debug string actually appears when you change the schedule time and press the OK button in the settings. When the service is just launched at Kodi start, that strings does not appear in the log. I have tried it right now and the scheduled time is updated without having to deactivate/reactivate the add-on.

I checked this very strictly (few times). Scheduled work not start (8.1.1) after change, press OK, disable/enable in addon config and so on. Only deactivate/activate of addon gives scheduled work (and gives line log about settings this scheduled work). After addon activation there is PHP update, then window with info appears and after click this info -> log line about settings of schedule job shows. And only then scheduled work start at time.

Please note that any change to the scheduled time has effect (and sense) only after the PHP installation has been performed. As you described, it seems you tried to change the scheduled time before it. What it is strange (this LibreELEC 8.1.1 is going to make me crazy!!!!) is that the PHP installation should start automatically after having installed the add-on...did this happen or not? In fact, deactivating and reactivating the add-on is almost the same as reinstalling the add-on. Can you please try with a clean installation of the add-on with the debug log enabled? The PHP installation is expected to start after around 10 seconds...can you confirm? After that you can change the scheduled time as you prefer.
(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]Please note that any change to the scheduled time has effect (and sense) only after the PHP installation has been performed. As you described, it seems you tried to change the scheduled time before it.

No, after activation and after PHP install. And without success of starting scheduled job. Then I was start searching -> this gives result like in post before.

(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]The PHP installation is expected to start after around 10 seconds...can you confirm?

Yes...

(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]After that you can change the scheduled time as you prefer.

OK, I will check this ones more and give you info. I will change of addon id in zipped source 2.1.1 and make clean install.

About scheduled work, this work now, updates movies, series and episodes.
OK, clean install with modified source and this time success!
After change of scheduling time in config debug line appears:
12:56:26.411 T:1474294688 DEBUG: [Light IMDb Ratings Update] - Service scheduled the 2017-09-20 at 13:00
(2017-09-20, 12:43)dziobak Wrote: [ -> ]
(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]Please note that any change to the scheduled time has effect (and sense) only after the PHP installation has been performed. As you described, it seems you tried to change the scheduled time before it.

No, after activation and after PHP install. And without success of starting scheduled job. Then I was start searching -> this gives result like in post before.

(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]The PHP installation is expected to start after around 10 seconds...can you confirm?

Yes...

(2017-09-20, 12:17)axlt2002 Wrote: [ -> ]After that you can change the scheduled time as you prefer.

OK, I will check this ones more and give you info. I will change of addon id in zipped source 2.1.1 and make clean install.

About scheduled work, this work now, updates movies, series and episodes.

Ok, I will wait for your feedback then. Good that everything is updating now. I engourage djhifi to contact you for the test-build then Wink May be you can post it in this thread using zippyshare.

My considerations above were due to the fact that you wrote "After addon activation there is PHP update, then window with info appears and after click this info -> log line about settings of schedule job shows. And only then scheduled work start at time.". This means that the PHP installation was not ok (e.g. completed) after the first run of the add-on...and therefore no update on the scheduled time would take effect...
(2017-09-20, 12:59)dziobak Wrote: [ -> ]OK, clean install with modified source and this time success!
After change of scheduling time in config debug line appears:
12:56:26.411 T:1474294688 DEBUG: [Light IMDb Ratings Update] - Service scheduled the 2017-09-20 at 13:00

Just....perfect! Can you share it to djhifi? If it is going to work for him too, I will release a new version of the add-on supporting OSMC 8.1.x (hoping that such changes will not cause any issue on the other platforms...)
(2017-09-20, 13:07)axlt2002 Wrote: [ -> ]Ok, I will wait for your feedback then. Good that everything is updating now. I engourage djhifi to contact you for the test-build then Wink May be you can post it in this thread using zippyshare.

2.1.1 with changes (paths and IDs modified to script.light.imdb.ratings.update):
http://www73.zippyshare.com/v/Mpo29tOS/file.html
(2017-09-20, 13:14)dziobak Wrote: [ -> ]
(2017-09-20, 13:07)axlt2002 Wrote: [ -> ]Ok, I will wait for your feedback then. Good that everything is updating now. I engourage djhifi to contact you for the test-build then Wink May be you can post it in this thread using zippyshare.

2.1.1 with changes:
http://www61.zippyshare.com/v/b2tvrsJA/file.html

Cool!

@djhifi, can you please perform a clean install of the add-on using this test build? Let's cross our fingers...

Does anyone of the LibreELEC users know the rational about the addon ids?!?!?
(2017-09-20, 04:37)dziobak Wrote: [ -> ]After upgrade to 8.1.1:

02:19:37.378 T:1945002096 ERROR: RunAddon: unknown add-on id 'service.light.imdb.ratings.update', or unexpected add-on type (not a script or plugin).
02:20:45.650 T:1330209696 ERROR: Previous line repeats 1 times.

is this problem with second line of addon.xml (word "service" instead "script or plugin")?

<addon id="service.light.imdb.ratings.update" ...

@dziobak, can you please open a thread on the LibreELEC forum to point at this issue? It would be really great to understand the magic behind it...thanks!
(2017-09-20, 13:23)axlt2002 Wrote: [ -> ]
(2017-09-20, 04:37)dziobak Wrote: [ -> ]After upgrade to 8.1.1:

02:19:37.378 T:1945002096 ERROR: RunAddon: unknown add-on id 'service.light.imdb.ratings.update', or unexpected add-on type (not a script or plugin).
02:20:45.650 T:1330209696 ERROR: Previous line repeats 1 times.

is this problem with second line of addon.xml (word "service" instead "script or plugin")?

<addon id="service.light.imdb.ratings.update" ...

@dziobak, can you please open a thread on the LibreELEC forum to point at this issue? It would be really great to understand the magic behind it...thanks!

This was planned I think - like info from logs that I put on previous page (invoked scripts with bad ID).

Add-on 2.1.1 "script version" with fix (I changed too much before)
http://www73.zippyshare.com/v/Mpo29tOS/file.html
(2017-09-20, 13:59)dziobak Wrote: [ -> ]
(2017-09-20, 13:23)axlt2002 Wrote: [ -> ]
(2017-09-20, 04:37)dziobak Wrote: [ -> ]After upgrade to 8.1.1:

02:19:37.378 T:1945002096 ERROR: RunAddon: unknown add-on id 'service.light.imdb.ratings.update', or unexpected add-on type (not a script or plugin).
02:20:45.650 T:1330209696 ERROR: Previous line repeats 1 times.

is this problem with second line of addon.xml (word "service" instead "script or plugin")?

<addon id="service.light.imdb.ratings.update" ...

@dziobak, can you please open a thread on the LibreELEC forum to point at this issue? It would be really great to understand the magic behind it...thanks!

This was planned I think - like info from logs that I put on previous page (invoked scripts with bad ID).

Ok, this means that the modifications you have made are too much impacting... Wink In fact, I have also tried the version you posted and it doesn't work on my machine...returning back to the official 2.1.1 version is instead ok.

So, for the time being let's put a part all the discussion we had until now...can you completely uninstall the current version of the add-on (please verify that also the folder under addon_data folder is removed) and perform a clean install of the official 2.1.1 version with the debug log enabled? Please post the log on pastebin or use again zippyshare.

Thanks in advance! Nod
(2017-09-20, 13:59)dziobak Wrote: [ -> ]
(2017-09-20, 13:23)axlt2002 Wrote: [ -> ]
(2017-09-20, 04:37)dziobak Wrote: [ -> ]After upgrade to 8.1.1:

02:19:37.378 T:1945002096 ERROR: RunAddon: unknown add-on id 'service.light.imdb.ratings.update', or unexpected add-on type (not a script or plugin).
02:20:45.650 T:1330209696 ERROR: Previous line repeats 1 times.

is this problem with second line of addon.xml (word "service" instead "script or plugin")?

<addon id="service.light.imdb.ratings.update" ...

@dziobak, can you please open a thread on the LibreELEC forum to point at this issue? It would be really great to understand the magic behind it...thanks!

This was planned I think - like info from logs that I put on previous page (invoked scripts with bad ID).

Add-on 2.1.1 "script version" with fix (I changed too much before)
http://www73.zippyshare.com/v/Mpo29tOS/file.html

Ok, I was writing the post above while you provided the new version...

Does this version work for you (i.e. movies and tv shows are updated) on LibreELEC 8.1.1?