Kodi Community Forum

Hi everyone,

i installed version 3.1.0 an hour ago on my nvidia shield with kodi 17.4 and it works GREAT! It updated every movie with rating, votes, the top 250 movies and every tv show way faster than before. thank you all for making this awesome add-on even more awesome!

Have a great weekend

cgi2011

I updated to fixes_5 and now I don't get any errors when trying to update the ratings of a show. Thank you.

(2017-10-21, 14:24)dziobak Wrote: [ -> ]

(2017-10-21, 13:16)Glottis Wrote: [ -> ]I installed version 3.1.0 AKA "Speed Runner" and tried to update a tv show. Am I the only one getting this error?
Libreelec 8.1.2 (Odroid_C2.aarch64)
Thank you for your work so far!

Pls re-download, I changed this version few times (small bugs fixed), actual has fixes_5 in zip name.

Hi dziobak,

Thanks a lot for progressing in the add-on development; it seems there were a lot stuffs to be fixed, and most of them depending on the fact of having big libraries to scan (I'm not going beyond 200 Movies and 5 TV Shows). 

I would just have appreciated more interaction instead of finding several dumps of releases without being warned (I have spent quite a lot of my free time to reach the actual status of the add-on). I'm going to download the latest version you provided in order to integrate the code in my master and provide an official release in the first post. 

May be we can have a private exchange so that you can point me out your modifications to the code. Thanks a lot for your collaboration...I think that the add-on is really starting to be a great and powerful tool thanks to all the users and your really active effort! 

I agree, Dziobak should have exchanged info with axlt all in all what matters the most is moving the addon forward.
I have 5000 movies and 700 tv shows, gonna test the 3.1.0 version.
Yesterday, as I mentioned, the tv show Casual was still being scanned even after the addon finished upgrading. But I cannot find anything in the log.

(2017-10-20, 23:29)dziobak Wrote: [ -> ](...)
 
@djhihi
try above version first, maybe speed will be ok for full scanning;
if not, better idea is skipping old (or watched) entries than implement resume (for few reasons)

Gonna re-scan my tv shows again using 3.1.0 and going to turn debug log on. But "Casual" was still being scanned even after the addon succefully finished scanning. And "Casual" is ok in EMBY + KODI libraries. Wierd.

PS: "Obtain IMDB id from thetvdb" If turned on does this make the scanning even faster if I have an API key?


EDIT:

Scanning for TV Shows (Includes votes on, episodes off) is currently running OK and by the looks of it, its going to take under 30min for the whole 700 TV Shows I have, which is great!
Altough maybe because the ratins are already updated from yesterday's run?
You can see some shows reporting "no update" maybe because already updated?

For instance: "Anno 1790": Update finished (no update)

Here is some debug log already to prove:

18:21:04.878 T:140660439267072   DEBUG: CPythonInvoker(25, /storage/.kodi/addons/script.light.imdb.ratings.update/main.py): start processing
18:21:04.883 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:04.885 T:140662032811776   DEBUG: CAddonDatabase::SetLastUsed[script.light.imdb.ratings.update] took 8 ms
18:21:04.896 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:04.925 T:140660439267072   DEBUG: Previous line repeats 1 times.
18:21:04.925 T:140660439267072   DEBUG: -->Python Interpreter Initialized<--
18:21:04.925 T:140660439267072   DEBUG: CPythonInvoker(25, /storage/.kodi/addons/script.light.imdb.ratings.update/main.py): the source file to load is "/storage/.kodi/addons/script.light.imdb.ratings.update/main.py"
18:21:04.926 T:140660439267072   DEBUG: CPythonInvoker(25, /storage/.kodi/addons/script.light.imdb.ratings.update/main.py): setting the Python path to /storage/.kodi/addons/script.light.imdb.ratings.update:/storage/.kodi/addons/script.module.myconnpy/lib:/storage/.kodi/addons/script.module.requests/lib:/storage/.kodi/addons/script.module.simplejson/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages:/usr/lib/python2.7/site-packages/gtk-2.0
18:21:04.926 T:140660439267072   DEBUG: CPythonInvoker(25, /storage/.kodi/addons/script.light.imdb.ratings.update/main.py): entering source directory /storage/.kodi/addons/script.light.imdb.ratings.update
18:21:04.927 T:140660439267072   DEBUG: CPythonInvoker(25, /storage/.kodi/addons/script.light.imdb.ratings.update/main.py): instantiating addon using automatically obtained id of "script.light.imdb.ratings.update" dependent on version 2.25.0 of the xbmc.python api
18:21:04.930 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:09.974 T:140663282894528   DEBUG: Previous line repeats 300 times.

(...)

18:21:16.341 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Animal Kingdom (2016)": Update started (IMDb ID: tt5574490, TVDB ID: tt5574490)
18:21:16.346 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:17.341 T:140660439267072   DEBUG: Previous line repeats 59 times.
18:21:17.341 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Anno 1790": Update started (IMDb ID: tt2078818, TVDB ID: tt2078818)
18:21:17.344 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:17.566 T:140660461872896   DEBUG: Previous line repeats 13 times.
18:21:17.566 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 8.1, votes: 10,229, top250: 0
18:21:17.566 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 8.1, votes: 10,223, top250: None
18:21:17.566 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetTVShowDetails","params":{"tvshowid":1,"rating":8.1,"votes":"10,229","uniqueid": {"imdb": "tt5574490","tvdb": "tt5574490"}},"id":1}
18:21:17.576 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:18.171 T:140660461872896   DEBUG: Previous line repeats 35 times.
18:21:18.171 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:21:18.171 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - "Animal Kingdom (2016)": Update finished (rating: 8.1, votes: 10,229, top250: None)
18:21:18.176 T:140663282894528   DEBUG: CGUIMediaWindow::GetDirectory (addons://sources/executable)
18:21:18.176 T:140663282894528   DEBUG:   ParentPath = [addons://sources/executable/]
18:21:18.197 T:140660461872896   DEBUG: Thread BackgroundLoader start, auto delete: false
18:21:18.201 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:18.206 T:140660461872896   DEBUG: Thread BackgroundLoader 140660461872896 terminating
18:21:18.213 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:18.342 T:140660439267072   DEBUG: Previous line repeats 7 times.
18:21:18.342 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Any Human Heart": Update started (IMDb ID: tt1631891, TVDB ID: tt1631891)
18:21:18.343 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:18.879 T:140660414088960   DEBUG: Previous line repeats 32 times.
18:21:18.879 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 7.7, votes: 466, top250: 0
18:21:18.879 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 7.7, votes: 466, top250: None
18:21:18.879 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - "Anno 1790": Update finished (no update)
18:21:18.893 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:19.343 T:140660439267072   DEBUG: Previous line repeats 26 times.
18:21:19.343 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "ANZAC Girls": Update started (IMDb ID: tt3078602, TVDB ID: tt3078602)
18:21:19.343 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:19.807 T:140660461872896   DEBUG: Previous line repeats 27 times.
18:21:19.807 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 8.0, votes: 1,759, top250: 0
18:21:19.807 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 8.0, votes: 1,759, top250: None
18:21:19.807 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - "Any Human Heart": Update finished (no update)
18:21:19.809 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:20.343 T:140660439267072   DEBUG: Previous line repeats 32 times.
18:21:20.344 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Apocalypse: The Rise of Hitler": Update started (IMDb ID: tt2094220, TVDB ID: tt2094220)
18:21:20.359 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:20.772 T:140660414088960   DEBUG: Previous line repeats 24 times.
18:21:20.772 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 8.0, votes: 805, top250: 0
18:21:20.772 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 8.0, votes: 805, top250: None
18:21:20.772 T:140660414088960   DEBUG: [Light IMDb Ratings Update] - "ANZAC Girls": Update finished (no update)
18:21:20.777 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:21.344 T:140660439267072   DEBUG: Previous line repeats 34 times.
18:21:21.345 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Apocalypse: The Second World War": Update started (IMDb ID: tt1508238, TVDB ID: tt1508238)
18:21:21.362 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:21:22.150 T:140660461872896   DEBUG: Previous line repeats 47 times.

(...)

18:27:17.707 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Luck": Update started (IMDb ID: tt1578887, TVDB ID: tt1578887)
18:27:17.713 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:17.884 T:140660470265600   DEBUG: Previous line repeats 10 times.
18:27:17.884 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 7.6, votes: 24, top250: 0
18:27:17.884 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 7.6, votes: 24, top250: None
18:27:17.884 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - "Journeys into the Ring of Fire": Update finished (no update)
18:27:17.896 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:18.710 T:140660439267072   DEBUG: Previous line repeats 48 times.
18:27:18.710 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Luther": Update started (IMDb ID: tt1474684, TVDB ID: tt1474684)
18:27:18.713 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:19.234 T:140660461872896   DEBUG: Previous line repeats 31 times.
18:27:19.234 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 7.6, votes: 4,839, top250: 0
18:27:19.235 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 7.6, votes: 4,838, top250: None
18:27:19.235 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetTVShowDetails","params":{"tvshowid":376,"rating":7.6,"votes":"4,839","uniqueid": {"imdb": "tt1578887","tvdb": "tt1578887"}},"id":1}
18:27:19.248 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:19.692 T:140660470265600   DEBUG: Previous line repeats 26 times.
18:27:19.692 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 8.6, votes: 84,396, top250: 0
18:27:19.693 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 8.6, votes: 84,374, top250: None
18:27:19.695 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetTVShowDetails","params":{"tvshowid":377,"rating":8.6,"votes":"84,396","uniqueid": {"imdb": "tt1474684","tvdb": "tt1474684"}},"id":1}
18:27:19.699 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:19.718 T:140660439267072   DEBUG: Previous line repeats 1 times.
18:27:19.718 T:140660439267072   DEBUG: [Light IMDb Ratings Update] - "Mad Men": Update started (IMDb ID: tt0804503, TVDB ID: tt0804503)
18:27:19.730 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:20.056 T:140660461872896   DEBUG: Previous line repeats 19 times.
18:27:20.056 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:27:20.056 T:140660461872896   DEBUG: [Light IMDb Ratings Update] - "Luck": Update finished (rating: 7.6, votes: 4,839, top250: None)
18:27:20.061 T:140663282894528   DEBUG: CGUIMediaWindow::GetDirectory (addons://sources/executable)
18:27:20.061 T:140663282894528   DEBUG:   ParentPath = [addons://sources/executable]
18:27:20.080 T:140660461872896   DEBUG: Thread BackgroundLoader start, auto delete: false
18:27:20.087 T:140660461872896   DEBUG: Thread BackgroundLoader 140660461872896 terminating
18:27:20.087 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:20.498 T:140660470265600   DEBUG: Previous line repeats 26 times.
18:27:20.498 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:27:20.498 T:140660470265600   DEBUG: [Light IMDb Ratings Update] - "Luther": Update finished (rating: 8.6, votes: 84,396, top250: None)
18:27:20.510 T:140663282894528   DEBUG: CGUIMediaWindow::GetDirectory (addons://sources/executable)
18:27:20.511 T:140663282894528   DEBUG:   ParentPath = [addons://sources/executable]
18:27:20.529 T:140660470265600   DEBUG: Thread BackgroundLoader start, auto delete: false
18:27:20.533 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.
18:27:20.535 T:140660470265600   DEBUG: Thread BackgroundLoader 140660470265600 terminating
18:27:20.546 T:140663282894528   DEBUG: CSettingsManager: requested setting (pvrmanager.enabled) was not found.


----

CSettingsManager: requested setting (pvrmanager.enabled) was not found. -----> This is not related to the addon, right?

Debug log for movies:

18:37:11.472 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:37:11.472 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - "127 Hours": Update finished (rating: 7.6, votes: 300,184, top250: 0)
18:37:11.723 T:140660487137024   DEBUG: [Light IMDb Ratings Update] - "360": Update started (IMDb ID: tt1680045, TVDB ID: None)
18:37:11.724 T:140660487137024   DEBUG: [Light IMDb Ratings Update] - "400 Days": Update started (IMDb ID: tt3774790, TVDB ID: None)
18:37:11.792 T:140662485788416   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 6.7, votes: 5,854, top250: 0
18:37:11.793 T:140662485788416   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 0.0, votes: 0, top250: 0
18:37:11.793 T:140662485788416   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetMovieDetails","params":{"movieid":120,"rating":6.7,"votes":"5,854","top250":0},"id":1}
18:37:11.812 T:140662485788416   DEBUG: UpdateDetailsForMovie: Starting updates for movie 120
18:37:11.824 T:140662485788416   DEBUG: UpdateDetailsForMovie: Finished updates for movie 120
18:37:11.829 T:140662485788416   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:37:11.830 T:140662485788416   DEBUG: [Light IMDb Ratings Update] - "The 300 Spartans": Update finished (rating: 6.7, votes: 5,854, top250: 0)
18:37:12.227 T:140660487137024   DEBUG: [Light IMDb Ratings Update] - "600 Miles": Update started (IMDb ID: tt3685622, TVDB ID: None)
18:37:12.670 T:140660740957952   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 6.2, votes: 243,556, top250: 0
18:37:12.671 T:140660740957952   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 0.0, votes: 0, top250: 0
18:37:12.671 T:140660740957952   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetMovieDetails","params":{"movieid":121,"rating":6.2,"votes":"243,556","top250":0},"id":1}
18:37:12.689 T:140660740957952   DEBUG: UpdateDetailsForMovie: Starting updates for movie 121
18:37:12.699 T:140660740957952   DEBUG: UpdateDetailsForMovie: Finished updates for movie 121
18:37:12.705 T:140660740957952   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:37:12.705 T:140660740957952   DEBUG: [Light IMDb Ratings Update] - "300: Rise of an Empire": Update finished (rating: 6.2, votes: 243,556, top250: 0)
18:37:12.728 T:140660487137024   DEBUG: [Light IMDb Ratings Update] - "1408": Update started (IMDb ID: tt0450385, TVDB ID: None)
18:37:12.932 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - Scraped data: rating: 6.2, votes: 14,152, top250: 0
18:37:12.933 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - Current data: rating: 0.0, votes: 0, top250: 0
18:37:12.933 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - JSON Query: {"jsonrpc":"2.0","method":"VideoLibrary.SetMovieDetails","params":{"movieid":122,"rating":6.2,"votes":"14,152","top250":0},"id":1}
18:37:12.951 T:140660466484992   DEBUG: UpdateDetailsForMovie: Starting updates for movie 122
18:37:12.964 T:140660466484992   DEBUG: UpdateDetailsForMovie: Finished updates for movie 122
18:37:12.969 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - JSON Response: {"id":1,"jsonrpc":"2.0","result":"OK"}
18:37:12.969 T:140660466484992   DEBUG: [Light IMDb Ratings Update] - "360": Update finished (rating: 6.2, votes: 14,152, top250: 0)

So, I think everything is going ok and faster than ever!

BUT:

"- changed behavior when errors on IMDb connection (try few times then return None -> skip problematic entry instead of doing infinite loop)" ---> Maybe add a report when the addon finishes? To see which entires are problematic and fix errors?

About 3.1.0 - that was set of fixes and changes made by me to 3.0.0, to using for me mainly, because scraping of my whole library by 3.0.0 took over 10h.
After made 3.1.0 I had two options: keep this private or put on this forum for other users also. So I chose second.
I sent description of changes and fixes to Axlt, but don't demand of inclusion of these to main code if Axlt has other plans for add-on development.

(2017-10-21, 19:14)djhifi Wrote: [ -> ]But "Casual" was still being scanned even after the addon succefully finished scanning.

This is weird. On end on loop by library is called xbmcgui.DialogProgressBG().close, that remove info from upper right corner.

(2017-10-21, 19:14)djhifi Wrote: [ -> ]BUT:

"- changed behavior when errors on IMDb connection (try few times then return None -> skip problematic entry instead of doing infinite loop)" ---> Maybe add a report when the addon finishes? To see which entires are problematic and fix errors?

Good idea, I used YAMJ few years ago, that write special file with problematic entries of library. Add-on could write a file in Kodi temp directory (when no IMDB_ID, page not found on IMDB connection and so on).

(2017-10-21, 19:58)dziobak Wrote: [ -> ]About 3.1.0 - that was set of fixes and changes made by me to 3.0.0, to using for me mainly, because scraping of my whole library by 3.0.0 took over 10h.
After made 3.1.0 I had two options: keep this private or put on this forum for other users also. So I chose second.
I sent description of changes and fixes to Axlt, but don't demand of inclusion of these to main code if Axlt has other plans for add-on development.

(2017-10-21, 19:14)djhifi Wrote: [ -> ]But "Casual" was still being scanned even after the addon succefully finished scanning.

This is weird. On end on loop by library is called xbmcgui.DialogProgressBG().close, that remove info from upper right corner.

This is no longer happening ("Casual" on a loop).

Regarding the changes Im happy you shared because my library is bigger than yours so imagine my time to completion... Regarding what I replied on the previous post in bold, that is normal right?

(2017-10-21, 19:58)dziobak Wrote: [ -> ]About 3.1.0 - that was set of fixes and changes made by me to 3.0.0, to using for me mainly, because scraping of my whole library by 3.0.0 took over 10h.
After made 3.1.0 I had two options: keep this private or put on this forum for other users also. So I chose second.
I sent description of changes and fixes to Axlt, but don't demand of inclusion of these to main code if Axlt has other plans for add-on development.

Of course I will! Your changes really improved the add-on, so why not? I'm going to merge the code this evening, so for the time being I just ask you to put in pause any additional change. 

Once I will release the official 3.1.0, I guess we can start to work on the remaining open points (if any).

(2017-10-21, 19:14)djhifi Wrote: [ -> ]Regarding the changes Im happy you shared because my library is bigger than yours so imagine my time to completion... Regarding what I replied on the previous post in bold, that is normal right?

This is not from add-on.

(2017-10-21, 20:28)axlt2002 Wrote: [ -> ]Once I will release the official 3.1.0, I guess we can start to work on the remaining open points (if any).

Good!
In my point of view:
- intergate TheTVDB key in code (no sense for every user to register individual key for that same prog, I dont see that in others scraping programs), and in place of put settings of max threads to config (for individual testing depending of hardware and Internet bandwidth). I bet, that 8 threads gives gain of 50% time on library scraping
- order in logs and write status file with every problem found when library scraping (actually there is very hard read something usefull from tons of logs)

(2017-10-21, 20:40)dziobak Wrote: [ -> ]

(2017-10-21, 20:28)axlt2002 Wrote: [ -> ]Once I will release the official 3.1.0, I guess we can start to work on the remaining open points (if any).

Good!
In my point of view:
- intergate TheTVDB key in code (no sense for every user to register individual key for that same prog, I dont see that in others scraping programs), and in place of put settings of max threads to config (for individual testing depending of hardware and Internet bandwidth). I bet, that 8 threads gives gain of 50% time on library scraping
- order in logs and write status file with every problem found when library scraping (actually there is very hard read something usefull from tons of logs)

Funny, I have just replied privatly to you drafting a "to do" list that is covering parts of the points you reported here.

I will try to release the 3.1.0 including already such points by tomorrow evening (hopefully).

Have a great Saturday night!

(2017-10-21, 19:58)dziobak Wrote: [ -> ]

(2017-10-21, 19:14)djhifi Wrote: [ -> ]BUT:

"- changed behavior when errors on IMDb connection (try few times then return None -> skip problematic entry instead of doing infinite loop)" ---> Maybe add a report when the addon finishes? To see which entires are problematic and fix errors?

Good idea, I used YAMJ few years ago, that write special file with problematic entries of library. Add-on could write a file in Kodi temp directory (when no IMDB_ID, page not found on IMDB connection and so on).

What do you think of this axlt?


EDIT:
axlt, the 3.1.0 version in the 1st has any changes compared to the latest by dziobak? aka script.light.imdb.ratings.update-3.1.0_fixes_5 ?

Hi guys,

New release 3.1.0 is now available for download. It just adopts all the modifications proposed by dziobak; I thought that it would have been good to give the right visibility to his work and the incredible performance enhancements achieved!

I'm going to work on version 3.2.0 tomorrow, that will include some modifications according to the open points discussed in the previous posts.

Cheers,

Alex

This thread should be "sticky" and this addon should come in the official KODI repository. Its mandatory for every movie / shows lover.

I have to confirm, as an EMBY user, if the ratings are getting "deleted" everytime I add anything new to the collection

This looks awesome - I gave up trying to get the php version working on OSMC, but now this is in python, I am going to try again

having a problem downloading though - is there a problem with the link?

EDIT: Don't worry, sorted it (link on first page is still broken though!)

(2017-10-23, 11:38)tmacca Wrote: [ -> ]This looks awesome - I gave up trying to get the php version working on OSMC, but now this is in python, I am going to try again

having a problem downloading though - is there a problem with the link?

EDIT: Don't worry, sorted it (link on first page is still broken though!)

Thanks for highlighting that! Now the link should be fixed...can you please just give it a try?

Have a nice day!