yep, link working again
And I finally have a working IMDB updater!
Thanks for all your hard work on this guys
Happy to read that!
We are going to release a new version this evening with some improvements but I think that 3.0.0/3.1.0 really traced the turning point!
Thank you for all the work that you do for this add-on. This is a great add-on and worked perfectly for what I needed. For some reason today it started giving me an error. I'm using 3.1.0 and here is the log:
09:44:20.817 T:19172 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.IndentationError'>
Error Contents: ('unindent does not match any outer indentation level', ('C:\\Users\\Owner\\AppData\\Roaming\\Kodi\\addons\\script.light.imdb.ratings.update\\resources\\core\\imdb_scraper.py', 50, 24, ' if do_loop == 10:\n'))
Traceback (most recent call last):
File "C:\Users\Owner\AppData\Roaming\Kodi\addons\script.light.imdb.ratings.update\main.py", line 9, in <module>
from resources.core import update_main
File "C:\Users\Owner\AppData\Roaming\Kodi\addons\script.light.imdb.ratings.update\resources\core\update_main.py", line 15, in <module>
from imdb_scraper import parse_IMDb_page
IndentationError: ('unindent does not match any outer indentation level', ('C:\\Users\\Owner\\AppData\\Roaming\\Kodi\\addons\\script.light.imdb.ratings.update\\resources\\core\\imdb_scraper.py', 50, 24, ' if do_loop == 10:\n'))
-->End of Python script error report<--
I'm not sure why it started today. I've changed nothing and it worked perfectly a couple days ago. Any help would be greatly appreciated. Thanks.
@duke81, please reinstall add-on from link on the first page.
Python is very sensitive for identations, I don't know why the add-on stop working for you. Is it possible that you have modified addon's files?
Thanks for the quick reply. Reinstalling did work. I hadn't modified any of the files, so not sure what could have happened.
But is "resume" to hard to implement via python? Maxim addon had it.
(2017-10-29, 00:58)djhifi Wrote: [ -> ]But is "resume" to hard to implement via python? Maxim addon had it.
Point is when "resume" and from what entry in database.
Current add-on work as mutithreaded, that means we don't know what is the order of entry scraping (depends on the reponse from IMDB). Actual Kodi database does not provide info, when last scraping was successful for every entry. So I don't have a good idea how to implement resume now, which did not not slowdown addon because of mass file operations.
And second, for what? Add-on is very fast now. Background operation can't be stopped in normal working way. And for scraping of few positions better is starting add-on from context menu.
In 3.2.0 is implemented skipping of watched entry (in config option) - and this is good direction of add-on developing, to scan only useful entries (this is fast and does not load IMDB site).
I can see if movie db is being updated, but no visual on tvshows. Is that something you can add?
How about just updating top250?
(2017-10-29, 14:05)Edworld Wrote: [ -> ]I can see if movie db is being updated, but no visual on tvshows. Is that something you can add?
How about just updating top250?
Are you sure that tvshows update is turn on (via config options)?
(2017-10-29, 02:45)dziobak Wrote: [ -> ] (2017-10-29, 00:58)djhifi Wrote: [ -> ]But is "resume" to hard to implement via python? Maxim addon had it.
Point is when "resume" and from what entry in database.
Current add-on work as mutithreaded, that means we don't know what is the order of entry scraping (depends on the reponse from IMDB). Actual Kodi database does not provide info, when last scraping was successful for every entry. So I don't have a good idea how to implement resume now, which did not not slowdown addon because of mass file operations.
And second, for what? Add-on is very fast now. Background operation can't be stopped in normal working way. And for scraping of few positions better is starting add-on from context menu.
In 3.2.0 is implemented skipping of watched entry (in config option) - and this is good direction of add-on developing, to scan only useful entries (this is fast and does not load IMDB site).
I am aware of the multi threading thats why I asked if it was too much complicated. Because I know the pickup point is hard to configure in the code. If you say its even faster (v3.2.0) I believe in you. The resume was necessary if the addon was slow, because sometimes I only turn on my KODIs to watch 1 or 2 episodes and previously it was not enough time to scan everything. With the current version it takes +/- from 50 to 1h20min to do the entire scan (with everything ON both in movies and TV shows, votes included). My collection is +/- 6900 movies and +/- 700 shows.
If even faster in 3.2.0 maybe 40 minutes for everything? That would be great and I could finally use the "schedule"
Hi guys,
The new version 3.2.0 of Light IMDb Ratings Update has just been released! The changelog is the following:
v3.2.0 (2017-10-29)
- Removed the need of a personal API key for TheTVDB.com
- Added option to exclude watched Movies/TV Shows/Episodes from the update
- Added option to set the number of threads
- Added log file to report Movies/TV Shows/Episodes having issues
- Revised debug log and update progress messages for TV Shows
As usual, you can find the download link in the first post of this thread and (please!) read also the description for the details on the various features of the add-on.
Have a great night!
axlt2002 and dziobak
(2017-10-30, 00:43)axlt2002 Wrote: [ -> ]Hi guys,
The new version 3.2.0 of Light IMDb Ratings Update has just been released! The changelog is the following:
v3.2.0 (2017-10-29)- Removed the need of a personal API key for TheTVDB.com
- Added option to exclude watched Movies/TV Shows/Episodes from the update
- Added option to set the number of threads
- Added log file to report Movies/TV Shows/Episodes having issues
- Revised debug log and update progress messages for TV Shows
As usual, you can find the download link in the first post of this thread and (please!) read also the description for the details on the various features of the add-on.
Have a great night!
axlt2002 and dziobak
Thanks for the update
(2017-10-30, 00:43)axlt2002 Wrote: [ -> ]Hi guys,
The new version 3.2.0 of Light IMDb Ratings Update has just been released! The changelog is the following:
v3.2.0 (2017-10-29)- Removed the need of a personal API key for TheTVDB.com
- Added option to exclude watched Movies/TV Shows/Episodes from the update
- Added option to set the number of threads
- Added log file to report Movies/TV Shows/Episodes having issues
- Revised debug log and update progress messages for TV Shows
As usual, you can find the download link in the first post of this thread and (please!) read also the description for the details on the various features of the add-on.
Have a great night!
axlt2002 and dziobak
Great news!!! Im testing. So far 8 threads does not push my CPU that much. Can I rise it?
Other thing, I think the speed has not improved to 2x faster. (I GUESS). Because TV Shows now is showing individual episode rating update.
PS: The log file report goes where? No UI right?
EDIT: I think I found the answer to the PS: "update.log"
Quck suggestion, for instance:
"American Crime 1x01: get_IMDb_ID: TVDB 4962649 (episode) -> missing IMDb ID
American Crime 1x02: get_IMDb_ID: TVDB 5114681 (episode) -> missing IMDb ID"
But all other episodes and seasons scan OK.
Would it slow the addon, adding the ability to auto retrieve the imdb id for the specific episode? So far its only relying in "thetvdb" so far as I see?
