(2017-11-02, 17:33)dziobak Wrote: [ -> ] (2017-11-02, 17:01)Glottis Wrote: [ -> ] (2017-11-02, 16:43)dziobak Wrote: [ -> ]Do you have stable Internet connection?
The connection should definitely be stable. It's all wired and 400 MBit/s via cable. I guess TheTVDB temporarily blocks my IP address after that many requests, but I've got no proof.
I sent you next fix for that.
If this is problem with temporary block of TVDb, then you are first person with this. Second - in that case it should be something like socket timeout or HTTP reject, but error is "no route to host".
Try simple thing: ping -t thetvdb.com
Your post made me think and I might have found the problem. It's not the Internet connection. It's my DNS server.
In Libreelec I changed it to 8.8.8.8 and the ratings update process doesn't get stuck anymore (over 25% right now. with my home router as DNS server it never reached 10%)
Still using patch1 at the moment. I will change the dns server settings back and test patch2 after the update finishes.
PS: You're right about thetvdb.com
not blocking my IP address.
(2017-11-02, 19:46)Glottis Wrote: [ -> ] (2017-11-02, 17:33)dziobak Wrote: [ -> ] (2017-11-02, 17:01)Glottis Wrote: [ -> ]The connection should definitely be stable. It's all wired and 400 MBit/s via cable. I guess TheTVDB temporarily blocks my IP address after that many requests, but I've got no proof.
I sent you next fix for that.
If this is problem with temporary block of TVDb, then you are first person with this. Second - in that case it should be something like socket timeout or HTTP reject, but error is "no route to host".
Try simple thing: ping -t thetvdb.com
Your post made me think and I might have found the problem. It's not the Internet connection. It's my DNS server.
In Libreelec I changed it to 8.8.8.8 and the ratings update process doesn't get stuck anymore (over 25% right now. with my home router as DNS server it never reached 10%)
Still using patch1 at the moment. I will change the dns server settings back and test patch2 after the update finishes.
PS: You're right about thetvdb.com not blocking my IP address.
Thanks Glottis for further progress on the tests!
@dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
(2017-11-03, 11:54)axlt2002 Wrote: [ -> ]@dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
Modifications are ok, with a similar situation add-on will work to end without crashes (but in that case doing nothing without connection to TVDb and/or IMDb).
(2017-11-03, 11:54)axlt2002 Wrote: [ -> ]@dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
If you'd ask me, the patches are welcome because they stop the add-on from freezing. It can't be wrong to handle an exception even though the add-on code does not cause that error. In my case I could check the logs after the progress finishes and trace back the problems, but I'm not forced to restart Kodi every time I use the add-on. That's why I say keep the patches if they don't introduce any drawbacks.
---
Here are two new things. The first one isn't a bug but more of a feature request:
1) I've got a lot of the older The Simpsons episodes (Season 1 - 6 for example). The seasons are locked at thetvdb.com and do not feature IMDB IDs. Would it make sense to search for
original title on IMDB and on >95% match get that IMDB ID and save it?
2) I use thetvdb for most of my tv series, but some (especially documentary series) get their information from themoviedb. (example:
https://www.themoviedb.org/tv/1044-plane...uage=en-US)
As soon as the add-on reaches aforementioned episodes I get 8 of the following errors and it freezes. (one error for each thread I think)
Code:
03:04:59.680 T:544823046368 ERROR: Unhandled exception in thread started by
03:04:59.680 T:544823046368 ERROR: <function thread_parse_IMDb_page at 0x7ef8156b90>
03:04:59.680 T:544823046368 ERROR: Traceback (most recent call last):
03:04:59.680 T:544823046368 ERROR: File "/storage/.kodi/addons/script.light.imdb.ratings.update/resources/core/update_main.py", line 43, in thread_parse_IMDb_page
03:04:59.680 T:544823046368 ERROR: statusLog( Title + ": " + statusInfo )
03:04:59.680 T:544823046368 ERROR: TypeError
03:04:59.681 T:544823046368 ERROR: :
03:04:59.681 T:544823046368 ERROR: coercing to Unicode: need string or buffer, NoneType found
(2017-11-03, 13:37)dziobak Wrote: [ -> ] (2017-11-03, 11:54)axlt2002 Wrote: [ -> ]@dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
Modifications are ok, with a similar situation add-on will work to end without crashes (but in that case doing nothing without connection to TVDb and/or IMDb).
Yes, I agree. Going to be included in 3.3.0 then.
(2017-11-03, 13:47)Glottis Wrote: [ -> ] (2017-11-03, 11:54)axlt2002 Wrote: [ -> ]@dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
If you'd ask me, the patches are welcome because they stop the add-on from freezing. It can't be wrong to handle an exception even though the add-on code does not cause that error. In my case I could check the logs after the progress finishes and trace back the problems, but I'm not forced to restart Kodi every time I use the add-on. That's why I say keep the patches if they don't introduce any drawbacks.
---
Here are two new things. The first one isn't a bug but more of a feature request:
1) I've got a lot of the older The Simpsons episodes (Season 1 - 6 for example). The seasons are locked at thetvdb.com and do not feature IMDB IDs. Would it make sense to search for original title on IMDB and on >95% match get that IMDB ID and save it?
2) I use thetvdb for most of my tv series, but some (especially documentary series) get their information from themoviedb. (example: https://www.themoviedb.org/tv/1044-plane...uage=en-US)
As soon as the add-on reaches aforementioned episodes I get 8 of the following errors and it freezes. (one error for each thread I think)
Code:
03:04:59.680 T:544823046368 ERROR: Unhandled exception in thread started by
03:04:59.680 T:544823046368 ERROR: <function thread_parse_IMDb_page at 0x7ef8156b90>
03:04:59.680 T:544823046368 ERROR: Traceback (most recent call last):
03:04:59.680 T:544823046368 ERROR: File "/storage/.kodi/addons/script.light.imdb.ratings.update/resources/core/update_main.py", line 43, in thread_parse_IMDb_page
03:04:59.680 T:544823046368 ERROR: statusLog( Title + ": " + statusInfo )
03:04:59.680 T:544823046368 ERROR: TypeError
03:04:59.681 T:544823046368 ERROR: :
03:04:59.681 T:544823046368 ERROR: coercing to Unicode: need string or buffer, NoneType found
Quick answer to 1): In the upcoming 3.3.0 release it will be possible to set the missing IMDb/TVDB IDs through the context menus. I'm not so much in favour to add the search by "original title" (it would just add new level of possible errors, not all the users may have the "original title" info, it should match exactly the original title on IMDb site, it will prompt the user to confirm the match and I prefer a more transpartent behaviour of the add-on, etc.)
For 2)...we have to look into it.
Alex
@
Glottis,
I sent you next patch. Can you give IDs (title, TVDb ID) of this problematic episode/tvshow?
Do you set nfo file for this tvshow? If yes, drop that file here.
(2017-11-03, 15:51)dziobak Wrote: [ -> ]@Glottis,
I sent you next patch. Can you give IDs (title, TVDb ID) of this problematic episode/tvshow?
Do you set nfo file for this tvshow? If yes, drop that file here.
Will try that now. (It's gonna need some time to get to the problematic point.)
I'm not using nfo files or anything exotic. Every Kodi installation gives you the TVDB scraper and the moviedb scraper for tv shows. I'm using the moviedb scraper for only a few shows and TVDB for the others.
I just found a series in theMovieDB which did not feature a TheTVDB ID. Can this lead to errors? (The title is "Wildes Skandinavien", but I added the TVDB ID now.)
(2017-11-03, 18:10)Glottis Wrote: [ -> ]I just found a series in theMovieDB which did not feature a TheTVDB ID. Can this lead to errors? (The title is "Wildes Skandinavien", but I added the TVDB ID now.)
No, I'm thinking about adding funcionality that will find IMDb_ID from TMDB_ID
(2017-11-03, 19:59)dziobak Wrote: [ -> ] (2017-11-03, 18:10)Glottis Wrote: [ -> ]I just found a series in theMovieDB which did not feature a TheTVDB ID. Can this lead to errors? (The title is "Wildes Skandinavien", but I added the TVDB ID now.)
No, I'm thinking about adding funcionality that will find IMDb_ID from TMDB_ID
Good news, everyone! Today the add-on finished it's scan for the first time ever on my system. Special thanks to dziobak for patch3.
Just to make sure I get this right: "
I'm thinking about adding functionality that will find IMDb_ID from TMDB_ID" means it will find it if it's there or does it mean that it will somehow determine which IMDB ID corresponds to the title by itself?
(2017-11-03, 21:50)Glottis Wrote: [ -> ]Just to make sure I get this right: "I'm thinking about adding functionality that will find IMDb_ID from TMDB_ID" means it will find it if it's there or does it mean that it will somehow determine which IMDB ID corresponds to the title by itself?
You have few tv series scraped by TheMovieDB add-on, right? In that case, has tvshow/episode the IMDB ID besides TMDB ID? Or, simply, does our add-on update tvshow/episode or put in update.log some info about problems?
If there is lack of IMDB ID, add-on could look for this ID based on TMDB ID (like does in current version when search IMDB ID from TVDB ID).
Alex,
Were you able to download the file I sent you?
(2017-11-04, 00:45)dziobak Wrote: [ -> ]You have few tv series scraped by TheMovieDB add-on, right? In that case, has tvshow/episode the IMDB ID besides TMDB ID? Or, simply, does our add-on update tvshow/episode or put in update.log some info about problems?
If there is lack of IMDB ID, add-on could look for this ID based on TMDB ID (like does in current version when search IMDB ID from TVDB ID).
I found no problems in update.log
seems to run fine with TMDB items. Thanks a lot and have a great day everyone.
Hello World!
A new version of Light IMDb Ratings Udpate has just been released. The changelog is the following:
v3.3.0 (2017-11-05)
- Added IMDb ID and TVDB ID edit options in context menu
- Added option to enable log file
- Added backup of previous log file
- Extended log file for the updates through context menu
- Revised some debug log and update progress messages
- Revised Episodes update through context menu of TV Show
- Fixed IMDb/TheTVDB.com sites access errors
- Fixed bug for Season update through context menu
Enjoy!
axlt2002 and dziobak
(2017-11-04, 01:08)Edworld Wrote: [ -> ]Alex,
Were you able to download the file I sent you?
Hi Edworld!
Yes, I downloaded the file, thanks!
Anyway, I want just to inform you that, for the time being, we have decided not to implement
the visualization of the last time the database has been updated.
Hope you will enjoy anyway the new version 3.3.0. 