(2019-02-12, 03:25)Adriano de Brito Wrote: [ -> ]Hello @axlt2002,
Thanks again for the great add-on. I updated to your most recent version 4.0.0 and ran it just now.
- In regards to movies, it updated them very fast. A total of 370 movies done in 1 minute and 7 seconds.
- In regards to TV Shows, it was pretty slow. Your previous version took about 40 minutes long. This one took 1h39. This was for a total on 152 TV Shows, 560 Seasons, 8,141 episodes.
Previous issue: I am happy to report that the issue i had previously is now corrected, where episodes didn't get the correct rating because they were missing IMDb id numbers on TheTVDB. It indeed updated "The Incredible Hulk", "The 4400" and "Battlestar Galactica" with the correct IMDb ratings.
New issue: Certain special episodes didn't get the correct rating, such as the "Battlestar Galactica: mini series", episodes 0x01 and 0x02. Some TV Shows that are in DVD order, such as "Firefly" didn't get the rating according to episode number but rather according to episode-order on IMDb.
I read some of the previous posts, including Karellen, and i know you're on top of the issues.
Thanks again for such a nice tweak! It would be awesome if it worked faster (maybe it's the first run...), otherwise, great work buddy ;-)
Thanks for further investigating on your side as well Adriano...please see my previous post about the open issues related to last version 4.0.0.
Anyway, one thing I'm sure about, is that 4.0.0 is definitely more efficient in terms of time with respect to 3.5.1. So you have for sure missed something in order to make a fair comparison between the two versions.
I think that the add-on can be considered anyway a great work, at least in terms of passion that I put using my spare time for its development and sharing it with the community...
Take care.
(2019-02-11, 10:00)axlt2002 Wrote: [ -> ] (2019-02-10, 15:39)daanwillems Wrote: [ -> ]Thanks for the great work!
Is it possible to write out a text file with the missing top250 movies after a scrape, just like the (now defunct) imdb rating update script did?
Since KODI Leia, no imdb addon seems to provide this feature.
Hi daanwilliems and thanks for writing!
You mean you would like to have a text file that you can consult afterwards or directly inside Kodi? I know that such feature was in the add-on you mentioned but, to be honest, I didn't want to introduce it since it was really difficult to me to understand the usefulness of that...
Let me know.
A text file in userdata or something like that would be great. (The other addon write it to the desktop on a Windows installation if I remember correct.) It's just a very easy way of finding out which imdb top250 movies are missing in your library. Since I use mySQL as a central database I know it's also possibe to run some queries to find this out, but it is so much easier to have an addon just do that.
And while the addon is scraping and updating the rankings anyway it's probably easy to produce this list on the go.
(2019-02-14, 14:57)daanwillems Wrote: [ -> ] (2019-02-11, 10:00)axlt2002 Wrote: [ -> ] (2019-02-10, 15:39)daanwillems Wrote: [ -> ]Thanks for the great work!
Is it possible to write out a text file with the missing top250 movies after a scrape, just like the (now defunct) imdb rating update script did?
Since KODI Leia, no imdb addon seems to provide this feature.
Hi daanwilliems and thanks for writing!
You mean you would like to have a text file that you can consult afterwards or directly inside Kodi? I know that such feature was in the add-on you mentioned but, to be honest, I didn't want to introduce it since it was really difficult to me to understand the usefulness of that...
Let me know.
A text file in userdata or something like that would be great. (The other addon write it to the desktop on a Windows installation if I remember correct.) It's just a very easy way of finding out which imdb top250 movies are missing in your library. Since I use mySQL as a central database I know it's also possibe to run some queries to find this out, but it is so much easier to have an addon just do that. And while the addon is scraping and updating the rankings anyway it's probably easy to produce this list on the go.
Hi @
daanwillems,
For example, considering the IMDb Top 250
here, the file should report "Schindler's List" in case this movie is not in your current Kodi library (as well as for all the others)? Is that a correct understanding?
Cheers,
Alex
Hello
Thanks for the Light IMDb Ratings Update add-on.
I have version 3.5.1 installed and it works perfectly.
I have a question: to install version 4.0.0, do I have to uninstall the previous version before?
Thank you very much for the help.
Hi there,
I came across this addon and would like to try it. However I have a few questions that didn't get asked here. Maybe someone knows the answers
1) Regarding a setup with multiple Media Center using a SQL Database. Is it correct that only one Machine ("Master") needs the addon installed and running as it writes to the Database and the others fetch it, or every machine needs it?
2) Compatible with every Skin? For example I'm using Aura which provides Movie Ratings through metadatautils. Can it cause any conflicts?
3) As far as I understand, the Option to change the standard rating works with every Skin and changes the Rating in the Library to the IMDB one?
Thanks!
(2019-02-14, 16:28)axlt2002 Wrote: [ -> ] (2019-02-14, 14:57)daanwillems Wrote: [ -> ] (2019-02-11, 10:00)axlt2002 Wrote: [ -> ]Hi daanwilliems and thanks for writing!
You mean you would like to have a text file that you can consult afterwards or directly inside Kodi? I know that such feature was in the add-on you mentioned but, to be honest, I didn't want to introduce it since it was really difficult to me to understand the usefulness of that...
Let me know.
A text file in userdata or something like that would be great. (The other addon write it to the desktop on a Windows installation if I remember correct.) It's just a very easy way of finding out which imdb top250 movies are missing in your library. Since I use mySQL as a central database I know it's also possibe to run some queries to find this out, but it is so much easier to have an addon just do that. And while the addon is scraping and updating the rankings anyway it's probably easy to produce this list on the go.
Hi @daanwillems,
For example, considering the IMDb Top 250 here, the file should report "Schindler's List" in case this movie is not in your current Kodi library (as well as for all the others)? Is that a correct understanding?
Cheers,
Alex
Exactly, if I rember correctly, the other addon wrote something like:
004 - The Dark Knight (2008) -
https://www.imdb.com/title/tt0468569/
008 - Pulp Fiction (1994) -
https://www.imdb.com/title/tt0110912/
010 - Fight Club (1999) -
https://www.imdb.com/title/tt0137523/
For the movies that were missing.
(2019-02-14, 21:10)daanwillems Wrote: [ -> ] (2019-02-14, 16:28)axlt2002 Wrote: [ -> ] (2019-02-14, 14:57)daanwillems Wrote: [ -> ]A text file in userdata or something like that would be great. (The other addon write it to the desktop on a Windows installation if I remember correct.) It's just a very easy way of finding out which imdb top250 movies are missing in your library. Since I use mySQL as a central database I know it's also possibe to run some queries to find this out, but it is so much easier to have an addon just do that. And while the addon is scraping and updating the rankings anyway it's probably easy to produce this list on the go.
Hi @daanwillems,
For example, considering the IMDb Top 250 here, the file should report "Schindler's List" in case this movie is not in your current Kodi library (as well as for all the others)? Is that a correct understanding?
Cheers,
Alex
Exactly, if I rember correctly, the other addon wrote something like:
004 - The Dark Knight (2008) - https://www.imdb.com/title/tt0468569/
008 - Pulp Fiction (1994) - https://www.imdb.com/title/tt0110912/
010 - Fight Club (1999) - https://www.imdb.com/title/tt0137523/
For the movies that were missing.
Ok, clear. I took a note on this feature...but I don't know yet when I will have time to implement it. Just be patient...
(2019-02-14, 19:01)sito1961 Wrote: [ -> ]Hello
Thanks for the Light IMDb Ratings Update add-on.
I have version 3.5.1 installed and it works perfectly.
I have a question: to install version 4.0.0, do I have to uninstall the previous version before?
Thank you very much for the help.
Hi sito1961, thanks for writing.
In general, any Kodi add-on can be updated without uninstalling the previous version. The same is for this one...
Just be aware of the fact that version 4.0.0 currently doesn't manage special episodes (i.e. "Season 0") and there are some misalignment issues in case of episodes that are splitted in two parts (i.e. DVD order). So, if your library includes such cases, I would suggest to stay with 3.5.1 until I will have time to work on that issues. Of course, if your library is "plane" (and huge), go ahead with 4.0.0 that really improves the performances from the timing perspective.
Have a nice day!
(2019-02-14, 20:27)D-m-x Wrote: [ -> ]Hi there,
I came across this addon and would like to try it. However I have a few questions that didn't get asked here. Maybe someone knows the answers
1) Regarding a setup with multiple Media Center using a SQL Database. Is it correct that only one Machine ("Master") needs the addon installed and running as it writes to the Database and the others fetch it, or every machine needs it?
2) Compatible with every Skin? For example I'm using Aura which provides Movie Ratings through metadatautils. Can it cause any conflicts?
3) As far as I understand, the Option to change the standard rating works with every Skin and changes the Rating in the Library to the IMDB one?
Thanks!
Hi D-m-x, very interesting questions!
I'm starting to answer to the latter: yes, the option on default rating does exactly wath you said; if set to true, IMDb ratings will be the default ratings in the Kodi database so that the skins will show them. If you want to revert back to the previous default ratings (e.g. the ones from TMDB), you have to rescrape them trough the appropriate information provider or media manager.
About the two other questions I don't want provide wrong information since I didn't consider such use cases (my setup is a single mediacenter using the default Estuary skin). What I can suggest, if you have time and patience, is to make a couple of trials and report back here so that the other users can take advantage of that. This would be really appreciated!
Thanks in advance!
There seems to be a problem when accessing the context update for movies which belong to a movie set. Here's an excerpt from the log, which is for "Wreck-it Ralph" from within the "Wreck-it Ralph collection":
Quote:12:04:51.260 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): start processing
12:04:51.306 T:2880340848 DEBUG: -->Python Interpreter Initialized<--
12:04:51.307 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): the source file to load is "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py"
12:04:51.308 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): setting the Python path to /storage/.kodi/addons/script.light.imdb.ratings.update:/storage/.kodi/addons/script.module.certifi/lib:/storage/.kodi/addons/script.module.chardet/lib:/storage/.kodi/addons/script.module.idna/lib:/storage/.kodi/addons/script.module.myconnpy/lib:/storage/.kodi/addons/script.module.requests/lib:/storage/.kodi/addons/script.module.simplejson/lib:/storage/.kodi/addons/script.module.urllib3/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages:/usr/lib/python2.7/site-packages/gtk-2.0
12:04:51.308 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): entering source directory /storage/.kodi/addons/script.light.imdb.ratings.update
12:04:51.309 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): instantiating addon using automatically obtained id of "script.light.imdb.ratings.update" dependent on version 2.25.0 of the xbmc.python api
12:04:51.337 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: loading setting definitions
12:04:51.337 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: trying to load setting definitions from old format...
12:04:51.339 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: loading setting values
12:04:52.171 T:2880340848 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.UnboundLocalError'>
Error Contents: local variable 'jSonQuery' referenced before assignment
Traceback (most recent call last):
File "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py", line 16, in <module>
UpdateContext()
File "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py", line 13, in UpdateContext
update_context.open_context_menu( sys.listitem.getfilename(), sys.listitem.getLabel() )
File "/storage/.kodi/addons/script.light.imdb.ratings.update/resources/core/update_context.py", line 56, in open_context_menu
jSonResponse = xbmc.executeJSONRPC( jSonQuery )
UnboundLocalError: local variable 'jSonQuery' referenced before assignment
-->End of Python script error report<--
12:04:52.171 T:2880340848 DEBUG: onExecutionDone(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py)
12:04:52.175 T:4094246928 DEBUG: ------ Window Init (DialogNotification.xml) ------
12:04:52.636 T:2880340848 INFO: Python interpreter stopped
12:04:52.637 T:2880340848 DEBUG: Thread LanguageInvoker 2880340848 terminating
I hope this is helpful for you.
(2019-02-15, 09:51)axlt2002 Wrote: [ -> ] (2019-02-14, 20:27)D-m-x Wrote: [ -> ]Hi there,
I came across this addon and would like to try it. However I have a few questions that didn't get asked here. Maybe someone knows the answers
1) Regarding a setup with multiple Media Center using a SQL Database. Is it correct that only one Machine ("Master") needs the addon installed and running as it writes to the Database and the others fetch it, or every machine needs it?
2) Compatible with every Skin? For example I'm using Aura which provides Movie Ratings through metadatautils. Can it cause any conflicts?
3) As far as I understand, the Option to change the standard rating works with every Skin and changes the Rating in the Library to the IMDB one?
Thanks!
Hi D-m-x, very interesting questions!
I'm starting to answer to the latter: yes, the option on default rating does exactly wath you said; if set to true, IMDb ratings will be the default ratings in the Kodi database so that the skins will show them. If you want to revert back to the previous default ratings (e.g. the ones from TMDB), you have to rescrape them trough the appropriate information provider or media manager.
About the two other questions I don't want provide wrong information since I didn't consider such use cases (my setup is a single mediacenter using the default Estuary skin). What I can suggest, if you have time and patience, is to make a couple of trials and report back here so that the other users can take advantage of that. This would be really appreciated!
Thanks in advance!
No, thank you for creating the Addon and answering
I tried it and if anyone else has the same questions I'm happy to report it works flawlessly. I installed the Addon on my Master Machine, the Ratings get updates and written to the Database. The other machines will pick it up instantly. So it works beatifully across the machines. There is also no problem with custom Skins, everything works just as it did before but better because the Ratings do change eventually.
(2019-02-16, 13:13)HeresJohnny Wrote: [ -> ]There seems to be a problem when accessing the context update for movies which belong to a movie set. Here's an excerpt from the log, which is for "Wreck-it Ralph" from within the "Wreck-it Ralph collection":
Quote:12:04:51.260 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): start processing
12:04:51.306 T:2880340848 DEBUG: -->Python Interpreter Initialized<--
12:04:51.307 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): the source file to load is "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py"
12:04:51.308 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): setting the Python path to /storage/.kodi/addons/script.light.imdb.ratings.update:/storage/.kodi/addons/script.module.certifi/lib:/storage/.kodi/addons/script.module.chardet/lib:/storage/.kodi/addons/script.module.idna/lib:/storage/.kodi/addons/script.module.myconnpy/lib:/storage/.kodi/addons/script.module.requests/lib:/storage/.kodi/addons/script.module.simplejson/lib:/storage/.kodi/addons/script.module.urllib3/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages:/usr/lib/python2.7/site-packages/gtk-2.0
12:04:51.308 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): entering source directory /storage/.kodi/addons/script.light.imdb.ratings.update
12:04:51.309 T:2880340848 DEBUG: CPythonInvoker(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py): instantiating addon using automatically obtained id of "script.light.imdb.ratings.update" dependent on version 2.25.0 of the xbmc.python api
12:04:51.337 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: loading setting definitions
12:04:51.337 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: trying to load setting definitions from old format...
12:04:51.339 T:2880340848 DEBUG: CAddonSettings[script.light.imdb.ratings.update]: loading setting values
12:04:52.171 T:2880340848 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.UnboundLocalError'>
Error Contents: local variable 'jSonQuery' referenced before assignment
Traceback (most recent call last):
File "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py", line 16, in <module>
UpdateContext()
File "/storage/.kodi/addons/script.light.imdb.ratings.update/context.py", line 13, in UpdateContext
update_context.open_context_menu( sys.listitem.getfilename(), sys.listitem.getLabel() )
File "/storage/.kodi/addons/script.light.imdb.ratings.update/resources/core/update_context.py", line 56, in open_context_menu
jSonResponse = xbmc.executeJSONRPC( jSonQuery )
UnboundLocalError: local variable 'jSonQuery' referenced before assignment
-->End of Python script error report<--
12:04:52.171 T:2880340848 DEBUG: onExecutionDone(34, /storage/.kodi/addons/script.light.imdb.ratings.update/context.py)
12:04:52.175 T:4094246928 DEBUG: ------ Window Init (DialogNotification.xml) ------
12:04:52.636 T:2880340848 INFO: Python interpreter stopped
12:04:52.637 T:2880340848 DEBUG: Thread LanguageInvoker 2880340848 terminating
I hope this is helpful for you.
Hi @
HeresJohnny, thanks a lot for reporting.
I have just made quick try on my library with The Batman movie set and I dind't receive any error. Can you just please clarify when it happens? Are you opening the context menu of the movie in the home screen widget or in another menu of Kodi? When the error heppens? While opening the context menu or when clicking on the "Update"? And...which version of the add-on are you using?
Thanks for that!
Excuse my ignorance but I apparently don't understand how to see the imdb top 250 info...
Installed the add-on, set it as the default scraper, all is well. On all movies the imdb score is displayed.
But, where/how to see the imdb top 250 info? I assumed that, for example with The Big Lebowski, it would somewhere say "Top 250 place 170".
Am I doing something wrong/missing a necessary setting?
Can't seem to find an edit post option as well apparently but I found where to see the top 250 info (long press movie, select Update imdb rating).
Is this the only way/place to see this rating?
(2019-02-18, 14:55)Pfeffernuss Wrote: [ -> ]Can't seem to find an edit post option as well apparently but I found where to see the top 250 info (long press movie, select Update imdb rating).
Is this the only way/place to see this rating?
Hi @
Pfeffernuss,
To see the Top 250 information you have to use a skin that supports it. If it doesn't, the only way is to check it in the context menu as you already have discovered.
Have a nice day.