Kodi Community Forum

Full Version: Please add full HDR and Dolby Vision Support to next kodi major Version
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8
(2020-11-10, 15:44)siriusbox Wrote: [ -> ]Edit for add a link to the Plex Forum where they said that https://forums.plex.tv/t/feature-request.../576028/41

Then they are not following the GPL licensing they are required to follow when releasing software publicly that includes a modified version of a GPL library, in this case ffmpeg, when doing this they are required to provide the source code.
FFmpeg definitely is used server side with Plex, as they have mentioned the switch from MediaInfo to only ffmpeg for Plex Media Server.
So I'm assuming they have made changes in their own build for parsing Dolby Vision parameters with the new Matroska spec.
Client side, the info seems to be sent directly to the app and that is passed directly to ExoPlayer to initialize the dvhe decoder.

I also haven't seen any commit regarding the new spec into ffmpeg. Plex does make their ffmpeg source available: https://downloads.plex.tv/ffmpeg-source
Maybe I'll look into that.
(2020-11-16, 22:53)quietvoid Wrote: [ -> ]FFmpeg definitely is used server side with Plex, as they have mentioned the switch from MediaInfo to only ffmpeg for Plex Media Server.
So I'm assuming they have made changes in their own build for parsing Dolby Vision parameters with the new Matroska spec.
Client side, the info seems to be sent directly to the app and that is passed directly to ExoPlayer to initialize the dvhe decoder.

I also haven't seen any commit regarding the new spec into ffmpeg. Plex does make their ffmpeg source available: https://downloads.plex.tv/ffmpeg-source
Maybe I'll look into that.
I did some testing on my Shield 2019 Pro with Plex and can confirm that MKVs with DV work. My Plex Server runs on Windows Server 2019 though (I'm not using the Plex server component on the Shield).

I believe the client side of Plex uses ExoPlayer to play these files (that is what is shown when you call up the Playback Info screen).

I'm guessing that the changes in ffmpeg are indeed only on the Plex server side to analyze the media.

So to play DV MKVs, Kodi would have to implement support for the new MKV specification, similar as to what ExoPlayer is doing.
Here is another DV discussion:

https://forum.kodi.tv/showthread.php?tid=349140

Regards Hoppel
oh nooo, Matrix without DV? please guys wait a bit and release it with DV.......
I have my DV movies in separate directories;
Film 4K DolbyVision Atmos-E (1999) 2160p HDR10
Filename:
Film 4K DolbyVision Atmos-E 2160p.10bit.HDR10.AC3.mkv

That's why in the playercorefactory.xml
changes the corresponding line in this way:
...
<rule filename=".*DolbyVision*." player="ExoPlayer"/>
...

Unfortunately, my DolbyVision films in Kodi are not recognized and an error message appears;
External player active
Press "OK" when playback is finished.


When I select my DV movies (i.e. corresponding *.mkv) using the Kodi file manager,
then the movies are played with ExoPlayer in DV.

When I select my other movies (i.e. corresponding *.mkv) via the Kodi file manager
then the movies are played with the internal Kodi-Player in e.g. HDR.

Where do I make the mistake?

Many thanks for your help
Tenker
I already answered in the German Kodinerds forum. Wink
(2020-09-09, 00:03)hoppel118 Wrote: [ -> ]Hello,

I use an Nvidia Shield TV Pro 2019. For me it worked the following way. This is early alpha and for testing purposes only!
 
  1. Mount your NAS directories to your Nvidia Shield at Andorid TV OS level (not in Kodi)
  2. Save a file with the name "playercorefactory.xml" including the content below to your NAS
  3. Download yusesope's modified Exoplayer to your NAS from here: https://www.makemkv.com/forum/viewtopic....125#p94191
  4. Install "X-plore File Manager" on your Nvidia Shield from here: https://play.google.com/store/apps/detai...lore&hl=de
  5. install the modified Exoplayer.apk through your android filemanager (X-plore) from your NAS
  6. Open Kodi, go to Kodi File Manager, copy "playercorefactory.xml" from your NAS to your Kodi "Profile Directory" (Android/data/org.xbmc.kodi/files/.kodi/userdata/)
  7. Restart Kodi, go to Kodi File Manager and open your DV file "Name (2020 DV).mkv" from the OS mount  (The file name should contain "DV" to automatically play the file by the modified Exoplayer)
  8. Now you should see the DV logo triggered on your tv

playercorefactory.xml

<playercorefactory>
<players>
<player name="ExoPlayer" type="ExternalPlayer" audio="false" video="true">
<filename>com.google.android.exoplayer2.demo</filename>
<hidexbmc>true</hidexbmc>
<playcountminimumtime>120</playcountminimumtime>
</player>
</players>
<rules action="prepend">
<rule video="true" player="dvdplayer">
<rule filename=".*DV.*" player="ExoPlayer"/>
</rule>
</rules>
</playercorefactory>


Additional information about the steps listed above
  • It doesn‘t work if you play a DV file from a Kodi mounted folder! The files need to be accessable from an usb device connected to your Nvidia Shield or mounted from Android OS level
  • For automatic refresh rate switching you have to install and configure the App "Refresh Rate" from here: https://play.google.com/store/apps/detai...rate&hl=de
  • If you see the error message "Playback failed" you have to press the play button again, and again, ...
  • Alternatively you can change "DV" in the file name to what you want. If so, you also have to change the "rule filename" in the "playercorefactory.xml". For more details have a look at the kodi wiki: https://kodi.wiki/view/External_players

Interesting links to the work status
Kodi 19.x "Matrix" - Alpha 1 states the following:

Code:
Android:
Static HDR10 support for all source types (if supported by the device)
Dynamic Dolby Vision HDR support for streaming services (if supported by the device)

I hope that also DV mkv support gets done until stable Matrix release, but hope dies last. Wink

Regards Hoppel

Ok so I have done all of this but in Kodi file manager I cannot find my local SMB mounts on the Shield.  I see them all in X-plode file explorer but they do not appear in file manager of kodi.  How do I find them there?
i haven't tried this myself but the amount of work done here on a volunteer basis is just ridiculous!
i'll surely press the hell outta that "Donate" button Smile

just to be sure:

for now only single layer DV and .ts. atmos is playing fine
double layer and .mkv for later?

is this correct?

thanks a lot guys for all the effort put into this. stay safe
(2020-11-24, 16:41)MrMagic Wrote: [ -> ]
(2020-11-16, 22:53)quietvoid Wrote: [ -> ]FFmpeg definitely is used server side with Plex, as they have mentioned the switch from MediaInfo to only ffmpeg for Plex Media Server.
So I'm assuming they have made changes in their own build for parsing Dolby Vision parameters with the new Matroska spec.
Client side, the info seems to be sent directly to the app and that is passed directly to ExoPlayer to initialize the dvhe decoder.

I also haven't seen any commit regarding the new spec into ffmpeg. Plex does make their ffmpeg source available: https://downloads.plex.tv/ffmpeg-source
Maybe I'll look into that.
I did some testing on my Shield 2019 Pro with Plex and can confirm that MKVs with DV work. My Plex Server runs on Windows Server 2019 though (I'm not using the Plex server component on the Shield).

I believe the client side of Plex uses ExoPlayer to play these files (that is what is shown when you call up the Playback Info screen).

I'm guessing that the changes in ffmpeg are indeed only on the Plex server side to analyze the media.

So to play DV MKVs, Kodi would have to implement support for the new MKV specification, similar as to what ExoPlayer is doing.

Are you using the Nvidia Shield Plex app or the Kodi Plex connect to get Dolby vision to work?
(2021-01-10, 07:11)bkrieger Wrote: [ -> ]Are you using the Nvidia Shield Plex app or the Kodi Plex connect to get Dolby vision to work?
I was using the Shield Plex app to test.

But you should really start to follow this thread: https://forum.kodi.tv/showthread.php?tid=349140

DV support has been added to several unofficial Kodi builds that can be found there.

Unfortunately it's a bit unstable (not during playback, but getting the video to start), but that seems to be more of an issue with the Shield's firmware.
(2021-01-10, 11:57)MrMagic Wrote: [ -> ]
(2021-01-10, 07:11)bkrieger Wrote: [ -> ]Are you using the Nvidia Shield Plex app or the Kodi Plex connect to get Dolby vision to work?
I was using the Shield Plex app to test.

But you should really start to follow this thread: https://forum.kodi.tv/showthread.php?tid=349140

DV support has been added to several unofficial Kodi builds that can be found there.

Unfortunately it's a bit unstable (not during playback, but getting the video to start), but that seems to be more of an issue with the Shield's firmware.

Thank You
(2021-02-04, 04:27)bkrieger Wrote: [ -> ]
(2021-01-10, 11:57)MrMagic Wrote: [ -> ]
(2021-01-10, 07:11)bkrieger Wrote: [ -> ]Are you using the Nvidia Shield Plex app or the Kodi Plex connect to get Dolby vision to work?
I was using the Shield Plex app to test.

But you should really start to follow this thread: https://forum.kodi.tv/showthread.php?tid=349140

DV support has been added to several unofficial Kodi builds that can be found there.

Unfortunately it's a bit unstable (not during playback, but getting the video to start), but that seems to be more of an issue with the Shield's firmware.

Thank You

Also have been reading there are color issues having to do with Nvidia Shied and Dolby Vision.

Also confused after reading about dual and single layer. I usually rip my backups via make mkv. Is this correct and should there be more steps after this to get proper Dolby vision?
Bump

Any news/progress on this please?
News progress on what exactly?

Windows and Android have full HDR10 support.

Android has a community build adding Dolby Vision support, Dolby Vision is not possible for any of the other platforms currently.
Pages: 1 2 3 4 5 6 7 8