Kodi Community Forum

In order to provide @popcornmix 's leia_pi4 fork for Arch ARM, I need to make two modifications.  Arch ARM builds packages in a clean-chroot (a buildroot) that is a subdirectory/fakeroot containing all dependencies for the build.

Not doing both steps causes build failures:
1) Manually copy /opt/vc/lib/pkgconfig/{bcm_host.pc,mmal.pc,vcsm.pc} to $srcdir/pkgconfig/ and prefix my cmake command with: export PKG_CONFIG_PATH=$srcdir/pkgconfig. 

2) Manually rename or delete the following directories in buildroot (provided by the raspberrypi-firmware package): /opt/vc/include/{EGL,GLES,GLES2}

I can do step 1 in the PKGBUILD no problem, but I cannot do step 2 since those directories are not under the control of the buildroot user (ie they are root:root).  Step 2 is needed to avoid this build error.

My strategy to circumvent is to simply copy the contents of /buildroot/opt/vc to the build space and then modify that copy, deleting the offending directories.  For that to work, I need to redirect cmake to use it rather than the native location.

Native location (all owned by root:root): /buildroot/opt/vc
Needed location (all owned by myuser:mygroup): $srcdir/opt

Is there a variable or variables I can export or CMAKE switches I can use that would allow me to redefine so the build will uses the new location?

My best guess at a workaround is to define each of the VARS the code wants like this:

The build gets going but dies here:

Some of the VARS I defined there are dropped it seems:

I'm not sure how to proceed. Link to entire build log. Your insights are welcomed and thank you again for all the time you have put into this.

-D*_LIBRARY stuff should refer to the DSO itself, eg /path/to/libwhatever.so.1.2 not the directory.
I'm not sure if include dirs are passed from cmake to ffmpeg in-tree build Makefile/Cmakelist.txt (eg -DMMAL_INCLUDE_DIR), I guess they are not.

@asavah

About the -D*_LIBRARY stuff, when I read cmake/modules/FindMMAL.cmake and then look for the corresponding files:

I get:


So it seems that the following are not *.so files:
mmal.h (corresponding to MMAL_INCLUDE_DIR)
libvchostif.a (corresponding to VCHOSTIF_LIBRARY)
libvcilcs.a (corresponding to VCILCS_LIBRARY)

All others are under /opt/vc/lib so I modified the cmake line as so:


This still causes build errors/dropped items (since they are not libraries).  Is the solution to modify tools/depends/target/ffmpeg/CMakeLists.txt hardcoding the expected paths therein?

Yep, I was not 100% correct here when I said DSO, I should have said just "library", in case of static libraries ofcourse those will be *.a files.

> Is the solution to modify tools/depends/target/ffmpeg/CMakeLists.txt hardcoding the expected paths therein

https://github.com/popcornmix/xbmc/blob/...ts.txt#L22 the paths there are already hardcoded, make that line matches your actual paths.

(2019-07-25, 22:42)asavah Wrote: [ -> ]Yep, I was not 100% correct here when I said DSO, I should have said just "library", in case of static libraries ofcourse those will be *.a files.

Nice, progress! The build made it MUCH further now that I added this patch.

The build still fails, this time in the linking step it looks like ...complete build log.

Small piece:

Totally expected.

Try adding 
string(CONCAT CMAKE_EXE_LINKER_FLAGS ${CMAKE_EXE_LINKER_FLAGS} " -L/path/to/dir/where/your/firmware/libs/are")

Just above this line https://github.com/popcornmix/xbmc/blob/...ts.txt#L34

@asavah - Thanks for that.  I added that line (see this patch inspired by your advice) but still got errors on Linking CXX ...

Full build log appears the same.  Linked here.

You still have a truckload of

Quote:WARNING: Target "kodi-test" requests linking to directory "/build/kodi-rbp4/src/opt/vc/lib". Targets may link only to libraries. CMake is dropping the item.

Final binary won't link until this is solved.
You've made quite a mess there with that /build/blah prefix, the buildsystem does not expect this path to rpi specific stuff.

@asavah - Yes, I see them.  If I remove the extra lines, cmake fails early I think due to cmake/modules/FindMMAL.cmake

For example, here is the output from cmake when I remove just one of those lines (in this case the -DVCILCS_LIBRARY="/build/kodi-rbp4/src/kodi-build/opt/vc/lib"):

If those lines are indeed the problem, is there a way we can modify that file to simply not look for them and to pass the needed paths on via hard coding them into it?  I am just not knowledgeable with this cmake file to know how to do that or if it is a sound strategy.

EDIT: I make this patch which I think defines these without having cmake do it but that did not help.  Still got the "Targets may link only to libraries" messages and linking errors.  Build log.  I am not sure how to proceed.

As I've already said *_LIBRARY= are files or symlinks to files and not directories, either .so or .a.
-DVCILCS_LIBRARY="/build/kodi-rbp4/src/kodi-build/opt/vc/lib" is wrong
It should be
-DVCILCS_LIBRARY="/build/kodi-rbp4/src/kodi-build/opt/vc/lib/libvcilcs.a"
and so on.

@asavah - AH!  I understand now.  Thank you very much for your help.  I believe this is 100%.

https://github.com/graysky2/PKGBUILDs/bl...4/PKGBUILD

(2019-07-27, 04:10)graysky Wrote: [ -> ]I believe this is 100%.

Yay! 

(2019-07-27, 04:10)graysky Wrote: [ -> ]@asavah - AH!  I understand now.  Thank you very much for your help.  I believe this is 100%.

https://github.com/graysky2/PKGBUILDs/bl...4/PKGBUILD

Thanks for all the work on this guys!

Agreed, this and the other 2 threads I started on this topic represent a strong team effort with lots of credit going to both @popcornmix and @asavah.  The product of this work is a kodi-rbp4 package with hardware decoding available for Arch ARM.  I submitted PR#1720 earlier today which if accepted will add it to the official repos.

Thanks again, guys!

Nice job. Can you check https://github.com/raspberrypi/linux/pull/3111 as that may require updated udev rules once the change appears in arch kernel.