2011-01-07, 01:47
I've been looking at dabbling in some skins, mainly to customize them to suit me.
However, it seems that there is a ton of copy paste code due to the way that some things are called.
My suggestion is for the Skinning parameters that take WindowIds to accept either an array or multiple inputs.
Here is just one example from Aeon:
Could easily be shortened to
!Window.Previous([4, 11, 24, 25, 1, 2, 500, 501, 502, Home])
or
!Window.Previous(4, 11, 24, 25, 1, 2, 500, 501, 502, Home)
Second / Last Parameter could be a string or flag if the windows should be AND or OR together. (Although I haven't yet seen any &, since previous windows and such only have one state...).
I just thought of this at work so I haven't had time to dig into the code, but it shouldn't be more difficult than doing a recursive call on each of the elements.
However, it seems that there is a ton of copy paste code due to the way that some things are called.
My suggestion is for the Skinning parameters that take WindowIds to accept either an array or multiple inputs.
Here is just one example from Aeon:
Code:
<visible>![Window.Previous(4) | Window.Previous(11) | Window.Previous(24) | Window.Previous(25) | Window.Previous(1) | Window.Previous(2) | Window.Previous(500) | Window.Previous(501) | Window.Previous(502) | Window.Previous(Home)]</visible>Could easily be shortened to
!Window.Previous([4, 11, 24, 25, 1, 2, 500, 501, 502, Home])
or
!Window.Previous(4, 11, 24, 25, 1, 2, 500, 501, 502, Home)
Second / Last Parameter could be a string or flag if the windows should be AND or OR together. (Although I haven't yet seen any &, since previous windows and such only have one state...).
I just thought of this at work so I haven't had time to dig into the code, but it shouldn't be more difficult than doing a recursive call on each of the elements.