I suggest moving DVD controls (play/eject..) to a predefined dialog with assigned id, so it can be hidden by system on iOS devices and such.
Funny you should post this now because I was just coding the 'Eject tray' and 'Play disc' buttons for my next skin, and while we can hide the 'Play disc' button if there' nothing in the tray, we can't hide the 'Eject' button if there isn't a drive.
What I would like to suggest is a boolean condition based on whether there's a CD/DVD drive available so we can hide the Eject button if it's not needed.
ie
System.CanEject or System.HasDrive
Thanks.
Hitcher Wrote:Funny you should post this now because I was just coding the 'Eject tray' and 'Play disc' buttons for my next skin, and while we can hide the 'Play disc' button if there' nothing in the tray, we can't hide the 'Eject' button if there isn't a drive.
What I would like to suggest is a boolean condition based on whether there's a CD/DVD drive available so we can hide the Eject button if it's not needed.
ie
System.CanEject or System.HasDrive
Thanks.
I beg to differ :-)
If the system knows the answer let it do it's job without our assistance
I'd still need a boolean condition as other elements besides the button are based on it.
Hitcher Wrote:I'd still need a boolean condition as other elements besides the button are based on it.
My thinking was: if we have predefined system button to call system dialog for DVD stuff, system could hide that button if DVD dialog's not supported by platform. E.g if you call ShutDownMenu on ATV2 it just quits.
This will be an increasing problem. I'm not sure as yet what makes most sense.
Certainly just quitting when "shutdownmenu" is called is IMO the wrong way to go.
Usually most folk put buttons inside a grouplist (which may be aligned etc.) so disabling individual buttons seems to be the better way to go to me.
Doing this in a way that doesn't add burden to skinners is tricky though (while still allowing flexibility).
Solved it (at least from where I stand).
Eject/load shown only when media present in drive. It's not 100% percent but I expect user can load disc manually, problem is rather with eject.
One idea might be to borrow from the new slider controls (for volume and seek) which essentially gives an <action> field that describes more what the slider does rather than the actual action that is executed and how it's executed.
Perhaps we could do a similar thing with buttons - i.e. encompass both the visibility and click in a "what this button is for" tag, so that XBMC takes care of visibility and the action for you?
Cheers,
Jonathan