(2017-07-28, 15:52)manül Wrote: @FernetMenta If OpenLiveStream, OpenRecordedStream and their fellow calls are going to be removed from the new PVR class, is it enough to implement their counterparts from CInstanceInputStream and leave the Demux functions alone/stub/unimplemented?

(2017-07-28, 13:07)rbuehlma Wrote: Something like this could be used:

For Live-TV:
PVR_ERROR GetLiveStreamUrl(channel, out url, out propertyMap);

For Recordings:
PVR_ERROR GetRecordingUrl(recording, out url, out propertyMap);

and in case we handle Replay separate from recordigns:
PVR_ERROR GetEpgTagUrl(epgTag, out url, out propertyMap);

(2017-07-28, 18:56)ksooo Wrote:

(2017-07-28, 13:07)rbuehlma Wrote: Something like this could be used:

For Live-TV:
PVR_ERROR GetLiveStreamUrl(channel, out url, out propertyMap);

For Recordings:
PVR_ERROR GetRecordingUrl(recording, out url, out propertyMap);

and in case we handle Replay separate from recordigns:
PVR_ERROR GetEpgTagUrl(epgTag, out url, out propertyMap);

Yeah, that basically would do the job, imo.

The function for TV should not have "Live" in its name, though, as it can also provide an url for a non-live stream (time shifting).

(2017-07-28, 18:56)ksooo Wrote: Not sure we need the epg tag url function. Don't want to pull this functional enhancement (replay) into this discussion, tbh. I suggest for now to concentrate on what we have before discussing new functionality.

(2017-07-28, 18:56)ksooo Wrote: For recordings, PVR_RECORDING.strRecordingUrl would be removed in favour of the new function, which provides more flexibility and is aligned with new tv concept, then.

Just one question regarding properties: what properties are needed and what will Kodi do with them after retrieval from the add-on? This is not clear to me.

(2017-07-29, 00:27)da-anda Wrote: @rbuehlma, what about

PVR_ERROR GetStreamUrl(epgTag, timeShiftOffset, out url, out propertyMap);

The EPG tag contains the channel info as welll, doesn't it? So by always using an EPGtag (a dummy one if no EPG info is available for a channel) it would allow the PVR add-on to return either a timeshift buffer URL, live stream URL a recording or replay/on demand URL.
Alternatively the return value could be an array/vector/etc which contains the available stream types and their URLs (live, recording, on demand) and in case there are several, Kodi could provide a select dialog. Just an idea from an outsider - not sure if it's feasable

(2017-07-29, 15:48)rbuehlma Wrote:

(2017-07-29, 00:27)da-anda Wrote: @rbuehlma, what about

PVR_ERROR GetStreamUrl(epgTag, timeShiftOffset, out url, out propertyMap);

The EPG tag contains the channel info as welll, doesn't it? So by always using an EPGtag (a dummy one if no EPG info is available for a channel) it would allow the PVR add-on to return either a timeshift buffer URL, live stream URL a recording or replay/on demand URL.
Alternatively the return value could be an array/vector/etc which contains the available stream types and their URLs (live, recording, on demand) and in case there are several, Kodi could provide a select dialog. Just an idea from an outsider - not sure if it's feasable

I'm not sure if the epg tag is required. If we have the channel and the offset, it should be possible for the addon to determine the epgTag. What is your opinion @ksooo and @FernetMenta?

Would this API:
PVR_ERROR GetChannelStreamUrl(channel, timeShiftOffset, out url, out propertyMap);
PVR_ERROR GetRecordingUrl(recording, out url, out propertyMap);

a good way to go? If timeShiftOffset is 0, the addon would deliver a url to the live stream. Else, it would deliver the stream starting from the requested position. If the Replay button is used in Kodi (or by selecting an EPG entry), Kodi would set the corresponding offset.

If yes, could anyone of you translate them into a C-API for me? I'm not really used to C/C++ and am not sure of the proper format for this API

@scarecrow420 yes, and URL can be anything Kodi can play.