Release - script.colorbox - Printable Version

Release script.colorbox - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+---- Forum: Skin helper addons (https://forum.kodi.tv/forumdisplay.php?fid=300)
+---- Thread: Release script.colorbox (/showthread.php?tid=318626)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

RE: script.colorbox - badaas - 2021-06-23

(2021-04-29, 19:02)drinfernoo Wrote: @badaas, I've sent over a PR on GitHub: https://github.com/BADMS/script.colorbox/pull/4

Hopefully this PR will resolve any issues, allowing cross-compatibility with Leia and Matrix. I've tested it in Aura on Leia and @SerpentDrago69's AuraMOD on Matrix, and all appears to be in order, including all blur effects and color matching

Welll done @Angelinas sorry I'm not having time ATM to keep up! ;_)

RE: script.colorbox - beatmasterrs - 2021-06-23

(2021-06-23, 10:45)badaas Wrote:
(2021-04-29, 19:02)drinfernoo Wrote: @badaas, I've sent over a PR on GitHub: https://github.com/BADMS/script.colorbox/pull/4

Hopefully this PR will resolve any issues, allowing cross-compatibility with Leia and Matrix. I've tested it in Aura on Leia and @SerpentDrago69's AuraMOD on Matrix, and all appears to be in order, including all blur effects and color matching

Welll done @Angelinas sorry I'm not having time ATM to keep up! ;_)

I dont know, if i had asked before, but will the addon be available in the official kodi repo? Smile

That would be great! Smile

RE: script.colorbox - badaas - 2021-06-23

(2021-06-23, 10:54)beatmasterrs Wrote:
(2021-06-23, 10:45)badaas Wrote:
(2021-04-29, 19:02)drinfernoo Wrote: @badaas, I've sent over a PR on GitHub: https://github.com/BADMS/script.colorbox/pull/4

Hopefully this PR will resolve any issues, allowing cross-compatibility with Leia and Matrix. I've tested it in Aura on Leia and @SerpentDrago69's AuraMOD on Matrix, and all appears to be in order, including all blur effects and color matching

Welll done @Angelinas sorry I'm not having time ATM to keep up! ;_)

I dont know, if i had asked before, but will the addon be available in the official kodi repo? That would be great!

@Angelinas needs to get that started, I just can't remember all the hoops and how to jump through them ATM! ;_)

RE: script.colorbox - drinfernoo - 2021-06-23

(2021-06-23, 10:45)badaas Wrote:
(2021-04-29, 19:02)drinfernoo Wrote: @badaas, I've sent over a PR on GitHub: https://github.com/BADMS/script.colorbox/pull/4

Hopefully this PR will resolve any issues, allowing cross-compatibility with Leia and Matrix. I've tested it in Aura on Leia and @SerpentDrago69's AuraMOD on Matrix, and all appears to be in order, including all blur effects and color matching

Welll done @Angelinas sorry I'm not having time ATM to keep up! ;_)

I sent the PR through...

RE: script.colorbox - badaas - 2021-06-23

(2021-06-23, 14:24)drinfernoo Wrote:
(2021-06-23, 10:45)badaas Wrote:
(2021-04-29, 19:02)drinfernoo Wrote: @badaas, I've sent over a PR on GitHub: https://github.com/BADMS/script.colorbox/pull/4

Hopefully this PR will resolve any issues, allowing cross-compatibility with Leia and Matrix. I've tested it in Aura on Leia and @SerpentDrago69's AuraMOD on Matrix, and all appears to be in order, including all blur effects and color matching

Welll done @Angelinas sorry I'm not having time ATM to keep up! ;_)

I sent the PR through...

For some reason the pull request is on an old commit, probably better I delete repo and start again.. Will have a looksee.
script.litebox is done (colorbox lite).
There is some stuff I noticed doesn't work properly in Utils.py that I can submit here? [ https://github.com/kodi-community-addons/script.colorbox ]

RE: script.colorbox - badaas - 2021-06-23

Ok, here is litebox: [ https://drive.google.com/file/d/194ItVEiKHm-F7K4keEtlpe9ursiNPlHs/view?usp=sharing ]
And skin.ambex (Amber modded roughly) to test: [ https://drive.google.com/file/d/1aLtgNebUQC0ypqKJqpVVtHWiZ7ZuzH_8/view?usp=sharing ]

Install both addons via .zip, in skin.ambex you need to enable fanart on sub windows via skin settings (backgrounds).

EDIT: Updated Ambex skin a bit more

RE: script.colorbox - drinfernoo - 2021-06-24

I'm not sure where you want to contribute your add-on to... I just tried to fix up the original colorbox Wink

RE: script.colorbox - badaas - 2021-06-24

Oh there's two of you! Might just put litebox on Matrix repo... Colorbox can stay in marcel repo??
Are drinferno and Angelinas colorbox the same?

Confused ..

RE: script.colorbox - beatmasterrs - 2021-06-24

(2021-06-24, 09:45)badaas Wrote: Oh there's two of you! Might just put litebox on Matrix repo... Colorbox can stay in marcel repo??
Are drinferno and Angelinas colorbox the same?

Confused ..

What's the difference between colorbox and litebox? Please put colorbox also in matrix repo, that would be great Smile

RE: script.colorbox - badaas - 2021-06-24

(2021-06-24, 10:46)beatmasterrs Wrote:
(2021-06-24, 09:45)badaas Wrote: Oh there's two of you! Might just put litebox on Matrix repo... Colorbox can stay in marcel repo??
Are drinferno and Angelinas colorbox the same?

Confused ..

What's the difference between colorbox and litebox? Please put colorbox also in matrix repo, that would be great

litebox only has blur, and only two images it processes (7975 & current fanart).
Everything else the same.

RE: script.colorbox - beatmasterrs - 2021-06-24

(2021-06-24, 12:01)badaas Wrote:
(2021-06-24, 10:46)beatmasterrs Wrote:
(2021-06-24, 09:45)badaas Wrote: Oh there's two of you! Might just put litebox on Matrix repo... Colorbox can stay in marcel repo??
Are drinferno and Angelinas colorbox the same?

Confused ..

What's the difference between colorbox and litebox? Please put colorbox also in matrix repo, that would be great
litebox only has blur, and only two images it processes (7975 & current fanart).
Everything else the same.

Thanks for the clarification. Smile

It would be nice if both or one of the addons made it into the matrix repo, as the blur function are faster with these addons than with other addons. Other functions like greyscale/pixelate are also very nice. Thanks for your work! Smile

RE: script.colorbox - badaas - 2021-06-24

(2021-06-24, 12:14)beatmasterrs Wrote:
(2021-06-24, 12:01)badaas Wrote:
(2021-06-24, 10:46)beatmasterrs Wrote: What's the difference between colorbox and litebox? Please put colorbox also in matrix repo, that would be great
litebox only has blur, and only two images it processes (7975 & current fanart).
Everything else the same.

Thanks for the clarification. It would be nice if both or one of the addons made it into the matrix repo, as the blur function are faster with these addons than with other addons. Other functions like greyscale/pixelate are also very nice. Thanks for your work!

Can add pixelate and grayscale maybe to litebox as they simple ops..

Will see what to do, see how smoothly litebox goes in repo first ;_)

RE: script.colorbox - beatmasterrs - 2021-06-24

(2021-06-24, 13:49)badaas Wrote:
(2021-06-24, 12:14)beatmasterrs Wrote:
(2021-06-24, 12:01)badaas Wrote: litebox only has blur, and only two images it processes (7975 & current fanart).
Everything else the same.

Thanks for the clarification. It would be nice if both or one of the addons made it into the matrix repo, as the blur function are faster with these addons than with other addons. Other functions like greyscale/pixelate are also very nice. Thanks for your work!
Can add pixelate and grayscale maybe to litebox as they simple ops..

Will see what to do, see how smoothly litebox goes in repo first ;_)

Sounds good Smile

RE: script.colorbox - drinfernoo - 2021-06-24

As far as I know, mine and @Angelinas are different... They apparently had a working copy, but never shared the code or a zip, so I just did it myself Smile

I tried to keep code changes very minimal, and only update what actually needed to be fixed in order to bring it up to date for Matrix, while maintaining compatibility with Leia. The version I submitted via PR works in both, with no changes required.

You did merge my changes into the main GitHub repository... But they're different from what @Angelinas has put on the repo.

RE: script.colorbox - badaas - 2021-06-25

(2021-06-24, 21:44)drinfernoo Wrote: As far as I know, mine and @Angelinas are different... They apparently had a working copy, but never shared the code or a zip, so I just did it myself

I tried to keep code changes very minimal, and only update what actually needed to be fixed in order to bring it up to date for Matrix, while maintaining compatibility with Leia. The version I submitted via PR works in both, with no changes required.

You did merge my changes into the main GitHub repository... But they're different from what @Angelinas has put on the repo.

Ok, the version I had was @Angelinas then.
I will cross check with your pulls and see what can be cherry picked/used.
Thanks to you @drinfernoo and @Angelinas for your time.

I will submit litebox to Matrix repo, with credits to you both.
And not sure about colorbox, I think that is more specialized and maybe just leave in kodi-community-addons, but put some of the simpler image ops in litebox..

Many thanks again to both, I wouldn't of had time to get any of this done with yous!