Kodi Community Forum
Mod Estuary MOD - KODI 17 (DISCONTINUED) - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Estuary (https://forum.kodi.tv/forumdisplay.php?fid=260)
+---- Thread: Mod Estuary MOD - KODI 17 (DISCONTINUED) (/showthread.php?tid=267343)



RE: Estuary MOD (UPDATED 13/12/16) - outcave - 2016-12-21

(2016-12-21, 00:07)Guilouz Wrote:
(2016-12-20, 23:57)outcave Wrote: Guilouz remember the double TMDB info problem.
You always said: working for me.
But now it is solved :-)


Yes because now i only use v18.
And Gracus spoke of the passage v18 to v17 and this is what put the chip in my ear ^^

I talked about that problem one week ago much before the Gracus post.
Anyway no problem and always thanks for this great mod!! :-)


RE: Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 00:00)Klojum Wrote:
(2016-12-20, 23:48)Guilouz Wrote: I use Kodi on OSX and with LibreELEC.
I think your issue not depend to your system you use.
I'm not sure you will see something in debug log for that.

Have you try latest git version ?

I have try with v17 and v18 with 1.7.3 and i have not this issue on 21:9 screen.

OSX? I had the impression you used only Windows. Never mind then.

No, haven't tried the lastest git yet. I only use the repo for now. I'm not too active with git as maybe I should: "So many things to do, so little time" is my motto these days (and evenings)

Or perhaps implement a shorter update sequence for EstuaryMOD? People always love to see a higher software version.
I'll try to dive into git tomorrow.

I will release 1.7.3 soon. I was waiting for return of some people for eventually issue.


RE: Estuary MOD (UPDATED 13/12/16) - outcave - 2016-12-21

I suggest to use Kodi 17 because most users use it.
Remember that Kodi 17 is still BETA and Kodi 18 is still ALPHA.


RE: Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 00:02)outcave Wrote: And talking about issue:
If you choose to view the TMDB or IMDB rating, the number of the rating is always the same.
So take a movie for example, go to switch from TMDB and IMDB and you will see exactly the same number of rate value (also if the two sites have different rate value for that movie).
It always show only the TMDB rate number.

Image Image


RE: Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 00:11)outcave Wrote: I suggest to use Kodi 17 because most users use it.
Remember that Kodi 17 is still BETA and Kodi 18 is still ALPHA.

Kodi 17 is at the end for beta state and it will be released soon. I must use Kodi 18 to keep up to date with changes are done in Kodi core.


RE: Estuary MOD (UPDATED 13/12/16) - outcave - 2016-12-21

(2016-12-21, 00:12)Guilouz Wrote:
(2016-12-21, 00:02)outcave Wrote: And talking about issue:
If you choose to view the TMDB or IMDB rating, the number of the rating is always the same.
So take a movie for example, go to switch from TMDB and IMDB and you will see exactly the same number of rate value (also if the two sites have different rate value for that movie).
It always show only the TMDB rate number.

Image Image

On Libreelec 7.90.009 (Kodi 17 beta 6) it does not work.


RE: Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 00:14)outcave Wrote:
(2016-12-21, 00:12)Guilouz Wrote:
(2016-12-21, 00:02)outcave Wrote: And talking about issue:
If you choose to view the TMDB or IMDB rating, the number of the rating is always the same.
So take a movie for example, go to switch from TMDB and IMDB and you will see exactly the same number of rate value (also if the two sites have different rate value for that movie).
It always show only the TMDB rate number.

Image Image

On Libreelec 7.90.009 (Kodi 17 beta 6) it does not work.

With skin for Kodi 17 :

Image Image

I don't think it's a skin issue.

IMDB rating is from Kodi core and TMDB rating is from Skin Helper Service. Make sure you have latest repo version for it.

Do not forget Kodi 17/18 are in beta/alpha stage and Skin Helper Service from marcelveldt too, some things can be broken or not working properly.


RE: Estuary MOD (UPDATED 13/12/16) - outcave - 2016-12-21

Ok.
I always use the last addon/repository.
If I always have only TMDB rating values I suppose that Skin Helper works in this case.
Then may be a Kodi problem...
Anyway try to give a look at code.
Thanks.


RE: Estuary MOD (UPDATED 13/12/16) - bmonster - 2016-12-21

(2016-12-20, 22:00)Guilouz Wrote:
(2016-12-20, 14:56)bmonster Wrote:
(2016-12-20, 13:40)Guilouz Wrote: There is already info on OSD.

Hi guilouz

Could you tell me how to get it to display, as I'm not seeing it.

These pics are from your skin, the other pics were from estuary..

https://drive.google.com/file/d/0BwAs5IrGyaBcVHc2V0Q4SXRtYWs/view?usp=drivesdk

https://drive.google.com/file/d/0BwAs5IrGyaBcUW8xQTU3UEtZb2c/view?usp=drivesdk

As you can see no programme details on osd, like estuary has..

Regards

Press button "i" to have informations.

That's not what I mean, while surfing the channels on estuary, the description is shown as you can see in the 1st lot of pics.

But don't worry, I'll do it myself..Big Grin


RE: Estuary MOD (UPDATED 13/12/16) - Gracus - 2016-12-21

(2016-12-21, 00:20)Guilouz Wrote:
(2016-12-21, 00:14)outcave Wrote:
(2016-12-21, 00:12)Guilouz Wrote: Image Image

On Libreelec 7.90.009 (Kodi 17 beta 6) it does not work.

With skin for Kodi 17 :

Image Image

I don't think it's a skin issue.

IMDB rating is from Kodi core and TMDB rating is from Skin Helper Service. Make sure you have latest repo version for it.

Do not forget Kodi 17/18 are in beta/alpha stage and Skin Helper Service from marcelveldt too, some things can be broken or not working properly.

I am not even sure that Kodi core always grab IMDB rating only
I think it grab whatever the scraper is set to grab

The default movie scraper as default will grab TMDB rating so if you set the skin to display the rating from kodi core expecting it to be IMDB one you may probabably display TMDB one instead
Then you set the skin to display TMDB rating from skinhelper and have the exact same number as a result

Could be good to try with a movie library made with scrapper set to grab IMDB rating just to check my theory...


RE: Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 01:55)Gracus Wrote:
(2016-12-21, 00:20)Guilouz Wrote:
(2016-12-21, 00:14)outcave Wrote: On Libreelec 7.90.009 (Kodi 17 beta 6) it does not work.

With skin for Kodi 17 :

Image Image

I don't think it's a skin issue.

IMDB rating is from Kodi core and TMDB rating is from Skin Helper Service. Make sure you have latest repo version for it.

Do not forget Kodi 17/18 are in beta/alpha stage and Skin Helper Service from marcelveldt too, some things can be broken or not working properly.

I am not even sure that Kodi core always grab IMDB rating only
I think it grab whatever the scraper is set to grab

The default movie scraper as default will grab TMDB rating so if you set the skin to display the rating from kodi core expecting it to be IMDB one you may probabably display TMDB one instead
Then you set the skin to display TMDB rating from skinhelper and have the exact same number as a result

Could be good to try with a movie library made with scrapper set to grab IMDB rating just to check my theory...

Now use Skin Helper Service for IMDB rating. Can you try on last git ?


RE: Estuary MOD (UPDATED 13/12/16) - Gracus - 2016-12-21

(2016-12-21, 02:53)Guilouz Wrote:
(2016-12-21, 01:55)Gracus Wrote:
(2016-12-21, 00:20)Guilouz Wrote: With skin for Kodi 17 :

Image Image

I don't think it's a skin issue.

IMDB rating is from Kodi core and TMDB rating is from Skin Helper Service. Make sure you have latest repo version for it.

Do not forget Kodi 17/18 are in beta/alpha stage and Skin Helper Service from marcelveldt too, some things can be broken or not working properly.

I am not even sure that Kodi core always grab IMDB rating only
I think it grab whatever the scraper is set to grab

The default movie scraper as default will grab TMDB rating so if you set the skin to display the rating from kodi core expecting it to be IMDB one you may probabably display TMDB one instead
Then you set the skin to display TMDB rating from skinhelper and have the exact same number as a result

Could be good to try with a movie library made with scrapper set to grab IMDB rating just to check my theory...

Now use Skin Helper Service for IMDB rating. Can you try on last git ?

I just fully reinstall kodi right now

Will try the last git as soon as possible and give you feedback


RE: Estuary MOD (UPDATED 13/12/16) - Gracus - 2016-12-21

(2016-12-21, 03:08)Gracus Wrote:
(2016-12-21, 02:53)Guilouz Wrote:
(2016-12-21, 01:55)Gracus Wrote: I am not even sure that Kodi core always grab IMDB rating only
I think it grab whatever the scraper is set to grab

The default movie scraper as default will grab TMDB rating so if you set the skin to display the rating from kodi core expecting it to be IMDB one you may probabably display TMDB one instead
Then you set the skin to display TMDB rating from skinhelper and have the exact same number as a result

Could be good to try with a movie library made with scrapper set to grab IMDB rating just to check my theory...

Now use Skin Helper Service for IMDB rating. Can you try on last git ?

I just fully reinstall kodi right now

Will try the last git as soon as possible and give you feedback

So here is the feedback!
(Kodi 18 and MOD from github)

Color pattern stuck to none:

Image

But now here is the interesting part: TMDB vs IMDB rating...

....and it works!

IMDB rating:
Image

TMDB rating:
Image

Ratings are different (screenshots are from one movie only but I made the comparison with at least 20 movies from my library)

Now question: does your MOD need the same modification for TV shows and TVDB vs IMDB rating?


Edit: your repo still show an update for French translation as references to it have not been removed from xml files of repo


Estuary MOD (UPDATED 13/12/16) - Guilouz - 2016-12-21

(2016-12-21, 03:51)Gracus Wrote:
(2016-12-21, 03:08)Gracus Wrote:
(2016-12-21, 02:53)Guilouz Wrote: Now use Skin Helper Service for IMDB rating. Can you try on last git ?

I just fully reinstall kodi right now

Will try the last git as soon as possible and give you feedback

So here is the feedback!
(Kodi 18 and MOD from github)

Color pattern stuck to none:

Image

But now here is the interesting part: TMDB vs IMDB rating...

....and it works!

IMDB rating:
Image

TMDB rating:
Image

Ratings are different (screenshots are from one movie only but I made the comparison with at least 20 movies from my library)

Now question: does your MOD need the same modification for TV shows and TVDB vs IMDB rating?


Pattern working for me on OSX and libreELEC, strange issue...

No for TVDB I already use Skin Helper Service.


RE: Estuary MOD (UPDATED 13/12/16) - Gracus - 2016-12-21

(2016-12-21, 03:53)Guilouz Wrote: Pattern working for me on OSX and libreELEC, strange issue...

Will try to investigate a little bit on this one but probably a bug in windows nightly...