+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: [New Feature] Movie version (/showthread.php?tid=337992)
RE: [New Feature] Movie version - jbinkley60 - 2023-12-19
(2023-12-19, 12:32)jjd-uk Wrote: While yes there are predefined version label types to make it easy and quicker for a remote control user, you can add any label you want to give to a version.
That is great to see.
Thanks,
Jeff
RE: [New Feature] Movie version - thezoggy - 2023-12-20
- Settings->Media->Library->Ignore different video versions on scan
IMHO this should have been enabled by default to keep kodi working as previously expected, and to prevent the breakage it caused with automation.
Or at least there needs to be an option added for the api (that defaults to on) to skip this option. so that way when you are doing remote library updates it does not show a user prompt that the user may not be around for.
This was the case for me, <removed> goes to add a movie (tell kodi to scan x folder for library update). It did the update like normal but the movie never got added.
A few days later I realize that I have not seen any new movies added in my library that I expect, when logging into my kodi-headless instance and loading up vnc I see the "Different movie version found" prompt waiting for me
I turned the "Ignore different video versions on scan" option on, and when scanning the movie to library from videos source folder it still gives me the prompt about different movie version.
Restarted kodi, tried another movie and still got it.
I don't know if the option to disable the prompt is bugged or just does not apply during the videos>source>folder - scan to library context menu?
RE: [New Feature] Movie version - bossanova808 - 2023-12-20
Agree on this - moment I saw that first pop up in my testing I thought...here's potential trouble. It should definitely be off by default on the scanning side of things as loads of people will perform scans in scenarios where Kodi sitting there waiting for input isn't going to work/be convenient.
But the feature is very much in flux, as I understand it - rather oddly given how late it the Omega dev. cycle this is (seems to me personally like it should either have gone in quite a lot earlier, in an alpha, or been bumped to P* as given this flux it just doesn't yet feel at all ready for release...but I know nothing of the Kodi dev/release system really, so that's just my poorly educated impression of course! But at the moment e.g. no one can really make a skin properly ready for Omega given this feature is in but not finished, and therefore nothing is documented).
It's a great new feature for sure, it just needs some thought as to sensible defensive defaults so that e.g. the many using headless Kodi don't run into unsolvable issues.
RE: [New Feature] Movie version - Karellen - 2023-12-20
(2023-12-20, 01:12)bossanova808 Wrote: rather oddly given how late it the Omega dev. cycle this isYep, it is late. RC1 is delayed and instead we will have a Beta 3.
RE: [New Feature] Movie version - XODIDOX - 2023-12-20
My statement https://forum.kodi.tv/showthread.php?tid=337992&pid=2796635
RE: [New Feature] Movie version - victord - 2023-12-20
I love this feature but it is having problems recognizing movie remakes. I searched this forum and I am sorry if this was already reported.
When i scan my library the Beta 2 version sees for example "Casino Royal (1967)" and "Casino Royal (2006)" as the same movie and asks if want to save it as a different version.
When they get saved in my library Kodi's scraper does recognize it as two different movies and shows the proper info for both with different years. It is just the new feature scan that has a problem distinquishing the difference. A second scan after the movies are in my library does not pop up the warning
Has any one noticed or reported this bug or shoud I?
RE: [New Feature] Movie version - Nanomani - 2023-12-20
(2023-12-20, 04:22)XODIDOX Wrote: My statement https://forum.kodi.tv/showthread.php?tid=337992&pid=2796635I hope it's just a misunderstanding because everyone is tired.
You don't deserve to end up like this.
I wanted to thank you like many others before for your hard work.
As well as the Kodi team who contributed with you to this feature.
I think the timing added stress to everyone.
See you soon I hope with better feeling
RE: [New Feature] Movie version - NeoCortex - 2023-12-20
(2023-12-20, 04:22)XODIDOX Wrote: My statement https://forum.kodi.tv/showthread.php?tid=337992&pid=2796635
As I'm not involved in the development side of things at all, I have no idea what goes on with that aspect of things, but as a user, I appreciate your contributions so far and it's obvious a lot of work went into this. Hopefully cooler heads prevail all around and the work you've done isn't wasted.
RE: [New Feature] Movie version - CrystalP - 2023-12-20
(2023-12-20, 00:36)thezoggy Wrote: I turned the "Ignore different video versions on scan" option on, and when scanning the movie to library from videos source folder it still gives me the prompt about different movie version.More information would be needed for this. The setting works fine here and applies to the scan on start, update library, json-rpc with or without path. Looking at the code it doesn't look like a path was missed.
Restarted kodi, tried another movie and still got it.
I don't know if the option to disable the prompt is bugged or just does not apply during the videos>source>folder - scan to library context menu?
RE: [New Feature] Movie version - malvinas2 - 2023-12-20
(2023-12-20, 04:22)XODIDOX Wrote: My statement https://forum.kodi.tv/showthread.php?tid=337992&pid=2796635The entire way this feature has been implemented is a prime example for a textbook on database design and software architecture in general.
Once the dust has settled after Omega is published and the members involved have recovered a bit, a lessons-learned paper would be extremely interesting. And yes, I'm totally serious about this.
RE: [New Feature] Movie version - RaptorCentauri - 2023-12-21
With the original developer seemingly dropping off this project, what does that mean for future progress? Is it dead in the water or can we still expect development to continue with other contributors?
RE: [New Feature] Movie version - scott967 - 2023-12-21
Q based on nightly 20231219 Estuary:
1. When versions are set in videos window you can focus a movie with versions. The right panel and also<i>nfo movieinfo dialog it isn't clear which version stream details are being shown, nor is there any apparent way to show movieinfo for other than the "base" version (I'm assuming the base as I don't see any indication of which version the info dialog is showing) . Am I missing something, is it an estuary skin feature, or just not available?
2. If I hit <p>lay on a versioned movie, I get the selectvideoversion dialog and select a version for play. During play if I open the videoplaylist there's no indication of which version is playing (the stream details are correct so that's good.)
scott s.
.
RE: [New Feature] Movie version - Hitcher - 2023-12-21
1. It should show the details of the default version.
RE: [New Feature] Movie version - ashlar - 2023-12-22
(2018-12-01, 15:54)XODIDOX Wrote:It's really, really sad to see this happening. This is not the first time that I think Kodi would need a person dedicated to managing relationship with up and coming developers. I don't understand if the insult has been deleted but using the provided link does not show it. Whoever wrote that should excuse themselves to xodidox, as I don't think that is conducive to new developers being attracted to the project nor that it is in any way aligned to what the overall spirit of Kodi development has been throughout the years.I've reached the end of my patience.
With several thousand hours of work for this, and waited three weeks for a single PR (24148 (PR)) to fix some issues of this feature, this is what I got:
Quote:At the end it is your decision, but please don’t expect my approval for this PR in this state.
Am I begging for merging a PR? Do I need mercy from Kodi team to contribute? Do I own Kodi team anything, so I need to be treated like this? I really wanted to contribute to Kodi, as it's a very useful software. I even ignored this classic "f**k off" reply to me from a Kodi team member during a technical discussion for this feature (https://github.com/xbmc/xbmc/pull/14972#discussion_r1375140477):
Quote:f**k off, and don't waste our time.
As a top IT company employee for nearly two decades, I'v never been insulted like this. With constantly insulating I received for my contribution, I'm really tired:
Quote:Looking at this PR, I’m honestly asking myself why we need a shitload of new video database functionality to fix a simple refresh of data.
Enough is enough!
It's a pity to waste several thousand hours of work for a feature that many people want. But without even basic respect for me, it's meaningless to have this feature at all.
Kodi team, please keep your dignity, delete all of my code from your code base, and never use my code and ideas for this feature in your code base.
RE: [New Feature] Movie version - teriyaki - 2023-12-22
(2023-12-22, 18:39)ashlar Wrote:(2018-12-01, 15:54)XODIDOX Wrote:It's really, really sad to see this happening. This is not the first time that I think Kodi would need a person dedicated to managing relationship with up and coming developers. I don't understand if the insult has been deleted but using the provided link does not show it. Whoever wrote that should excuse themselves to xodidox, as I don't think that is conducive to new developers being attracted to the project nor that it is in any way aligned to what the overall spirit of Kodi development has been throughout the years.I've reached the end of my patience.
With several thousand hours of work for this, and waited three weeks for a single PR (24148 (PR)) to fix some issues of this feature, this is what I got:
Quote:At the end it is your decision, but please don’t expect my approval for this PR in this state.
Am I begging for merging a PR? Do I need mercy from Kodi team to contribute? Do I own Kodi team anything, so I need to be treated like this? I really wanted to contribute to Kodi, as it's a very useful software. I even ignored this classic "f**k off" reply to me from a Kodi team member during a technical discussion for this feature (https://github.com/xbmc/xbmc/pull/14972#discussion_r1375140477):
Quote:f**k off, and don't waste our time.
As a top IT company employee for nearly two decades, I'v never been insulted like this. With constantly insulating I received for my contribution, I'm really tired:
Quote:Looking at this PR, I’m honestly asking myself why we need a shitload of new video database functionality to fix a simple refresh of data.
Enough is enough!
It's a pity to waste several thousand hours of work for a feature that many people want. But without even basic respect for me, it's meaningless to have this feature at all.
Kodi team, please keep your dignity, delete all of my code from your code base, and never use my code and ideas for this feature in your code base.
I don't know who xodidox was quoting and what prompted the offensive responses but regardless it's a bad look for Kodi. How many times have we heard Kodi developers are thinly numbered unpaid volunteers, and more help is welcome? Seeing newcomers being treated that way is not an attractive quality making people want to become part of the team. Most people don't know the full story, nor will they care, nor should they; Everyone's capable of acting like adults with baseline mutual respect for one another. You don't have to be best friends or agree on everything but be civil, if not for `yourself` then the greater good of the entire Kodi community. It would be great if after a cooling off, whatever this conflict was can be left in the rear view and interested new developers aren't turned off and given reason to not bother.
I agree Ashlar, it's really really sad to see when things like this happen...