Kodi Community Forum
Disc Art - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Aeon MQ (https://forum.kodi.tv/forumdisplay.php?fid=68)
+---- Thread: Disc Art (/showthread.php?tid=346924)

Pages: 1 2 3 4


RE: Disc Art - mrrust - 2020-02-27

(2020-02-27, 04:57)Karellen Wrote:
(2020-02-27, 02:57)mrrust Wrote: I did the xml and put it in the userdata folder. Still won't show the disc art
Ok. First it is discart, not disc art. I want to make sure you have that right in case you have also named the file disc art.png which is wrong.

Provide the following...
1. Screenshot of a movie folder so I can see all the contents of the folder
2. A Debug Log which captures you scanning the movie into the library
3. If you go to Choose Art can you see any artwork attached? The image below is from another skin, but should work the same.

Image 
I was referring literally to the disc art in general, like two words. I wasn't talking about the file in specific. I'm a designer, I'm not advanced in coding and such, my area of specialty is in a different field, thus, I'm trying this to work for my System to be top notch in aesthetics. So please bear with me and be patient. of course my file name doesn't have a space, as you'll note in the picture.

1. https://www.dropbox.com/s/m9rabpvangq5sts/Screen%20Shot%202020-02-26%20at%207.31.56%20PM.png?dl=0
2. https://paste.kodi.tv/cipisokige.kodi
3. I can see artwork attached from the online source, I'm using jailbreak as an example, in the first window it doesn't list discart, if I go back it shows a menu with discarts but for a different album:

https://www.dropbox.com/s/g7g45mdh7zdq73d/Screen%20Shot%202020-02-26%20at%207.43.44%20PM.png?dl=0

https://www.dropbox.com/s/7923qak9hafvtke/Screen%20Shot%202020-02-26%20at%207.44.02%20PM.png?dl=0

https://www.dropbox.com/s/jhy9gcok6tmvwti/Screen%20Shot%202020-02-26%20at%207.45.23%20PM.png?dl=0

I found an advanced settings window I hadn't seen before, everything seems in order:

https://www.dropbox.com/s/v3qwdxs467wm2ma/Screen%20Shot%202020-02-26%20at%207.43.11%20PM.png?dl=0


RE: Disc Art - Karellen - 2020-02-27

Ok, thanks.

A couple of problems...

1. Your advancedsettings.xml file is not loaded. If you look at line 25 of the Debug Log you provided, you will see the error.
2. You have numerous Banned Add-ons (wiki) installed. You will need to remove these from your system and provide a new log before we can assist you further. They are the orange entries in the log.


RE: Disc Art - black_eagle - 2020-02-27

I have written a mini guide on using art with box-sets here. @Karellen feel free to use any/all of it in the wiki if you like Smile

@Wanilton There is no need to be using that script for any of the music art where art has been assigned by the user already.  I'd respectfully suggest that it's only used as a fall-back as ListItem/Player.Art(thumb/discart) should already contain the correct art urls.

EDIT - Screen shots showing disc art (assigned by following my guide) in Aeon MQ8

Image

Image


RE: Disc Art - Karellen - 2020-02-27

(2020-02-27, 10:10)black_eagle Wrote: Karellen feel free to use any/all of it in the wiki if you like
Thanks. In the next couple of days I will add a link in the Artwork page of the wiki and when we are closer to official release for v19 I will add more detail. https://kodi.wiki/view/Music_artwork

I like the mini guide, but maybe a bit more emphasis on using the advancedsettings.xml method, otherwise users may think the Choose Art method is the only way and may be too difficult to add multiple pieces of artwork via choose art?


RE: Disc Art - black_eagle - 2020-02-27

(2020-02-27, 11:10)Karellen Wrote: maybe a bit more emphasis on using the advancedsettings.xml method, otherwise users may think the Choose Art method is the only way and may be too difficult to add multiple pieces of artwork via choose art?

Yeah that's a good point.  I can use the section of my own AS file to show how to do it.  It's a much easier way to add in multiple items, especially when I have an 18 disc set that has individual covers.


RE: Disc Art - defleppard - 2020-02-27

In my case, it is a losing fight with this issue. But mainly with compilations and bootlegs made by me. In the folder of my albums I have pngs named as discart, cdart and disc. The strangest thing is that in commercial albums the image of the disc appears well.


RE: Disc Art - mrrust - 2020-02-27

(2020-02-27, 06:09)Karellen Wrote: Ok, thanks.

A couple of problems...

1. Your advancedsettings.xml file is not loaded. If you look at line 25 of the Debug Log you provided, you will see the error.
2. You have numerous Banned Add-ons (wiki) installed. You will need to remove these from your system and provide a new log before we can assist you further. They are the orange entries in the log.
Ok, I fixed the advancedsettings.xml   I got music disc arts to work!

On the other hand, movies are not showing the disc art. I tried with discart.png and disc.png (it's established as discart in the advancesettings xml)


RE: Disc Art - mrrust - 2020-02-27

(2020-02-27, 21:57)mrrust Wrote:
(2020-02-27, 06:09)Karellen Wrote: Ok, thanks.

A couple of problems...

1. Your advancedsettings.xml file is not loaded. If you look at line 25 of the Debug Log you provided, you will see the error.
2. You have numerous Banned Add-ons (wiki) installed. You will need to remove these from your system and provide a new log before we can assist you further. They are the orange entries in the log.
Ok, I fixed the advancedsettings.xml   I got music disc arts to work!

On the other hand, movies are not showing the disc art. I tried with discart.png and disc.png (it's established as discart in the advancesettings xml) 
I did a clean install: https://paste.kodi.tv/ozoweroyer.kodi


RE: Disc Art - jasn - 2020-02-29

@mrrust , going back to your OP, did you get your Music Fullscreen in to display local discart and not from the internet?  I am struggling to make that work.  Local discart.png displays fine on other screens, just not on Fullscreen.  If there is no discart (or clearlogo) Fullscreen will not display any discart at all.

@latts9923, can you shed some light on how to prefer local discart vs internet for Music Fullscreen?

Thx


RE: Disc Art - mrrust - 2020-03-01

(2020-02-29, 19:08)jasn Wrote: @mrrust , going back to your OP, did you get your Music Fullscreen in to display local discart and not from the internet?  I am struggling to make that work.  Local discart.png displays fine on other screens, just not on Fullscreen.  If there is no discart (or clearlogo) Fullscreen will not display any discart at all.

@latts9923, can you shed some light on how to prefer local discart vs internet for Music Fullscreen?

Thx

Yes it worked with the advancedsettings.xml  file. Now that you mention the music screen, I haven't checked.


RE: Disc Art - jasn - 2020-03-01

I'm likely just posting for myself as a personal preference, but I found that in MusicVisualisation.xml under Layout 3 the following code to display discart (similar code for other layouts):
Code:
<control type="image">                    
                    <left>50</left>
                    <top>-80</top>
                    <width>632</width>
                    <height>450</height>
                    <aspectratio align="center" aligny="center">keep</aspectratio>
                    <texture diffuse="cdart_diffuse.png" background="true">$VAR[media_discart]</texture>
                    <include>animation_cdart</include>
                    <visible>String.IsEqual(skin.string(visdiscart),always) | [String.IsEqual(skin.string(visdiscart),ifavailable) + !String.IsEmpty(Player.Art(discart))]
                | [String.IsEqual(skin.string(visdiscart),ifavailable) + !String.IsEmpty(Window(home).Property(SkinHelper.Player.Art.DiscArt))]</visible>
                </control>

From the last line I've edited out code to seek discart from the web:
Code:
| [String.IsEqual(skin.string(visdiscart),ifavailable) + !String.IsEmpty(Player.Art(discart))]
, leaving:
Code:
<control type="image">                    
                    <left>50</left>
                    <top>-80</top>
                    <width>632</width>
                    <height>450</height>
                    <aspectratio align="center" aligny="center">keep</aspectratio>
                    <texture diffuse="cdart_diffuse.png" background="true">$VAR[media_discart]</texture>
                    <include>animation_cdart</include>
                    <visible>String.IsEqual(skin.string(visdiscart),always) | [String.IsEqual(skin.string(visdiscart),ifavailable) + !String.IsEmpty(Window(home).Property(SkinHelper.Player.Art.DiscArt))]</visible>
                </control>

Now I display discart in Music Fullscreen only if I have it in my album folder.  Perhaps I'm missing a setting to do this already?  I recall a setting, somewhere in the maze of Kodi, Skin and Addon settings, the ability to favor online vs local artwork?  Could not find it yesterday.


RE: Disc Art - black_eagle - 2020-03-01

This bit Player.Art(discart)) is art coming from Kodi's databases.  So you've removed the bit that says 'Use Kodi supplied art if there is some' and left Window(home).Property(SkinHelper.Player.Art.DiscArt) which I believe will get local art first but then does look on the internet for art too.

Anyway, a better way to do it is to change the definition of $VAR[media_discart] so that it gets local art, with a fallback to a generic disc if not available.  Then you know you will always have something to display and don't need a visibility condition to decide if you have art or not.


RE: Disc Art - jasn - 2020-03-01

Thanks @black_eagle.  I'm not all surprised that my approach is clumsy.  Not sure how or why it works, but so far it does.  However I tried, I could not get the fullscreen display to show local discart.  In some cases it didn't display anything, and in others it displayed a different disc than what is in my folder. 

Changing, no less locating the definitions for $VAR[media_discart] is above my elementary skills, however.  Perhaps @latts9923 will weigh in.

Great tagline, BTW.


RE: Disc Art - black_eagle - 2020-03-01

Haha, that's because when I first moved to Linux, I kept getting things wrong and breaking it.  Sometimes really badly too.

The variable definition will be in either includes_variables.xml or Variables.xml or some other similar name. 

Example definition from my own skin.
xml:
<variable name="PlayerInfoDiscArtVar">
        <value condition="!String.IsEmpty(Player.Art(discart))">$INFO[Player.Art(discart)]</value>
        <value condition="!String.IsEmpty(Player.Art(album.discart))">$INFO[Player.Art(album.discart)]</value>
        <value condition="!String.IsEmpty(Window(Visualisation).Property(srh.RealCDArt))">$INFO[Window(Visualisation).Property(srh.RealCDArt)]</value>
        <value>$INFO[Player.Folderpath]/cdart.png</value>
        <value>$INFO[Player.Folderpath]cdart.png</value>
    </variable>

When it sets the value, it falls down through all the value conditions until it meets one that works, then it stops.  So if Player.Art(discart) has something in it, it will use that and stop looking for a value.  If not, it will try the next line etc etc. The last two attempt to get an old style cdart from the directory of the album.  Dunno if that works actually as virtually all my stuff has discart added to the library.


RE: Disc Art - jasn - 2020-03-01

That helps a lot @black_eagle thanks very much.  I've played around with the media_discart order in the IncludesVarialbles.xml and see partial improvement (using local discart when there doesn't appear to be any online), but it's still using online discart if available over local discart.  Will play around a bit more in the next day or two.  Do I also need to rescan my db, texture or thumbnails?