+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: DialogMuteBug.xml nightly problems... (/showthread.php?tid=107553)
Pages:
1
2
DialogMuteBug.xml nightly problems... - liquidskin76 - 2011-08-12
Hi,
I've come across a problem where DialogMuteBug.xml doesn't appear to working in the most recent nightlies? It's the same on confluence and all other nightly compatible skins.
You turn the volume right down and DialogMuteBug.xml doesn't kick in.
I've tested on pre Aug 2nd builds and the problem is still there so not related to the post Aug 2nd build problems (http://forum.xbmc.org/showthread.php?tid=107394).
In the debug log, 'Window Init (DialogVolumeBar.xml)' and 'Window Deinit (DialogVolumeBar.xml)' appear as normal, however no entries for DialogMuteBug.xml appear.
Any thoughts?
Thanks
- `Black - 2011-08-12
Yes, noticed the same problem here. Volume down to -60.0 doesn't trigger MuteBug anymore... if mute action is executed manually, mute bug does show and volume is down to -60.0.
- pieh - 2011-08-12
seems like task for me ;(
- liquidskin76 - 2011-08-12
pieh Wrote:seems like task for me ;(
Good man!! Thanks for sorting the other skin stuff by the way!
- pieh - 2011-08-12
hmm, this is not necessarily bug: Montellese docoupled volume from mute state (234 (PR)). This is perfectly sane and valid change but at this point we need to consider what to do when volume drops to -60dB on GUI side:
- show MuteBug?
- keep showing VolumeBar with value set to minimum
- don't do anything (current behaviour)
- Jezz_X - 2011-08-12
quiet simple if there is no audio output its Muted
so if -60dB = no output then show the mute bug
- liquidskin76 - 2011-08-12
How about doing away with dialogmutebug.xml, and just use dialogvolumebar.xml with visibility conditions, like 'IntegerGreaterThan(player.volume,-60)' = show mute icon?
I never understood what the point of having two xml's for volume related dialog was?
Cheers guys
- jmarshall - 2011-08-13
On most TV sets if you put the volume to zero you don't get the mute icon. This is advantageous on them ofcourse as you may be playing the audio through receiver.
Not sure it's advantageous on XBMC though... Seems to me it's better to display it.
Cheers,
Jonathan
- Mudislander - 2011-08-13
jmarshall Wrote:Not sure it's advantageous on XBMC though... Seems to me it's better to display it.
Mmm. I had a problem a couple of days ago - absolutly no sound, struggled for ages to get it right. I use a Amp for sound so remote is configured for that. Someone in my house had muted the XBMC machine via keyboard. Guess if the mute icon had been up, I would have had way less stress.
- liquidskin76 - 2011-08-13
liquidskin76 Wrote:How about doing away with dialogmutebug.xml, and just use dialogvolumebar.xml with visibility conditions, like 'IntegerGreaterThan(player.volume,-60)' = show mute icon?
I never understood what the point of having two xml's for volume related dialog was?
Cheers guys
jmarshall Wrote:Not sure it's advantageous on XBMC though... Seems to me it's better to display it.
Cheers,
Jonathan
Mudislander Wrote:Mmm. I had a problem a couple of days ago - absolutly no sound, struggled for ages to get it right. I use a Amp for sound so remote is configured for that. Someone in my house had muted the XBMC machine via keyboard. Guess if the mute icon had been up, I would have had way less stress.
Yeah, totally agree we need a mute icon.
From a skinning standpoint though, not sure we need two xml's to control volume icons, hence my suggestion regarding doing away with dialogmutebug.xml.
Thanks
- pieh - 2011-08-13
right, for now I'll fix that MuteBug
if you want discuss merging VolumeBar with MuteBug - please, create new topic for it with proper description
- liquidskin76 - 2011-08-13
pieh Wrote:right, for now I'll fix that MuteBug
if you want discuss merging VolumeBar with MuteBug - please, create new topic for it with proper description
Ok, cheers!
- pieh - 2011-08-13
quick fix https://github.com/xbmc/xbmc/commit/48f1ffdaf8babc33682e6d62331dc0c5b8e0e5af
- Jeroen - 2011-08-14
My mute icon is appearing again, but it seems that using Player.Muted as a condition doesn't work?
- pieh - 2011-08-14
Right, this is another consequence of decoupling volume nad mute status - I'll wait for Montellese before "fixing" (changing) it - don't want to step on his toes here.
for now old behaviour can be accomplished by [ Player.Muted | !IntegerGreaterThan(Player.Volume,-60) ] (didn't test it)