Kodi Community Forum
NBA International League Pass - Add-on - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Video Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=154)
+---- Thread: NBA International League Pass - Add-on (/showthread.php?tid=124716)



RE: NBA International League Pass - Add-on - ace1024 - 2020-12-29

(2020-12-28, 18:54)STM0O0 Wrote:
(2020-12-23, 11:41)kokan Wrote:
(2020-12-23, 10:32)STM0O0 Wrote:  
Hi Kokan

I've fixed it myself. In games.py, I changed line 239 to:
if vars.show_scores:
    name += " %s (%s) vs %s (%s)" % (visitor_name, vr, host_name, hr)
else:
    name += " %s vs %s" % (visitor_name, host_name)

I've tried to put this on the github (should be noted as a pull request now). Would of course appreciate if this adjustment was included in later releases by you.
I'm not very advanced in Python, but I'd be open to helping you maintain the addon if you want. Though I currently have no idea how you debug this stuff on your pc.

Thanks!

Is it possible for you to upload the zip file? I would be great to use your amendments.


RE: NBA International League Pass - Add-on - kokan - 2020-12-29

(2020-12-24, 07:45)chalbersma Wrote:
(2020-12-24, 00:49)kokan Wrote:
(2020-12-23, 19:42)chalbersma Wrote: Will this work its way back to the main repository or do we need to install this zip by hand?
It depends on what you consider to be the main repository. If you think of https://github.com/maxgalbu/xbmc.plugin.video.nba, we are still waiting for @maxgalbu to merge this PR: https://github.com/maxgalbu/xbmc.plugin.video.nba/pull/92.

https://kodi.tv/addon/plugins-video-add-ons/nba-league-pass

This one is available to essentially every install of kodi.
As long as there is no feedback from @maxgalbu, always install the latest (from my fork) by hand.


RE: NBA International League Pass - Add-on - kokan - 2020-12-29

The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.


RE: NBA International League Pass - Add-on - morph78 - 2020-12-29

(2020-12-29, 08:15)kokan Wrote: The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.
Much appreciated thank you


RE: NBA International League Pass - Add-on - Kodrnusa - 2020-12-29

Can someone post the zip here. Thank you in advance.


RE: NBA International League Pass - Add-on - belgar - 2020-12-29

(2020-12-29, 10:01)Kodrnusa Wrote: Can someone post the zip here. Thank you in advance.

https://github.com/ivankokan/xbmc.plugin.video.nba/archive/master.zip


RE: NBA International League Pass - Add-on - belgar - 2020-12-29

(2020-12-29, 08:15)kokan Wrote: The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.

Thank you very much for your efforts.


RE: NBA International League Pass - Add-on - STM0O0 - 2020-12-29

(2020-12-29, 06:42)ace1024 Wrote:
(2020-12-28, 18:54)STM0O0 Wrote:
(2020-12-23, 11:41)kokan Wrote:  
Hi Kokan

I've fixed it myself. In games.py, I changed line 239 to:
if vars.show_scores:
    name += " %s (%s) vs %s (%s)" % (visitor_name, vr, host_name, hr)
else:
    name += " %s vs %s" % (visitor_name, host_name)

I've tried to put this on the github (should be noted as a pull request now). Would of course appreciate if this adjustment was included in later releases by you.
I'm not very advanced in Python, but I'd be open to helping you maintain the addon if you want. Though I currently have no idea how you debug this stuff on your pc.

Thanks!

Is it possible for you to upload the zip file? I would be great to use your amendments.

Kokan has added a similar fix to his latest version, so you can just get it there.

@kokan: thanks!


RE: NBA International League Pass - Add-on - STM0O0 - 2020-12-29

I made a new version using the last version by kokan that makes some changes to the archived games menu. Always found the 'this week'/'last week' folders a bit annoying, so I added some alternatives that can be activated in the settings menu of the addon. Basically: more gamedays per folder and more flexible options for people who often run more than a couple of days behind. I'm not sure if kokan will want to add it to his repo, but consider it a suggestion that I'll maintain if necessary.
More info: https://github.com/ivankokan/xbmc.plugin.video.nba/pull/13
Who wants, can download it here: https://github.com/stevmert/xbmc.plugin.video.nba


RE: NBA International League Pass - Add-on - tnkrer - 2020-12-30

(2020-12-29, 08:15)kokan Wrote: The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.
Thanks Kokan!
Does this mean, for live games, we have to start before the game starts? After the game starts, the only options are beginning / go live and those do not work Sad


RE: NBA International League Pass - Add-on - kokan - 2020-12-30

(2020-12-30, 05:45)tnkrer Wrote:
(2020-12-29, 08:15)kokan Wrote: The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.
Thanks Kokan!
Does this mean, for live games, we have to start before the game starts? After the game starts, the only options are beginning / go live and those do not work Sad

No. Go LIVE works. Start from Beginning currently does not, and it is questionable whether such thing is feasible anymore.


RE: NBA International League Pass - Add-on - tnkrer - 2020-12-30

(2020-12-30, 05:55)kokan Wrote:
(2020-12-30, 05:45)tnkrer Wrote:
(2020-12-29, 08:15)kokan Wrote: The fix is available within the master branch on my fork, enjoy the Live Games!

Do not forget to update the unified Show records and scores setting.

Start from Beginning / Go LIVE will be addressed accordingly very soon.
Thanks Kokan!
Does this mean, for live games, we have to start before the game starts? After the game starts, the only options are beginning / go live and those do not work Sad

No. Go LIVE works. Start from Beginning currently does not, and it is questionable whether such thing is feasible anymore.

OK, Thanks. I need to figure out why Go LIVE does not work for me Sad Will look into debug logs. If I cannot figure out, will post logs


RE: NBA International League Pass - Add-on - muthuh - 2020-12-30

(2020-12-23, 01:37)kokan Wrote: Hi, The fix is available within the master branch on my fork, enjoy the season!

You are one of my favorite human beings.


RE: NBA International League Pass - Add-on - tnkrer - 2020-12-31

(2020-12-30, 06:22)tnkrer Wrote:
(2020-12-30, 05:55)kokan Wrote:
(2020-12-30, 05:45)tnkrer Wrote: Thanks Kokan!
Does this mean, for live games, we have to start before the game starts? After the game starts, the only options are beginning / go live and those do not work Sad

No. Go LIVE works. Start from Beginning currently does not, and it is questionable whether such thing is feasible anymore.

OK, Thanks. I need to figure out why Go LIVE does not work for me Sad Will look into debug logs. If I cannot figure out, will post logs

Its fireTV and kodi 18.5 and it seems that the error is - 
2020-12-30 19:29:20.350 T:10230   ERROR: AddOnLog: InputStream Adaptive: Unsupported encryption method:
Don't know what to do with that next Sad .. Anyone with similar problems?


RE: NBA International League Pass - Add-on - STM0O0 - 2020-12-31

Hi everyone,

I made a newer version of my fork that now also allows the automatic generation of playlists of a range of gamedays for continuous playback. They can be enabled and personalized in the settings menu. A little more info I put here, otherwise just experiment or ask...

Info: https://github.com/ivankokan/xbmc.plugin.video.nba/pull/13
Download: https://github.com/stevmert/xbmc.plugin.video.nba
(I have only figured out how to make small cosmetic changes and similar to make the addon more to my own liking, so I'll probably be of little help with functionality fixes or function requests)

Happy new year! On to a better year...