+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Includes for home.xml (/showthread.php?tid=132641)
Includes for home.xml - phil65 - 2012-05-29
another one...
we had to apply this commit https://github.com/BigNoid/Aeon-Nox/commit/cd90b3a48deb3ab12173a519ad3b16a6548da191
to avoid that the include got executed several times (and resets the settings by doing this)
we´re using
Code:
<include condition="!Skin.HasSetting(Nox.firstrun)">AutoConfig</include>can be replicated (at least on my machiine) when starting nox 3.0.0 for the first time (don´t know for sure if this always happens), entering settings, changing color for settings, and returning to home.
you can see that the include onloads got triggered when you see the notification pop-up.
i had a similar problem before, also for home window. seems that the include conditions do not get checked properly there in all cases.
hope that´s clear enough. if not, ask for more info.
thx
RE: Includes for home.xml - phil65 - 2012-06-03
bump. anyone?
RE: Includes for home.xml - pieh - 2012-06-19
Finally got time to track issue here
@jmarshall
When we load skin, we test if loading Home.xml window is ok: https://github.com/xbmc/xbmc/blob/master/xbmc/Application.cpp#L1815 . This can actually cause several issues:
a) window will stay in memory and next time we will show it we won't resolve our includes as window is already loaded
b) it will trigger home's window <onload> actions (which technically is correct as we load that window, but I doubt anyone want that)
Also this test really checks only if Home.xml exist and if root element of that file is <window> - maybe add CGUIWindow::Test() method that will do just that, without really parsing and loading that window?
RE: Includes for home.xml - jmarshall - 2012-06-20
Probably just testing if Home.xml exists is enough.
RE: Includes for home.xml - pieh - 2012-07-02
fixed in https://github.com/xbmc/xbmc/commit/5096f9c4e17d4d12ed5bd1e1dd0680d47dc80541
RE: Includes for home.xml - phil65 - 2012-07-02
thx. greatly appreciated.