Supporting multiple image types - need input (test build inside)

Supporting multiple image types - need input (test build inside) - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Supporting multiple image types - need input (test build inside) (/showthread.php?tid=142589)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

RE: Supporting multiple image types - need input (test build inside) - Martijn - 2012-11-08

(2012-11-08, 01:17)MassIV Wrote: What i never understood is why seasons is done the way it is. On the one hand, yeah seasons is a step between show and episode. But i think it is better to send people straight to titles or episodes instead of seasons or a window to choose a genre. Most used = first place. To me it would make more sense to have the seasons list and episodes list in the same screen. In a dropdown, or side menu, like how Confluence starts PVR (directly visible), or a button with a popup. So seasons is just an extra on episodes. Just something that crossed my mind a few times.

please no.

RE: Supporting multiple image types - need input (test build inside) - MassIV - 2012-11-08

Angel

RE: Supporting multiple image types - need input (test build inside) - ronie - 2012-11-08

(2012-11-08, 01:17)MassIV Wrote: What i never understood is why seasons is done the way it is. On the one hand, yeah seasons is a step between show and episode. But i think it is better to send people straight to titles or episodes instead of seasons

you can skip the season list, if that's what you're after:
settings > videos > flatten tv shows

RE: Supporting multiple image types - need input (test build inside) - MassIV - 2012-11-08

No, i know that. A nice work around :p

RE: Supporting multiple image types - need input (test build inside) - jingai - 2012-11-08

(2012-11-08, 00:25)jmarshall Wrote: It was intentional, primarily because it's easy to change tvshow stuff - much harder to do so for seasons (no season info).

Ok. Well, if it's ever a possibility in the future, please consider it. In flattened lists it's particularly nice to have.

BTW, really appreciate all the work on this. Now I won't have to answer questions about squashed images every other day Tongue

RE: Supporting multiple image types - need input (test build inside) - Hitcher - 2012-11-08

(2012-10-30, 16:56)Hitcher Wrote: Working via the context menu but using the 'choose art' from video info sets the TV show images not season ones.

(2012-10-30, 22:46)jmarshall Wrote: Thanks - there's no official "season" support in the info dialog, so it doesn't really surprise me if it doesn't necessarily show up correctly - the context menu stuff will stay in either way, so not a problem IMO.

In that case can button 10 be disabled at season level to avoid any user confusion as to what image they're actually setting?

I tried this at skin level but Container.Content(seasons) isn't valid from the video info dialog.

RE: Supporting multiple image types - need input (test build inside) - Hitcher - 2012-11-13

ListItem.Art(season.poster) and ListItem.Art(season.banner) stopped working for video info dialog at season level recently (not sure when yet) but they still work at episode level.

RE: Supporting multiple image types - need input (test build inside) - jmarshall - 2012-11-14

This was deliberate, yes. When you go to Video Info at the season level you actually just get the show information (it's labelled TV Show Information in the UI for this reason).

RE: Supporting multiple image types - need input (test build inside) - Hitcher - 2012-11-14

OK, but seeing as ListItem.Art(tvshow.poster) & ListItem.Art(tvshow.banner) are available at season level, and ListItem.Art(banner) & ListItem.Art(poster) show the actual season images, shouldn't it also be this way in the video info dialog?

As it is now ListItem.Art(banner) & ListItem.Art(poster) then show the tvshow images and ListItem.Art(tvshow.poster) and ListItem.Art(tvshow.banner) are empty.

Hope that makes sense.

Thanks.

RE: Supporting multiple image types - need input (test build inside) - jmarshall - 2012-11-14

The video info dialog does not support seasons. When you go to Information it's the TV Show Information. It's always been that way, just there was a bug that didn't correctly update the type of item from season->show. i.e. it worked by accident, but was inconsistent, in that the Choose Art stuff updated the art of the tvshow, not the season (while showing art for the season instead of show).

Cheers,
Jonathan

RE: Supporting multiple image types - need input (test build inside) - nessus - 2012-11-14

JM when you have the time can you give a look on this ?

Cheers
Nessus

RE: Supporting multiple image types - need input (test build inside) - Hitcher - 2012-11-14

@jonathan Understood, thanks.

@nessus As I said in that thread they're exactly the same and still working fine for me.

RE: Supporting multiple image types - need input (test build inside) - `Black - 2012-11-14

(2012-11-14, 19:42)Hitcher Wrote: @nessus As I said in that thread they're exactly the same and still working fine for me.

Nessus is correct, LatestEpisode.*.ShowThumb is empty now which should not be the case I guess. Problem could be that tv shows have no thumb, so item->GetArt("tvshow.thumb") has to be item->GetArt("tvshow.poster").

RE: Supporting multiple image types - need input (test build inside) - Hitcher - 2012-11-14

Sorry, I thought he meant all images.

RE: Supporting multiple image types - need input (test build inside) - jmarshall - 2012-11-15

I'll add a fallback from tvshow.thumb -> tvshow.poster.