Kodi Community Forum
Release CU LRC Lyrics - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Lyrics Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=146)
+---- Thread: Release CU LRC Lyrics (/showthread.php?tid=147340)



RE: CU LRC Lyrics - smrtrock - 2019-09-02

(2019-09-02, 18:07)ronie Wrote: could you please check if BeautifulSoup4 is enabled here:
Settings > System > Addons > Manage dependencies

Checked and yes it is enabled, is that the offender?


RE: CU LRC Lyrics - aktarus - 2019-09-02

Hello,

This script is very good to retreive lyrics ...

But, is it possible to "embeded" founded lyrics in the mp3 file for the next use ...

It sould be very useful to save the founded lyrics directly in the tag ..

MERCI Smile


RE: CU LRC Lyrics - Karellen - 2019-09-03

@aktarus

I cannot answer your question about embedding lyrics (and I highly doubt you could) but there is an option to save lyrics alongside the song file...

Image

Image


RE: CU LRC Lyrics - ronie - 2019-09-03

(2019-09-02, 18:15)smrtrock Wrote: Checked and yes it is enabled, is that the offender?

nope, it should be enabled.
i have no other idea why you'd get that error...


RE: CU LRC Lyrics - ronie - 2019-09-03

(2019-09-02, 21:58)aktarus Wrote: But, is it possible to "embeded" founded lyrics in the mp3 file for the next use ...

there's no such functionality in the addon.


RE: CU LRC Lyrics - scott967 - 2019-10-14

Python3 ver of CU LRC lyrics for Kodi 19 nightlies?  I was working through some errors but not sure how to fix importing urllib2?

scott s.
.


RE: CU LRC Lyrics - ronie - 2019-10-14

(2019-10-14, 23:30)scott967 Wrote: Python3 ver of CU LRC lyrics for Kodi 19 nightlies?

https://gitlab.com/ronie/script.cu.lrclyrics/tree/py3

will submit it to the repo asap


RE: CU LRC Lyrics - scott967 - 2019-10-15

(2019-10-14, 23:45)ronie Wrote:
(2019-10-14, 23:30)scott967 Wrote: TPython3 ver of CU LRC lyrics for Kodi 19 nightlies?

https://gitlab.com/ronie/script.cu.lrclyrics/tree/py3

will submit it to the repo asap 

Thanks.  I though this was on gitlab but didn't take time to find it. 
I see what you did with urllib2.  Now I just have about 4 other skin dependencies that don't work.  Mostly could work with Kodi-six I think, except for some syntax errors which can be find/replace.

scott s.
.


RE: CU LRC Lyrics - ronie - 2019-10-15

yeah, it's going to be a bumpy ride for a while


RE: CU LRC Lyrics - popeye2468 - 2019-10-16

Hi I love this addon but am unable to use it due to performnce issues it causes with kodi 18

my question is has this been adressed and fixed?

thanks


RE: CU LRC Lyrics - Karellen - 2019-10-16

What performance issues?


RE: CU LRC Lyrics - ronie - 2019-10-16

(2019-10-16, 21:19)popeye2468 Wrote: Hi I love this addon but am unable to use it due to performnce issues it causes with kodi 18

my question is has this been adressed and fixed?

thanks

nope, i've tried to reproduce it several times, but i can not.
i've also double checked all the code and still haven't found a clue what it is causing issues for some.


@Karellen : https://forum.kodi.tv/showthread.php?tid=147340&pid=2850634#pid2850634


RE: CU LRC Lyrics - scott967 - 2019-10-17

(2019-10-15, 11:34)ronie Wrote: yeah, it's going to be a bumpy ride for a while

Got auto-updated to ver 6.0.0.  Script produced error in minilyrics/lyricsScraper.py line 67
Code:
result = '\x02' + chr(magickey) + '\x04\x00\x00\x00' + str(hasheddata) + bytearray(encddata).decode('utf-8')

error is TypeError: can only concatenate str (not "bytearray") to str



which I guess you maybe shouldn't be doing str(hasheddata)?  Not sure what the logic is doing but I'm guessing this should all be byte data with any text utf-8 encoded?

scott s.
.


RE: CU LRC Lyrics - popeye2468 - 2019-10-17

(2019-10-16, 22:30)ronie Wrote:
(2019-10-16, 21:19)popeye2468 Wrote: Hi I love this addon but am unable to use it due to performnce issues it causes with kodi 18

my question is has this been adressed and fixed?

thanks

nope, i've tried to reproduce it several times, but i can not.
i've also double checked all the code and still haven't found a clue what it is causing issues for some.


@Karellen : https://forum.kodi.tv/showthread.php?tid=147340&pid=2850634#pid2850634

I have installed your latest version from the gitlab and have yet to experience the issues I had before


RE: CU LRC Lyrics - ronie - 2019-10-17

(2019-10-17, 03:53)scott967 Wrote:
(2019-10-15, 11:34)ronie Wrote: yeah, it's going to be a bumpy ride for a while

Got auto-updated to ver 6.0.0.  Script produced error in minilyrics/lyricsScraper.py line 67
Code:
result = '\x02' + chr(magickey) + '\x04\x00\x00\x00' + str(hasheddata) + bytearray(encddata).decode('utf-8')

error is TypeError: can only concatenate str (not "bytearray") to str



which I guess you maybe shouldn't be doing str(hasheddata)?  Not sure what the logic is doing but I'm guessing this should all be byte data with any text utf-8 encoded?

scott s.

all true :-)
will have a look and fix...