Kodi Community Forum
Release CU LRC Lyrics - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Lyrics Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=146)
---- Thread: Release CU LRC Lyrics (/showthread.php?tid=147340)



RE: CU LRC Lyrics - Mr. V - 2019-11-23

@ronie

Using WIP Madnox 2.0;
After further testing with the repo version i am having a hard time to make this bug happen again.

The only difference now is the code is more optimized and the system is using Windows version 1903 and nvidia drivers 436.48.

Previously my solution was to set up a Nvidia Custom 3d setting with texture filtering for performance and add <algorithmdirtyregions>0</algorithmdirtyregions> to the advanced settings.
These settings have been disabled for my testing.

Using Aeon Tajo and removing the code that disables the script;
I can reproduce the bug. I get a lower fps when entering and exiting fullscreen music. Takes a few tries and the fps dips, seems to happen more if a visualization is enabled, mainly milkdrop 2.

I am not seeing any performance difference between the repo version and your updated script.


Another issue i have found;
In the dialog button menu i use this code
Code:
<onclick>Dialog.Close(all,true)</onclick>
<onclick>ActivateWindow(Settings,return)</onclick>
If any dialogs are forced to close in the music viz screen it stops the script from working until i restart kodi.



EDIT
@ronie @manfeed
I have added you to Madnox 2.0 on github, if you wanted to see how the lyrics are working
https://github.com/mistervee/skin.madnox/invitations


RE: CU LRC Lyrics - ronie - 2019-11-30

(2019-11-23, 05:26)Mr. V Wrote: Another issue i have found;
In the dialog button menu i use this code
Code:
<onclick>Dialog.Close(all,true)</onclick>
<onclick>ActivateWindow(Settings,return)</onclick>
If any dialogs are forced to close in the music viz screen it stops the script from working until i restart kodi. 

thx, that one feels a bit like a shortcoming in kodi.
normally when you press 'back' to close a dialog, a signal will be send to the addon
but that does not happen in case 'dialog.close()' is used.

anyway, i've added a workaround for that in 5.7.2 (submitted to the repo last night).


i haven't been able to reproduce the gui fps drops anymore since 5.7.0,
i've tried the suggestions in the last couple of posts at least 50 times, but no problem occurs on my end.


RE: CU LRC Lyrics - Mr. V - 2019-12-01

(2019-11-30, 15:04)ronie Wrote:
(2019-11-23, 05:26)Mr. V Wrote: Another issue i have found;
In the dialog button menu i use this code
Code:
<onclick>Dialog.Close(all,true)</onclick>
<onclick>ActivateWindow(Settings,return)</onclick>
If any dialogs are forced to close in the music viz screen it stops the script from working until i restart kodi.   

thx, that one feels a bit like a shortcoming in kodi.
normally when you press 'back' to close a dialog, a signal will be send to the addon
but that does not happen in case 'dialog.close()' is used.

anyway, i've added a workaround for that in 5.7.2 (submitted to the repo last night).


i haven't been able to reproduce the gui fps drops anymore since 5.7.0,
i've tried the suggestions in the last couple of posts at least 50 times, but no problem occurs on my end.  

Thanks ronie for the update. I can report the dialog close is working now.

As for the stuttering, i can't find anyway to reproduce it now using Aeon Tajo. Not sure what is different from my previous tests?
Thanks for you help on this, i will consider it solved on my end.


RE: CU LRC Lyrics - manfeed - 2019-12-01

@ronie @Mr. V 

Happy to hear that you don't have drops in fps anymore, since that means other users might also be free of that issue. 

Unfortunately that's not my case, as you can see...



...anyway, thanks for your efforts, I totally understand that you can't fix what it's not broken in your end... maybe I'm the only one with the issue, so don't waste more time with this topic, I can put up with it  Wink

Thanks!


RE: CU LRC Lyrics - Karellen - 2019-12-07

Hi @ronie

An error in the log- line 2838... https://paste.kodi.tv/wejenutiwo.kodi


RE: CU LRC Lyrics - ronie - 2019-12-07

thx @Karellen, that's indeed a bug.
i'll submit a fixed version to the addon repo.


RE: CU LRC Lyrics - Karellen - 2019-12-25

Hi @ronie

Using v5.7.2, an error on line 939... https://paste.kodi.tv/dunanofiga.kodi

No lyrics were downloaded for that song and subsequent songs. Strange as it was working fine for a couple of hours prior to that. But I noticed that if I restart Kodi and skip that particular song, then lyrics are working again.

Also noticed that ocassionally when playing the first song of the session, the lyric text box pops up but the lyrics are not displayed. Need to stop and press play again, then lyrics are displayed correctly.


RE: CU LRC Lyrics - ronie - 2019-12-25

thanx again @Karellen 
i've fixed the error in v5.7.3 which should arrive on your doorstep within a day.

as for the random empty lyrics window, that is going to be hard to fix without a Debug Log, so if you ever manage to capture it in a log, please let me know.


RE: CU LRC Lyrics - Karellen - 2019-12-25

Thank you ronie Smile

Sure, when I capture it with a debug log, I'll submit it.


RE: CU LRC Lyrics - Karellen - 2019-12-31

(2019-12-25, 03:20)ronie Wrote: as for the random empty lyrics window, that is going to be hard to fix without a Debug Log, so if you ever manage to capture it in a log, please let me know.
Ok, caught it and able to replicate but I think it might be my fault as I am moving focus away from Kodi so I can work on something else while music is playing. Also caught an error on line 2170... https://paste.kodi.tv/lunadesaxu.kodi


RE: CU LRC Lyrics - ronie - 2020-01-06

it took me a while but i may have found the issue..
the addon failed to work properly when the music osd was opened directly after switching to the fullscreen visualisation window.
that would (in the end) also result in the crash at shutdown.

i've submitted a new version to the addon repo which tries to workaround the problem.


RE: CU LRC Lyrics - ciropom - 2020-01-20

Hello I have probably a dumb issue.. sorry if I'm not able to fix it myself.

Here is my debug log
https://paste.ubuntu.com/p/PtMzq4YCfy/

relevant code

20:05:57.960 T:548289321568   DEBUG: ADDON: cpluff: 'Plug-in script.cu.lrclyrics has been installed.'
20:05:58.562 T:548289321568   DEBUG: LocalizeStrings: loaded 47 strings from file /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/resources/language/resource.language.en_GB/strings.po
20:05:59.304 T:546987560480   DEBUG: CPythonInvoker(3, /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py): start processing
20:06:08.800 T:546987560480   DEBUG: CPythonInvoker(3, /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py): the source file to load is "/var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py"
20:06:09.054 T:546987560480   DEBUG: CPythonInvoker(3, /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py): setting the Python path to /var/lib/kodi/.kodi/addons/script.cu.lrclyrics:/var/lib/kodi/.kodi/addons/script.module.beautifulsoup4/lib:/var/lib/kodi/.kodi/addons/script.module.certifi/lib:/var/lib/kodi/.kodi/addons/script.module.chardet/lib:/var/lib/kodi/.kodi/addons/script.module.idna/lib:/var/lib/kodi/.kodi/addons/script.module.requests/lib:/var/lib/kodi/.kodi/addons/script.module.urllib3/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages
20:06:09.054 T:546987560480   DEBUG: CPythonInvoker(3, /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py): entering source directory /var/lib/kodi/.kodi/addons/script.cu.lrclyrics
20:06:09.055 T:546987560480   DEBUG: CPythonInvoker(3, /var/lib/kodi/.kodi/addons/script.cu.lrclyrics/default.py): instantiating addon using automatically obtained id of "script.cu.lrclyrics" dependent on version 2.25.0 of the xbmc.python api
20:06:09.920 T:546987560480   DEBUG: script.cu.lrclyrics: script version 5.6.1 started
20:06:09.920 T:546987560480   DEBUG: script.cu.lrclyrics: mode is service

from that point on no other log appears that refers to the lrclyrics plugin.. even if I play mp3 files or strm streams from the internet that used to display lyrics..
Just at some point it stopped working.

I checked and the plugin is installed and enabled and update to the latest version 4.6.1.

Any clue?

Thanks
Danilo


RE: CU LRC Lyrics - ronie - 2020-01-20

well, the lyrics are only shown on the visualisation screen...
i don't see you switching to that window in your log file.


RE: CU LRC Lyrics - ciropom - 2020-01-21

Hello and thanks for your reply.
I'm sorry for my ignorance, I don't quite understand what do you mean by visualization screen.

I usually go to "music" section, enter a custom directory mapped to kodi and play (by clicking) a .strm file that contains an mpeg streaming URL.
This is the relevant log


20:07:34.896 T:548289321568 DEBUG: CCurlFile::GetMimeType - http://hyades.shoutca.st:8475/radiovegit_mp3 -> audio/mpeg 20:07:34.897 T:548289321568 DEBUG: CurlFile::Open(0x7fe2dce310) http://hyades.shoutca.st:8475/radiovegit_mp3 20:07:35.507 T:548289321568 DEBUG: CCurlFile::Open - File <http://hyades.shoutca.st:8475/radiovegit_mp3> is a shoutcast stream. Re-opening 20:07:35.507 T:548289321568 DEBUG: CFileCache::Open - opening <radiovegit_mp3> using cache 20:07:35.507 T:548289321568 DEBUG: CurlFile::Open(0x7f2c441690) http://hyades.shoutca.st:8475/radiovegit_mp3 20:07:36.161 T:548289321568 DEBUG: CCurlFile::Open - File <http://hyades.shoutca.st:8475/radiovegit_mp3> is a shoutcast stream. Re-opening 20:07:36.162 T:548289321568 DEBUG: File::Open - redirecting implementation for http://hyades.shoutca.st:8475/radiovegit_mp3 20:07:36.162 T:548289321568 DEBUG: CurlFile:TonguearseAndCorrectUrl() adding custom header option 'Icy-MetaData: 1' 20:07:36.162 T:548289321568 DEBUG: CurlFile::Open(0x555cbcf6e0) http://hyades.shoutca.st:8475/radiovegit_mp3

then it stays on a black screen where the title and artists are visible (and once also the lyrics in a popup).
Should I do something else?
Maybe you are talking about this plugin for visualization?

https://kodi.wiki/view/Add-on:MilkDrop
or
https://github.com/xbmc/visualization.milkdrop2/releases

Thank you again


RE: CU LRC Lyrics - ronie - 2020-01-21

(2020-01-21, 10:58)ciropom Wrote: then it stays on a black screen where the title and artists are visible (and once also the lyrics in a popup).

ok that's the screen i'm talking about, it's odd that it doesn't show in your log...

i've tested the url you've provided and it's working ok with lyrics on my end.
since i have no other ideas, the only advice i can give is to update kodi to 18.5


This forum uses Lukasz Tkacz MyBB addons.