Kodi Community Forum
Comskip for Linux released - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: PVR & Live TV Support (https://forum.kodi.tv/forumdisplay.php?fid=167)
+---- Forum: Tvheadend (https://forum.kodi.tv/forumdisplay.php?fid=168)
+---- Thread: Comskip for Linux released (/showthread.php?tid=150084)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23


RE: Comskip for Linux released - cbxbiker61 - 2013-05-06

Probably windows crlf vs lf issue.


RE: Comskip for Linux released - schumi2004 - 2013-05-06

(2013-05-06, 05:59)cbxbiker61 Wrote: Probably windows crlf vs lf issue.

Could save some time if you could re-use logo's.
Then comskip doesn't need to look for logo again which speeds up the process.


RE: Comskip for Linux released - cbxbiker61 - 2013-06-14

0.93c is available. It fixes a minor warning with gcc 4.8.1+.


RE: Comskip for Linux released - kendrak24 - 2013-07-01

Hi! Thanks for the excellent work!

Has anyone else noticed that a leading "no-logo" segment of a recording (e.g. pre-show commercials) is never included in the edl file?
In the log file I can see that the first logo block starts on e.g. frame 1775, but that leading "no-logo" section never makes it to the "Initial Commercial List".


RE: Comskip for Linux released - cbxbiker61 - 2013-07-02

(2013-07-01, 15:54)kendrak24 Wrote: Hi! Thanks for the excellent work!

Has anyone else noticed that a leading "no-logo" segment of a recording (e.g. pre-show commercials) is never included in the edl file?
In the log file I can see that the first logo block starts on e.g. frame 1775, but that leading "no-logo" section never makes it to the "Initial Commercial List".

Yes, thanks for confirmation. I'll have to look into that.


RE: Comskip for Linux released - kendrak24 - 2013-07-05

Ok, good, so it's not just me! Smile

Also noticed that the edl times are strange. I've enabled both default output (comskip) and edl.
Notice that _some_ of the edl times corresponds to the comskip frames, but some are exactly 270 seconds off...
In this case edl_offset was not set in comskip.ini.
The comskip file has the correct breaks...

EDL-file:
2.00 98.36 0
596.92 665.92 0
1426.68 2160.16 0

Comskip-file:
FILE PROCESSING COMPLETE 53999 FRAMES AT 2500
-------------------
50 2459
14923 23398
42417 54004


RE: Comskip for Linux released - cbxbiker61 - 2013-07-05

(2013-07-05, 02:29)kendrak24 Wrote: Ok, good, so it's not just me! Smile

Also noticed that the edl times are strange. I've enabled both default output (comskip) and edl.
Notice that _some_ of the edl times corresponds to the comskip frames, but some are exactly 270 seconds off...
In this case edl_offset was not set in comskip.ini.
The comskip file has the correct breaks...

EDL-file:
2.00 98.36 0
596.92 665.92 0
1426.68 2160.16 0

Comskip-file:
FILE PROCESSING COMPLETE 53999 FRAMES AT 2500
-------------------
50 2459
14923 23398
42417 54004

It was known that in a previous version of tvheadend that tvheadend messed up the timestamps when writing to mkv, in that case they were off by 30sec. This may be a similar case. There are some tools that can analyze the correctness of mkv files in particular.

The main thing to take away from this is that the offsets in the edl would be based on timestamps in the file (and therefore may be faulty) and the comskip file is absolute based on frame #'s.

FYI: Also note that the Raspbmc maintainers have been trying to work around bugs in their code by putting "abnormal" checks for end of stream which reek havoc on mode "0" comskip. For that reason I've started using mode "3" for my files.


RE: Comskip for Linux released - cbxbiker61 - 2013-07-12

0.93e is released.

This version works with the recently released ffmpeg 2.0.

This version fixes an error in floating point audio handling which may have thrown off some of the results. I'm not sure why but this issue became apparent with ffmpeg 2.0 but not readily apparent with earlier versions. In any case corrupted audio data is the root cause. In captured video/audio some corruption is likely, so it's nice this is fixed.


RE: Comskip for Linux released - KenBotwinick - 2013-07-16

Hi,

I'm sorry if this has been asked and answered, but I'm reading and reading and reading and not finding answers.

What build of the original comskip does this map to? Is there such a mapping?

Anyone have success building the latest and greatest for Mac?

make gives me errors and I haven't figure out my way around them yet... Sad

Code:
make  all-am
g++ -DHAVE_CONFIG_H -I.  -I/opt/local/include  -I/opt/local/include  -I/opt/local/include  -I/opt/local/include    -g -O2 -MT comskip-mpeg2dec.o -MD -MP -MF .deps/comskip-mpeg2dec.Tpo -c -o comskip-mpeg2dec.o `test -f 'mpeg2dec.cpp' || echo './'`mpeg2dec.cpp
In file included from comskip.h:3,
                 from mpeg2dec.cpp:67:
CsTypes.h:4:19: error: cstdint: No such file or directory
In file included from comskip.h:4,
                 from mpeg2dec.cpp:67:
CsOptions.h:13:22: error: features.h: No such file or directory
CsOptions.h:14:18: error: missing binary operator before token "("
CsOptions.h:18:18: error: missing binary operator before token "("
In file included from /usr/include/c++/4.2.1/bits/os_defines.h:61,
                 from /usr/include/c++/4.2.1/bits/c++config.h:41,
                 from /usr/include/c++/4.2.1/cstdio:50,
                 from mpeg2dec.cpp:45:
/usr/include/unistd.h:538: error: declaration of C function ‘int getopt(int, char* const*, const char*)’ conflicts with
./getopt.h:136: error: previous declaration ‘int getopt()’ here
In file included from mpeg2dec.cpp:55:
./inttypes.h:10: error: ‘__int64’ does not name a type
./inttypes.h:15: error: ‘__int64’ does not name a type
In file included from mpeg2dec.cpp:67:
comskip.h: In member function ‘void CS::LogoBuffers::resize(size_t, size_t)’:
comskip.h:766: error: a function-definition is not allowed here before ‘:’ token
comskip.h:768: error: expected primary-expression before ‘}’ token
comskip.h:768: error: expected `;' before ‘}’ token
comskip.h:768: error: expected primary-expression before ‘}’ token
comskip.h:768: error: expected `)' before ‘}’ token
comskip.h:768: error: expected primary-expression before ‘}’ token
comskip.h:768: error: expected `;' before ‘}’ token
comskip.h: In member function ‘void CS::Histogram::clear(std::vector<int, std::allocator<int> >&)’:
comskip.h:924: error: a function-definition is not allowed here before ‘:’ token
comskip.h:926: error: expected primary-expression before ‘}’ token
comskip.h:926: error: expected `;' before ‘}’ token
comskip.h:926: error: expected primary-expression before ‘}’ token
comskip.h:926: error: expected `)' before ‘}’ token
comskip.h:926: error: expected primary-expression before ‘}’ token
comskip.h:926: error: expected `;' before ‘}’ token
make[1]: *** [comskip-mpeg2dec.o] Error 1
make: *** [all] Error 2

Help?


RE: Comskip for Linux released - KenBotwinick - 2013-07-16

My problem is probably caused by compiler version:

checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=gnu++11... no
checking whether g++ supports C++11 features with -std=gnu++0x... no
configure: No compiler with C++11 support was found

gcc version 4.2.1

Trying to find later version


RE: Comskip for Linux released - Skindred - 2013-07-18

(2013-07-16, 01:52)KenBotwinick Wrote: My problem is probably caused by compiler version:

checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=gnu++11... no
checking whether g++ supports C++11 features with -std=gnu++0x... no
configure: No compiler with C++11 support was found

gcc version 4.2.1

Trying to find later version

If this is on a Synology with Atom D2700;
You're going to have to compile a newer gcc yourself.

It's not easy, but I've managed to get it done on my DS713+ (which has more or less the same hardware as the DS412+)


RE: Comskip for Linux released - KenBotwinick - 2013-07-21

Thanks, but I was asking about Mac. And I've decided to just forego this version and use the windows version via Wine.


rpmbuild support - pavkamlc - 2013-08-06

Is possible to add into repo spec file for building on RPM based distro?
My is tested on fedora 19.


%define __spec_install_post %{nil}
%define debug_package %{nil}
%define __os_install_post %{_dbpath}/brp-compress

Summary: Commercials marker
Name: comskip
Version: 0.93e
Release: 1
License: GPL+
Group: Development/Multimedia
SOURCE0 : %{name}-%{version}.tar.xz
URL: http://www.xilka.com/xilka/source/

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root

%description
%{summary}

%prep
%setup -q

%build
./configure --prefix=/usr
make
# Empty section.

%install
rm -rf %{buildroot}
mkdir -p %{buildroot}
mkdir -p %{buildroot}/usr/bin/
mkdir -p %{buildroot}/etc/%{name}/

install -m 755 %{name} %{buildroot}/usr/bin/
install -m 700 %{name}.ini %{buildroot}/etc/%{name}/

# in builddir
#cp -a * %{buildroot}

%clean
rm -rf %{buildroot}

%files
%defattr(-,root,root,-)
%config(noreplace) /etc/%{name}/%{name}.ini
/usr/bin/comskip

%changelog
* Thu Apr 24 2013 Pavel Mlcoch <[email protected]> 0.93e-1
- First Build


RE: Comskip for Linux released - cbxbiker61 - 2013-08-06

(2013-08-06, 21:40)pavkamlc Wrote: Is possible to add into repo spec file for building on RPM based distro?
My is tested on fedora 19.


%define __spec_install_post %{nil}
%define debug_package %{nil}
%define __os_install_post %{_dbpath}/brp-compress

Summary: Commercials marker
Name: comskip
Version: 0.93e
Release: 1
License: GPL+
Group: Development/Multimedia
SOURCE0 : %{name}-%{version}.tar.xz
URL: http://www.cpanelknowledge.com/comskip-for-linux-released/

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root

%description
%{summary}

%prep
%setup -q

%build
./configure --prefix=/usr
make
# Empty section.

%install
rm -rf %{buildroot}
mkdir -p %{buildroot}
mkdir -p %{buildroot}/usr/bin/
mkdir -p %{buildroot}/etc/%{name}/

install -m 755 %{name} %{buildroot}/usr/bin/
install -m 700 %{name}.ini %{buildroot}/etc/%{name}/

# in builddir
#cp -a * %{buildroot}

%clean
rm -rf %{buildroot}

%files
%defattr(-,root,root,-)
%config(noreplace) /etc/%{name}/%{name}.ini
/usr/bin/comskip

%changelog
* Thu Apr 24 2013 Pavel Mlcoch <[email protected]> 0.93e-1
- First Build

URL should be from xilka.com.


RE: Comskip for Linux released - pavkamlc - 2013-08-09

OK, changed, but I dont found upstream for it... on xilka isn't git and isn't bugtracker. In xbmc bugtracker I don't found comskip too...


This forum uses Lukasz Tkacz MyBB addons.