Kodi Community Forum
"file system" share in file mode - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Feature Discussion (read-only) (https://forum.kodi.tv/forumdisplay.php?fid=183)
--- Thread: "file system" share in file mode (/showthread.php?tid=173048)

Pages: 1 2


"file system" share in file mode - da-anda - 2013-09-08

One thing that always bugged me was that even in "file mode" I have to add a source/share even for local HDDs, USB HDDs and other situations where I only do onetime lookups and never will use that specific source/share again. So instead of having to always add a source/share for this and delete it again I came up with the idea of a "browse file system" share which is always present. This special share would then trigger the same VFS structure that's shown when one browses for the folder while adding a new share. What do you guys think?


RE: "file system" share in file mode - Koying - 2013-09-08

lol Smile I'm planning to code just that.

I was thinking about implementing a "global://" or something VFS, which would basically be the content of the "add source" dialog + the existing sources...
"Video-Files" would get there, rather than "sources://"


RE: "file system" share in file mode - Ned Scott - 2013-09-08

+1000


RE: "file system" share in file mode - spiff - 2013-09-09

be careful here. there is potential to disable certain "security" checks in stuff such as jsonrpc (refuse to read a file that isn't in a source). with this meta source, a file would always originate from a source and would be allowed.


RE: "file system" share in file mode - da-anda - 2013-09-09

good point


RE: "file system" share in file mode - Koying - 2013-09-09

I realize we have 2 notions: "share" and "source".

Shares are basically anything we can reach, while sources are the association of a share and a scrapper.
The proper way seem to be the creation of a "shares://" VFS...


RE: "file system" share in file mode - spiff - 2013-09-09

they are the same. just a partially-done rename (used to be called shares, was renamed sources at some point).


RE: "file system" share in file mode - Koying - 2013-09-09

(2013-09-09, 16:38)spiff Wrote: they are the same. just a partially-done rename (used to be called shares, was renamed sources at some point).
Confusing as hell Wink
What I call "share", besides local drives, net protocol et al, is the content of "mediasources.xml"


RE: "file system" share in file mode - spiff - 2013-09-09

that's called a network location Smile ie. what you add if you do add source -> browse -> new network location.


RE: "file system" share in file mode - Ned Scott - 2013-09-09

(2013-09-09, 15:56)Koying Wrote: I realize we have 2 notions: "share" and "source".

Shares are basically anything we can reach, while sources are the association of a share and a scrapper.
The proper way seem to be the creation of a "shares://" VFS...

I don't suppose we could axe the whole sources.xml thing and just use the video/music/etc DBs for sources/shares? It always seemed odd to me that it's so easy to get in a situation where you can remove a share, but the source that gets scraped/updated can remain. Users wonder how certain folders still get scanned for library updates, even though they believe they've been removed. The source can easily remain "orphaned" in the DB, with no clear cut way to access it, as only "shares" are listed in the GUI.

I'm not sure if that's within the scope of this discussion/work, but I thought I'd bring it up.


RE: "file system" share in file mode - jmarshall - 2013-09-09

One thing to consider is that some folk use the files node as their main entry point to their video library. Thus, having a "browse all" or some such would be a better option, though some may not even like that.

Cheers,
Jonathan


RE: "file system" share in file mode - davilla - 2013-09-10

(2013-09-08, 15:21)da-anda Wrote: One thing that always bugged me was that even in "file mode" I have to add a source/share even for local HDDs, USB HDDs and other situations where I only do onetime lookups and never will use that specific source/share again. So instead of having to always add a source/share for this and delete it again I came up with the idea of a "browse file system" share which is always present. This special share would then trigger the same VFS structure that's shown when one browses for the folder while adding a new share. What do you guys think?

At one time, a user could insert a usb drive and the contents of said usb drive would appear in a 'file system' dir matched to the disk label. I guess someone broke this ?


RE: "file system" share in file mode - Montellese - 2013-09-11

Are we talking about the file manager or the files node/view of the video library?


RE: "file system" share in file mode - Koying - 2013-09-11

(2013-09-11, 07:55)Montellese Wrote: Are we talking about the file manager or the files node/view of the video library?
Primarily the files view, but same should be done (even more so) for the file manager.
This one even has its own sources, unrelated to anything else, AFAICT. Those should be scratched altogether, imo.


RE: "file system" share in file mode - Martijn - 2013-09-11

(2013-09-11, 08:46)Koying Wrote:
(2013-09-11, 07:55)Montellese Wrote: Are we talking about the file manager or the files node/view of the video library?
Primarily the files view, but same should be done (even more so) for the file manager.
This one even has its own sources, unrelated to anything else, AFAICT. Those should be scratched altogether, imo.

the sources added in filemanager show up as path for addons so that behaviour must be ported or changed.
example:
if you add a source in filemanager that can in turn be used by addons for storing images.
http://wiki.xbmc.org/index.php?title=Addon_Settings#type.3D.22folder.22
not sure if it also uses the sources for videos/music atm