Kodi Community Forum
Release gdrive - Google Drive Video/Music Add-on - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Video Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=154)
+---- Thread: Release gdrive - Google Drive Video/Music Add-on (/showthread.php?tid=177557)



RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-12

(2016-02-12, 18:05)ashlar Wrote:
(2016-02-12, 17:37)dmdsoftware Wrote:
(2016-02-12, 17:13)ashlar Wrote: Hi! Concerning the above report, I narrowed it down to the cache option. With cache disabled ("Always cache for playback" set to OFF), playback starts with no problem. But then one is at his bandwidth's mercy. Smile

Caching to single file or not doesn't make a difference.

I knew it had to be a setting, but suspected a different setting. I didn't want to advise you to wipe all your settings, as I knew that would have worked and we would be no further ahead on finding which setting.

Now that I know where to look, I can fix the issue.
To clarify: as soon as I re-enable "Always cache for playback", playback fails in the same way as before. If I turn it off, everything's fine once more. Maybe it was clear before but... better to err on the cautious side. Smile Thanks for looking into this.

Edit: also, even if "Always cache for playback" is disabled, selecting Play+Cache leads to the same problem.


I assume this was with gdrive-testing version, and one of the newer versions?

Caching was revamped in v0.7.21 for encfs and v0.7.22 for photos, and next version I was going to tackle video/music.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-12

Nope, I'm using 0.7.17. The same happened on an Android TV, while I use Win 8.1.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-12

By the way, this is partially offtopic and you can surely answer with "I don't have the slightest idea" but... being a DSPlayer (DirectShow based playback fork) user I was wondering... what sort of protocol does Google send to the plugin? I saw that activating the logs it gets interpreted as "streams":

18:00:32 T:32896 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams
18:00:32 T:32896 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: streams
18:00:32 T:32896 DEBUG: CPlayerCoreFactory::GetPlayers: matched 1 rules with players (and this DVDPlayer with the following playercorefactory.xml loaded)

Now, I have DSPlayer as default and the following playercorefactory.xml:

<playercorefactory>
<rules action="prepend">
<rule protocols="daap|rtv|rtmp|http|https|rtmpe|mms|rtp" player="DVDPlayer" />
</rules>
</playercorefactory>

If I delete playercorefactory.xml, DSPlayer starts as default but fails to start playback (hence I always test with "Play using... and select DVD Player).
And I think I'm lacking some DirectShow filter to interpret whatever Google is sending. Do you have any idea?


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-12

(2016-02-12, 20:27)ashlar Wrote: By the way, this is partially offtopic and you can surely answer with "I don't have the slightest idea" but... being a DSPlayer (DirectShow based playback fork) user I was wondering... what sort of protocol does Google send to the plugin? I saw that activating the logs it gets interpreted as "streams":

18:00:32 T:32896 DEBUG: CPlayerSelectionRule::GetPlayers: considering rule: streams
18:00:32 T:32896 DEBUG: CPlayerSelectionRule::GetPlayers: matches rule: streams
18:00:32 T:32896 DEBUG: CPlayerCoreFactory::GetPlayers: matched 1 rules with players (and this DVDPlayer with the following playercorefactory.xml loaded)

Now, I have DSPlayer as default and the following playercorefactory.xml:

<playercorefactory>
<rules action="prepend">
<rule protocols="daap|rtv|rtmp|http|https|rtmpe|mms|rtp" player="DVDPlayer" />
</rules>
</playercorefactory>

If I delete playercorefactory.xml, DSPlayer starts as default but fails to start playback (hence I always test with "Play using... and select DVD Player).
And I think I'm lacking some DirectShow filter to interpret whatever Google is sending. Do you have any idea?

it is a m3u compatible stream sent over https. If it fails to start, I agree, you are probably missing a DirectShow codec. It also depends on your stream choice. If you are selecting MP4,FLV, WebM or original. MP4, FLV,WebM will always be encoded in x264, so maybe you are missing that DirectShow codec? Original will be whatever container and codec is used.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-12

Nope, I always play with original. It's definitely a matter of source filter, not decoding. M3u compatible stream sent over https is a usefult indication. Thank you.

I go back to waiting for the cache thing to be solved. Thanks for that as well! Smile


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-12

I couldn't get caching to playback at all (no error, just a 0 byte file created) when I tested on the 0.7.17 earlier, but I've made the improvements I made for encfs for non-encrypted streams in the testing branch today. Just doing some more testing before it pushes out to the testing branch.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-13

Lots of updates new build v0.7.24
http://dmdsoftware.net/repository.ddurdle-testing/plugin.video.gdrive-testing-0.7.24.zip

Ability to playback SRT without caching them and support for loading all SRT files within the same folder that the video is invoked.

v0.7.24 (2016-02-12)
- implemented: support for srt files in same remote folder on google drive regardless of srt filename #58
- implemented: Allow disable to thumnail cache #51
- fix: STREAM PREFERENCES #59
- no longer need to cache SRT or SUB files locally before playback; only CC/TTS require caching (they need to be converted to SRT format)


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-13

Hi! Don't know if this new 0.7.24 testing release was supposed to fix cache problems or not... in any case I tried it and it doesn't work.

Log: http://xbmclogs.com/ps4xtaeyh

Edit: once more disabling caching makes the plugin work with no problem.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-13

(2016-02-13, 13:07)ashlar Wrote: Hi! Don't know if this new 0.7.24 testing release was supposed to fix cache problems or not... in any case I tried it and it doesn't work.

Log: http://xbmclogs.com/ps4xtaeyh

Edit: once more disabling caching makes the plugin work with no problem.

Seems you have some issues with your cache folder d:\temp. It's trying to write to a file that it doesn't have permissions to.

12:00:01 T:35192 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.IOError'>
Error Contents: [Errno 13] Permission denied: 'D:\\Temp\\0B7qc3r0JSiXEMHR2SUYtVXF4ZjQ/0B7qc3r0JSiXEMHR2SUYtVXF4ZjQ.jpg'
Traceback (most recent call last):
File "C:\Users\ashlar\AppData\Roaming\Kodi\addons\plugin.video.gdrive-testing\default.py", line 998, in <module>
package.file.thumbnail = cache.setThumbnail(service)
File "C:\Users\ashlar\AppData\Roaming\Kodi\addons\plugin.video.gdrive-testing\resources\lib\cache.py", line 145, in setThumbnail
service.downloadPicture(url, cachePath + str(self.package.file.id) + '.jpg')
File "C:\Users\ashlar\AppData\Roaming\Kodi\addons\plugin.video.gdrive-testing\resources\lib\cloudservice.py", line 1184, in downloadPicture
with open(file, 'wb') as f:
IOError: [Errno 13] Permission denied: 'D:\\Temp\\0B7qc3r0JSiXEMHR2SUYtVXF4ZjQ/0B7qc3r0JSiXEMHR2SUYtVXF4ZjQ.jpg'


Does the folder D:\\Temp\\0B7qc3r0JSiXEMHR2SUYtVXF4ZjQ exist?


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-13

No, it's not that. The folder existed.

To be sure I changed the path for Cache saving to one inside Userdata. I ran Kodi as an administrator and I gave write permissions to Users as well as Authenticated Users and Administators to that folder.

Log is here: http://xbmclogs.com/peetuxrhm

You can see that the first error happens at line 703:

16:53:43 T:27276 ERROR: XFILE::CFileCache::Open - failed to open source <plugin://plugin.video.gdrive-testing/?mode=video&instance=gdrive1&folder=0ALqc3r0JSiXEUk9PVA&filename=1qTrssusM7rnkpuYxdKWJM4gyVY09NWG_yNCJwo_mj4c&title=XBMC-gdrive&content_type=video>

And it's concerning being unable to open a source file, if I understand it correctly.

Folder 0B7qc3r0JSiXEWk91dlBlMWRXdEU is created inside the Cache folder (which I emptied before launching Kodi) and the 0B7qc3r0JSiXEWk91dlBlMWRXdEU.jpg file is created but it's a zero bytes file.

And now it fails with no cache selected too... I don't understand, check the log: http://xbmclogs.com/ppwzpei5k


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-13

(2016-02-13, 18:18)ashlar Wrote: No, it's not that. The folder existed.

To be sure I changed the path for Cache saving to one inside Userdata. I ran Kodi as an administrator and I gave write permissions to Users as well as Authenticated Users and Administators to that folder.

Log is here: http://xbmclogs.com/peetuxrhm

You can see that the first error happens at line 703:

16:53:43 T:27276 ERROR: XFILE::CFileCache::Open - failed to open source <plugin://plugin.video.gdrive-testing/?mode=video&instance=gdrive1&folder=0ALqc3r0JSiXEUk9PVA&filename=1qTrssusM7rnkpuYxdKWJM4gyVY09NWG_yNCJwo_mj4c&title=XBMC-gdrive&content_type=video>

And it's concerning being unable to open a source file, if I understand it correctly.

Folder 0B7qc3r0JSiXEWk91dlBlMWRXdEU is created inside the Cache folder (which I emptied before launching Kodi) and the 0B7qc3r0JSiXEWk91dlBlMWRXdEU.jpg file is created but it's a zero bytes file.

And now it fails with no cache selected too... I don't understand, check the log: http://xbmclogs.com/ppwzpei5k

How are you turning off caching. It's getting hung up trying to cache a thumbnail. It can create the file but it gets permission denied when writing to it. It'll always try to fetch the cached thumbnail since the file is there, so it will fail, unless you remove the cache folder altogether in add-on settings. I will add an explicit enable/disable button in settings.

I will continue to look into the file permission issue. Might be an issue with xbmcvfs. I've already found an issue with caching of folder names today (https://github.com/xbmc/xbmc/pull/8531). There should be a fix. Worst case, fall back on os.file to read/write to file.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-13

Ok, I think I've tried pretty much every combination:

http://xbmclogs.com/pic5ypxg2

"Force prompt for Quality Selection" activated

No cache in settings:
First try error with no requester shown, second try I choose original from the requester and it works fine.

With cache 5%:
First try error with no requester shown, second try I choose original from requester, it starts caching, the caching window changes title to download and it downloads the whole file as cache.mp4 (although it's an mkv). When it finishes downloading playback doesn't start. The cache.mp4 is a bit perfect copy of the file I was trying to playback.

"Force prompt for Quality Selection" deactivated and "Never transcode activated", with no cache

First try error, second time playback starts regularly.

Activating the cache, with no Force prompt and Never transcode activated led to other errors and playback never starting.


If there's anything you'd like me to try... I can't think of anything else.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-13

I have a fix for this permissions issue. Seems to be a windows issue. I packaged it as a v0.7.25 but I have to test the build a bit more as it seems to have broken some stuff. Don't have time right now.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - dmdsoftware - 2016-02-13

It is erroring on first time because it creates the file for thumbnail and fails, and errors out. Next time you try, the thumbnail file exists so it doesn't write to it, thus no error. There will be a fix in 0.7.25. Seems to be a windows issue with the file open method. Got a workaround in 0.7.25.


RE: [RELEASE] gdrive - Google Drive Video/Music Add-on - ashlar - 2016-02-13

Ok, I tried to provide you with as much info as possible. I'll test once .25 is up. If you need any more testing on .24 just let me know.