(2016-09-08, 17:03)dmdsoftware Wrote: I'll work on improving the caching.

https://github.com/ddurdle/GDrive-for-KODI/issues/92

(2016-09-09, 15:56)user321 Wrote: 'Spredsheet name' should be 'Spreadsheet name'
- What does this do, actually? Is it used as a DB for STRM information? If so, where is it stored?

Additionally, could you explain how library integration works? (I notice this has been a feature of your amazing plugin for awhile but I've never understood it). I had assumed it would update the library when a new export of STRM occurs, but never saw that happen.

(2016-09-13, 22:24)user321 Wrote: Thanks. I had a read of that link (step 2 doesn't seem to exist anymore ('Enable "Use library integration?"' -maybe it's on by default as I can't find the option).

I copied the spreadsheet and renamed it, changed the resume point to 'Google Drive Spreadsheet' but whenever I try and access the enrolled account I get an error. Kodi.log shows:

Error Contents: global name 'service' is not defined
Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.gdrive-testing/default.py", line 293, in <module>
service = gdrive_api2.gdrive(PLUGIN_URL,addon,instanceName, user_agent, settings)
File "/storage/.kodi/addons/plugin.video.gdrive-testing/resources/lib/gdrive_api2.py", line 131, in __init__
if title == service.cloudSpreadsheet:#'CLOUD_DB':
NameError: global name 'service' is not defined
-->End of Python script error report<--
20:19:59 1856.868042 T:1963212800 ERROR: GetDirectory - Error getting plugin://plugin.video.gdrive-testing/?content_type&instance=gdrive1&mode=main
20:19:59 1856.869751 T:1963212800 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.gdrive-testing/?content_type&instance=gdrive1&mode=main) failed

Btw, I was sneaky, and just installed 0.8.11.zip (which I see you didn't publish in this thread) under LibreElec 7.0.2 (Jarvis 16.2)

---------------------------------------------------------

Oh and I think I found my own explanation of the library integration feature.

When browsing folders using the GDrive plugin, it will intelligently decipher whether it's movies or tv, and use the various scrapers to get fanart, and disc cover art etc. Would that be a correct assumption? I only ask because after I have navigated into Series Name>Season XX, to generate a season listing of episodes, and then navigate back out, there is cover art. Again if this is your plugin doing this magic, where is the artwork stored?

Or, maybe this is native Kodi function?

I think I prefer STRM files, being present in "TV Shows" and "Videos" (i.e. the native Kodi library), rather than browsing via the GDrive Plugin and it pulling down fanart.

Forgive me for my lack of understanding on all the new features you're adding, and thanks again.

1. movies01 (nested folder structure, just like my google drive)
   
2. gdrive-movies (flat structure with all .strm files in the same folder)
   

(2016-09-16, 17:39)user321 Wrote: Today I've been doing some manual stream export testing using two different setups.

Code:

Windows 10 running Kodi 16.1 and GDrive Plugin 0.8.06
-Export STRM to: C:\Users\Me\strm
  - Export TV to: C:\Users\Me\gdrive-tv
  - Export movies to: C:\Users\Me\gdrive-movies

LibreElec running Kodi 16.1 and GDrive Plugin 0.8.12
-Export STRM to: storage/strm
  - Export TV to: storage/gdrive-tv
  - Export movies to: storage/gdrive-movies

My Google Drive structure:

Code:

documentaries
     Series Name
        Season 01
           Series Name - SXXEXX - Episode Name.mkv

series (same as documentaries)
     Series Name
        Season 01
           Series Name - SXXEXX - Episode Name.mkv

movies01
  My Movie (2016)
     My.Movie.2016.720p.bluray-group.mkv
     My.Movie.2016.720p.bluray-group-trailer.mov
     My.Movie.2016.720p.bluray-group.En.srt
  Another Movie (2015)
     Another Movie (2015).mkv
     Another Movie (2015)-trailer.mp4
     Another Movie (2015).srt

movies02 (same as movies01)

When I manually export (example right click 'movies01' folder > export strm > 'yes confirm') it exports to two locations (because it detects movies01 contains movies):

1. movies01 (nested folder structure, just like my google drive)
   
2. gdrive-movies (flat structure with all .strm files in the same folder)
   

but gdrive-movies does not contain the same number of files, as movies01. Analysing this:

C:\Users\Me\strm
1523 folders (1 folder = 1 movie).
2220 .strm files

C:\Users\Me\gdrive-movies
1854 .strm files

Too much in gdrive-movies. Should be 1523 in a perfect world

So what's in gdrive-movies that shouldn't be there? Examples:

Another Movie (2015)-trailer.mov.strm
Another Movie (2015)-trailer.mp4.strm
Another Movie (2015).srt.

These are not movies and I don't think they need to be copied to the 'movies' folder.

Searching for *-trailer.* returns only the .strm for trailers, but it's 587 files.

1854 - 587 = 1267 .strm files left. That's not correct. Now gdrive-movies would not contain enough .strm files.

So, then I went back to the 'movies01' export and I realised:
Movies in the format:
Movie.Name.Year.720p.SourceType-ReleaseGroup.ext

are not being copied to 'gdrive-movies' by the plugin.




In recent years, I started to keep the original filename of the movie, rather than renaming it. So all my films will have a "clean" human readable folder name, but the movies will be a mix of clean readable names and the original scene release name.

I think I posted about this before, around page 40 something if I remember correctly and I think you fixed it (definitely you fixed the *.srt.strm extra files), but maybe it crept back in somehow?

(2016-09-16, 20:39)user321 Wrote: Can this not be interpreted from the parent folder name? Maybe the logic could be something like..
If parent folder contains (date) -and subfolder doesn't contain series format, it's a movie?

(2016-09-16, 21:30)dmdsoftware Wrote:

(2016-09-16, 20:39)user321 Wrote: Can this not be interpreted from the parent folder name? Maybe the logic could be something like..
If parent folder contains (date) -and subfolder doesn't contain series format, it's a movie?

Only filenames are considered at this time. You want the folder path to be used?

(2016-09-17, 12:52)user321 Wrote:

(2016-09-16, 21:30)dmdsoftware Wrote:

(2016-09-16, 20:39)user321 Wrote: Can this not be interpreted from the parent folder name? Maybe the logic could be something like..
If parent folder contains (date) -and subfolder doesn't contain series format, it's a movie?

Only filenames are considered at this time. You want the folder path to be used?

Well, any method that would be able to identify the following variants as a movie:

When a user has renamed their movie:

Code:

Movie Name (YYYY).ext

(when a user has renamed their movie)

When a user has not renamed their movie, and left it according to 'Scene rules':

Code:

Movie.Name.YEAR.<720p/1080p>.BluRay.x264.-GROUP

If the current regex match is for (date), then how about:

Code:

$filename -match '\(\d{4}\)|\.\d{4}\.'

I believe this would match
(date)
or
.date.

Of course, if a user has not renamed their tv series, then it might also contain '.date.', but tv series will also match

Code:

S\d{1,2}E\d{1,2}

So

Code:

$filename -match '\(\d{4}\)|\.\d{4}\.' -and $filename -notmatch S\d{1,2}E\d{1,2}

it's a movie?

also, excluding -trailer.ext and .srt files from having .strm files produced would be good. It will save Kodi scanning them (even though Kodi will ignore them).

(2016-09-16, 17:39)user321 Wrote: Today I've been doing some manual stream export testing using two different setups.

Code:

Windows 10 running Kodi 16.1 and GDrive Plugin 0.8.06
-Export STRM to: C:\Users\Me\strm
  - Export TV to: C:\Users\Me\gdrive-tv
  - Export movies to: C:\Users\Me\gdrive-movies

LibreElec running Kodi 16.1 and GDrive Plugin 0.8.12
-Export STRM to: storage/strm
  - Export TV to: storage/gdrive-tv
  - Export movies to: storage/gdrive-movies

My Google Drive structure:

Code:

documentaries
     Series Name
        Season 01
           Series Name - SXXEXX - Episode Name.mkv

series (same as documentaries)
     Series Name
        Season 01
           Series Name - SXXEXX - Episode Name.mkv

movies01
  My Movie (2016)
     My.Movie.2016.720p.bluray-group.mkv
     My.Movie.2016.720p.bluray-group-trailer.mov
     My.Movie.2016.720p.bluray-group.En.srt
  Another Movie (2015)
     Another Movie (2015).mkv
     Another Movie (2015)-trailer.mp4
     Another Movie (2015).srt

movies02 (same as movies01)

When I manually export (example right click 'movies01' folder > export strm > 'yes confirm') it exports to two locations (because it detects movies01 contains movies):

1. movies01 (nested folder structure, just like my google drive)
   
2. gdrive-movies (flat structure with all .strm files in the same folder)
   

but gdrive-movies does not contain the same number of files, as movies01. Analysing this:

C:\Users\Me\strm
1523 folders (1 folder = 1 movie).
2220 .strm files

C:\Users\Me\gdrive-movies
1854 .strm files

Too much in gdrive-movies. Should be 1523 in a perfect world

So what's in gdrive-movies that shouldn't be there? Examples:

Another Movie (2015)-trailer.mov.strm
Another Movie (2015)-trailer.mp4.strm
Another Movie (2015).srt.

These are not movies and I don't think they need to be copied to the 'movies' folder.

Searching for *-trailer.* returns only the .strm for trailers, but it's 587 files.

1854 - 587 = 1267 .strm files left. That's not correct. Now gdrive-movies would not contain enough .strm files.

So, then I went back to the 'movies01' export and I realised:
Movies in the format:
Movie.Name.Year.720p.SourceType-ReleaseGroup.ext

are not being copied to 'gdrive-movies' by the plugin.




In recent years, I started to keep the original filename of the movie, rather than renaming it. So all my films will have a "clean" human readable folder name, but the movies will be a mix of clean readable names and the original scene release name.

I think I posted about this before, around page 40 something if I remember correctly and I think you fixed it (definitely you fixed the *.srt.strm extra files), but maybe it crept back in somehow?

(2016-09-17, 12:52)user321 Wrote:

(2016-09-16, 21:30)dmdsoftware Wrote:

(2016-09-16, 20:39)user321 Wrote: Can this not be interpreted from the parent folder name? Maybe the logic could be something like..
If parent folder contains (date) -and subfolder doesn't contain series format, it's a movie?

Only filenames are considered at this time. You want the folder path to be used?

Well, any method that would be able to identify the following variants as a movie:

When a user has renamed their movie:

Code:

Movie Name (YYYY).ext

(when a user has renamed their movie)

When a user has not renamed their movie, and left it according to 'Scene rules':

Code:

Movie.Name.YEAR.<720p/1080p>.BluRay.x264.-GROUP

If the current regex match is for (date), then how about:

Code:

$filename -match '\(\d{4}\)|\.\d{4}\.'

I believe this would match
(date)
or
.date.

Of course, if a user has not renamed their tv series, then it might also contain '.date.', but tv series will also match

Code:

S\d{1,2}E\d{1,2}

So

Code:

$filename -match '\(\d{4}\)|\.\d{4}\.' -and $filename -notmatch S\d{1,2}E\d{1,2}

it's a movie?

also, excluding -trailer.ext and .srt files from having .strm files produced would be good. It will save Kodi scanning them (even though Kodi will ignore them).