Kodi Community Forum
Kodi DSPlayer – DirectShow Player for Windows - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Windows (https://forum.kodi.tv/forumdisplay.php?fid=59)
+---- Thread: Kodi DSPlayer – DirectShow Player for Windows (/showthread.php?tid=223175)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-15

My point was to address the previous posts that keep filling my inbox. Yes, these get emailed to my main account, just in case someone needs help and I know the answer.
This thread isn't for arguing over who should work on this. I explained why someone hasn't, and I requested that people stop acting entitled or like a specific feature they want is important enough for someone to put in an enormous of amount of responsibility for.
If you want something and have the skills or means to make it happen, by all means, no one should be complaining if you make it happen. That's what is great about open source. Complaining that an update isn't coming is definitely not the best way to get anyone to try, though.


RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-03-15

(2019-03-15, 00:23)da3dsoul Wrote: Complaining that an update isn't coming is definitely not the best way to get anyone to try, though.
 Personally I wasn't acting entitled in any way. I proposed the creation of a bounty to attract interest in keeping development active. There's not much more I could do, not being a coder.
Would $1,000 be attractive enough? $3,000? $5,000? What would be the correct figure to entice a developer to bring Kodi DSPlayer to the 18.2 release?  I ask you since you seem to have a clear(er) idea of the work involved.


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-15

I wasn't referring to you specifically. As a developer myself, I can say that, at least in my case, tone is everything.
"Are there any plans for an update?" is a thousand times better than, "When's the update gonna be?"
The second is less offensive if I've already said I'm working on it, but, "Any news?" is still better than acting like I'm on a schedule or in any hurry to please anyone.

You were plenty polite. Some others were not. I'm not calling names, mainly because I don't commit them to memory if they are rude, but others were not polite, even if they meant no offense.

About the money thing, this might just be me, but it's not about the money. If I don't want to, I don't want to. Whether it's $5 or $50,000, if I choose to work on something, it's because I chose to for personal reasons. Usually, that reason is, "because it sounded fun."

If you offered me $50,000, I would gladly try to make DSPlayer the best thing that I can, as I do love the project. You notice that I made no promises. I can say what is required to tackle a project like this at the least because I know enough to understand that I don't know enough. I would need to learn a lot before I could even try to do a lot of things that DSPlayer needs right now. I would only take money because I recognize that it would take literally all of my time just learning what is needed.


RE: Kodi DSPlayer – DirectShow Player for Windows - Sunset1982 - 2019-03-15

hey guys,

I updated my Windows to latest Windows 10 build (1809) last week. I also updated drivers and changed my gfx card (now vega 56). Since then, my pc suddenly stops sometimes when I play video files with my kodidsplayer. playback stops, player exits and focus is back in kodi. it is completely random. any idea what causes this?


RE: Kodi DSPlayer – DirectShow Player for Windows - dado1971 - 2019-03-15

(2019-03-15, 01:20)da3dsoul Wrote: I wasn't referring to you specifically. As a developer myself, I can say that, at least in my case, tone is everything.
"Are there any plans for an update?" is a thousand times better than, "When's the update gonna be?"
The second is less offensive if I've already said I'm working on it, but, "Any news?" is still better than acting like I'm on a schedule or in any hurry to please anyone.

You were plenty polite. Some others were not. I'm not calling names, mainly because I don't commit them to memory if they are rude, but others were not polite, even if they meant no offense.

About the money thing, this might just be me, but it's not about the money. If I don't want to, I don't want to. Whether it's $5 or $50,000, if I choose to work on something, it's because I chose to for personal reasons. Usually, that reason is, "because it sounded fun."

If you offered me $50,000, I would gladly try to make DSPlayer the best thing that I can, as I do love the project. You notice that I made no promises. I can say what is required to tackle a project like this at the least because I know enough to understand that I don't know enough. I would need to learn a lot before I could even try to do a lot of things that DSPlayer needs right now. I would only take money because I recognize that it would take literally all of my time just learning what is needed.
 50kHuh? get over yourself lol


RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-03-15

(2019-03-14, 21:30)da3dsoul Wrote: People are throwing around reasons for using DSPlayer, and I'll give it to you. It has nothing to do with HDR for most people. Kodi's built in player is slow and not very good at a lot of things. This is not intended to be offensive. They are aware of it, and they are clearly trying to improve it bit by bit.
I use DSPlayer because it can render subtitles without completely shutting Kodi down with lag. This is one reason to use it. Another reason is scaling algorithms. There's frame interpolation, HDR (which is poorly implemented at best, due to lack of OS and driver support), 3D (without killing kodi with lag again...), better sound support, and many more reasons.
Don't act like your specific use case speaks for even a majority of users.
Addon developers can make things work with DSPlayer if they want to, as well. I did. It's comparatively easy, considering that DSPlayer is entirely C++ on top of decades old code originally written for XBOX.

Someone wanted some ideas of what is required or helpful. Here's some that I encountered when attempting to aid development myself:
  • C++ and all of the build tools involved
  • Thorough knowledge of DirectX/DirectDraw/OpenGL/Windows Graphics and Sound APIs. This isn't completely necessary to work on DSPlayer, but you'll hit weird issues with no clue how to approach them without experience in those.
  • Thorough knowledge of media codecs, how to parse them (even with libraries), and how to forward them to another application
  • The ability to write code that does not crash. This does not mean that errors can't occur, but that you are capable of thinking and writing in a way that includes failsafe fallbacks to everything you do. You should never hit play or stop, and then see Kodi indefinitely lock up or crash.
  • Knowledge of memory management in C++, specifically involving reading, managing, and closing streams.
  • File Locking, as nothing will work if you are not letting MadVR, LAV, etc even access the filestream that you hand it.
  • DRM and copyright implications, mainly to cover your own ass and prevent an accidental legal issue.
  • Concepts on video technologies involved with encoding, including how framerate, codecs, containers, 3D and HDR, and things of that nature may screw with things. Not knowing these will cause poor color quality or worse.
  • THE ABILITY TO BE POLITE, RESPECTFUL, AND INTERACT WITH A TOXIC COMMUNITY. If this thread shows anything, it's that no matter how cool you are, there are people who don't deserve your time. Despite that, you still can't be blatantly rude, or the experience will be ruined for all, and it'll very quickly drive you away when you realize nothing is worse than working for free and getting involved in petty flame wars over it.

Most of these do not require Book of Magnus level knowledge, but if you don't at least understand what they are and how they work, you will drop the project when you encounter an issue that flies a mile over your head. 
Thanks for your post. The list of required development skills is very helpful and probably is about as pessimistic as I thought in terms of finding a developer. Small updates to the current player are really all that is desired rather than any significant rewrites of the player.

If you could actually contribute, that would be welcome. But certainly no one would be pressured to do anything and they are free to ignore any condescending comments from the odd user here or elsewhere and do whatever they please with this project because it is still 100% free, hobby software. This is supposed to be casual and fun, not stressful.

Are these pie in the sky comments implying you would like to try to update DSPlayer or know someone who can? Or are you just spitballing about what it would take to be a developer?


RE: Kodi DSPlayer – DirectShow Player for Windows - madjockxbmc - 2019-03-15

(2019-03-15, 11:15)Sunset1982 Wrote: hey guys,

I updated my Windows to latest Windows 10 build (1809) last week. I also updated drivers and changed my gfx card (now vega 56). Since then, my pc suddenly stops sometimes when I play video files with my kodidsplayer. playback stops, player exits and focus is back in kodi. it is completely random. any idea what causes this?
 There are a lot of changes there, does playback have issues with an external player like MPC-BE ?


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-15

I've tried to fix some of the smaller bugs before, but just trying to figure out the code left me utterly confused. This was a few years ago mind you, so who knows if it would suddenly make sense now.

50k was an arbitrary number I made up. If you hired a paid programmer full time with the skills and experience I mentioned, they would be paid twice to three times that. Get over yourself. Good programmers are a special breed, and they aren't cheap. It's not about the money, because $5 or $50 isn't worth the time. The enjoyment of helping a project that you like is what is worth the time.

@Sunset: no offense, but why did you let Windows install that? There's nothing but bad news surrounding that update. Similar to Windows 10 update 1803, it made breaking changes to drivers and some other things.


RE: Kodi DSPlayer – DirectShow Player for Windows - dwalme - 2019-03-15

(2019-03-15, 17:59)da3dsoul Wrote: 50k was an arbitrary number I made up. If you hired a paid programmer full time with the skills and experience I mentioned, they would be paid twice to three times that. Get over yourself. Good programmers are a special breed, and they aren't cheap. It's not about the money, because $5 or $50 isn't worth the time. The enjoyment of helping a project that you like is what is worth the time.
 This is the truth right here.


RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-03-15

You would have a short career as a DSPlayer developer. I don't know how many hours are involved, but it is barely a hobby now that a template for a working player is already in place.

You are probably right that DSPlayer needs a professional developer with some free time, and probably not even paid free time, just available time, period. If it was for a fee, it would likely only be for a remuneration of their time more than any kind of true financial incentive.

I did assume in the past that aracnoz was a skilled professional programmer by day in Italy, and I would assume a well-paid one by now. This project didn't seem that challenging for him.

For now, doing a proper merge to v18 and bug fix would be good enough for most of us. I still don't know what experience is required to just do that.


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-15

I agree. Clearly he had his bugs that pissed him off, but you aren't a real programmer if you've never had those.


RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-03-16

(2019-03-15, 17:59)da3dsoul Wrote: 50k was an arbitrary number I made up. If you hired a paid programmer full time with the skills and experience I mentioned, they would be paid twice to three times that. Get over yourself. Good programmers are a special breed, and they aren't cheap. It's not about the money, because $5 or $50 isn't worth the time. The enjoyment of helping a project that you like is what is worth the time.
Oh, if we were talking creating DSPlayer from scratch I agree that your figure would probably a conservative one. As Warner306 already mentioned, we currently "simply" need a merge of what's changed from 17.6 to 18.2. I guess it's not little work but I hope it's not as complex as rewriting everything.
And again, I wish to stress that my idea of a "bounty" to offer was simply meant in the sense of "is there something that poor ashlar can do, considering he's no coder?". Smile The same spirit that led me to donate multiple times to XBMC/Kodi in my long love story with this awesome creation.


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-16

That attitude is fair and appreciated by most developers.
I've not seen the internal code changes in 18/18.1, so I don't know how much trouble it would be. I know it wouldn't just be a simple patch and build, though, as they specifically did work in the area that DSPlayer covers.
I know that as an addon developer, 18/18.1 has brought some good but really annoying changes. There was a lot of things that were changed, down to annoying but simple changes like the duration format (time in seconds to "hh : mm : ss").

EDIT: apparently there's no simple way to say hh:mmConfuseds without it becoming a stupid smiley.


RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-03-18

For areas of VideoPlayer that crossover with DSPlayer, wouldn't simply be a matter of moving some code around to address merge conflicts, or would the DSPlayer playback engine need to be adapted to v18?


RE: Kodi DSPlayer – DirectShow Player for Windows - da3dsoul - 2019-03-18

No idea, but if you are going in and looking to see what needs to be done, then it's already more than a simple patch and build.

It might be simple moving code around or fixing merge errors, but I don't know, as I've not tried.
I've got my hands full just making sure my addon doesn't break in Leia.