(2020-02-02, 20:25)Mordred Wrote:

(2020-01-12, 13:26)curael Wrote:

(2020-01-12, 12:39)CyberVillain Wrote: I'm looking at getting madVR to integrate with Kodi, why isnt this branch of Kodi pulled into master? It seems its unmaintained too, master is now at 18.x

The project has had no maintainer since 17.x. Maintaining DSplayer and to build/port it into Leia branch is not an easy feat and sadly no one has had the combination of time and skill required to do so.  

Has anyone actually attempted this? I'm sure I'm not going to make much progress here and will probably have to give up when I can't get the pipeline to build, but I'm already about 8 hours and about 450 of the 500+ merge conflicting files resolved (of updating this to the original 18.0 release). Hell VS Code can't even handle a git changelist with more than 5k files in it. If by some magic I can get 18.0 w/ DSPlayer to work, then I can start the arduous task of doing it all over again for the other 18.x milestones.

Anyway, if someone else has been stupid enough to try this before, I'd love to get together and discuss issues and roadblocks.  

(2020-02-03, 00:25)Mordred Wrote: Thanks for the tip. Most of the changes going from 17-18 have been pretty easy so far since aracnoz's stuff is almost always wrapped in #ifdef HAS_DS_PLAYER, and then it's just a matter of making sure that code still belongs where it belongs, and updating the variable names, and accessor functions his code uses.

I'm gonna see how far off I am at the end of this merge stuff (only 72 files left!) and see how difficult it looks to get things in working-ish order. Will probably abandon for you and jogal's work, but it's been an interesting process so far. Even if it's wasted effort it finally gave me a reason to install the Linux subsystem on Windows too so that I can do git things from a terminal that I needed to do, so that's a plus.

(2020-02-03, 00:47)fandangos Wrote: I was doing exactly the same, by hand after greping all the ifdef has_ds_player but if you look at the araxis merge I can see files that were not on that list.

I have this going for v19 missing 20 files or so. 
I can upload it to you. I was just copying and pasting and commenting the ifdef has_ds_player. I haven't started to translate this yet. 
I stopped because I got the tip about Araxis Merge. 

(2020-02-03, 00:57)Mordred Wrote:

(2020-02-03, 00:47)fandangos Wrote: I was doing exactly the same, by hand after greping all the ifdef has_ds_player but if you look at the araxis merge I can see files that were not on that list.

I have this going for v19 missing 20 files or so. 
I can upload it to you. I was just copying and pasting and commenting the ifdef has_ds_player. I haven't started to translate this yet. 
I stopped because I got the tip about Araxis Merge. 

If you've got a branch that's ahead of where I am, put it up as a branch and I'll take a look.

MadVR is definitely the best way to watch stuff, and it's a shame we have to compromise to stay up to date with the latest Kodi features.  

(2020-02-02, 20:37)jogal Wrote: I think it won't be necessary to do that 

Finally seems 100% fixed all stuttering/tearing NVIDIA issues: https://forum.kodi.tv/showthread.php?tid=349861&pid=2921096#pid2921096

In HDR/SDR  4K/1080p  and  HDR 60fps

(2020-02-03, 04:47)spencerjford Wrote:

(2020-02-02, 20:37)jogal Wrote: I think it won't be necessary to do that 

Finally seems 100% fixed all stuttering/tearing NVIDIA issues: https://forum.kodi.tv/showthread.php?tid=349861&pid=2921096#pid2921096

In HDR/SDR  4K/1080p  and  HDR 60fps

Oh but it is, as madVR is a far superiour video render than the built in videoplayer of Kodi.  No disrespect to your work intended!      

• Ignorance and lack of technical knowledge.
  
• Human nature to reject changes.
  
• Human nature to follow the crowd.
  

(2020-02-03, 19:56)jogal Wrote:

(2020-02-03, 04:47)spencerjford Wrote:

(2020-02-02, 20:37)jogal Wrote: I think it won't be necessary to do that 

Finally seems 100% fixed all stuttering/tearing NVIDIA issues: https://forum.kodi.tv/showthread.php?tid=349861&pid=2921096#pid2921096

In HDR/SDR  4K/1080p  and  HDR 60fps

Oh but it is, as madVR is a far superiour video render than the built in videoplayer of Kodi.  No disrespect to your work intended!       

I do not doubt that madVR is superior in options, but the real question is:

Do all people need it?For example, I was watching yesterday Gemini Man 4K 60 fps HDR10 pass-through with an Intel NUC8i3BEK and simply better quality is impossible because it is the maximum that my Sony AG9 55” can give. I am clear that I do NOT need madVR for my current needs.Then there are several characteristic user profiles: 1. Buy the cheapest graphics card that works with madVR (this question is repeated many times in the forums) and buy a GTX 1030 or similar. Then in madVR it disables everything and leaves the quality to a minimum because if it is not “choppy playback” is obtained. 2. Buy the best $900 graphics card and activate all filters and custom options in madVR to the fullest, use custom calibrations, etc. If you keep reading and realize that he is doing HDR to SDR tone mapping when he has a TV that is HDR capable!! Then he says he prefers it that way because he likes it more image obtained... WTF!!!In general, it seems that without madVR, 4K content cannot be played on Windows.This is due to three factors:

• Ignorance and lack of technical knowledge.
  
• Human nature to reject changes.
  
• Human nature to follow the crowd.
  

I just wanted to share my thoughts on this aloud. 

(2020-02-03, 19:56)jogal Wrote: I do not doubt that madVR is superior in options, but the real question is:

Do all people need it?

• always had issues changing the refresh rate and even if that worked I still had stutter - fixed by MadVR (with my current custom timings there is no repeated frame for more than 15minutes)
  
• always had troubles playing some of my files / crashed quite A LOT - fixed by DsPlayer and its use of LAV Filters
  
• always had troubles/failed passing through TrueHD, DTS-MA - fixed by DsPlayer and its use of LAV Filters
  

(2020-02-03, 00:57)Mordred Wrote:

(2020-02-03, 00:47)fandangos Wrote: I was doing exactly the same, by hand after greping all the ifdef has_ds_player but if you look at the araxis merge I can see files that were not on that list.

I have this going for v19 missing 20 files or so. 
I can upload it to you. I was just copying and pasting and commenting the ifdef has_ds_player. I haven't started to translate this yet. 
I stopped because I got the tip about Araxis Merge. 

If you've got a branch that's ahead of where I am, put it up as a branch and I'll take a look.

MadVR is definitely the best way to watch stuff, and it's a shame we have to compromise to stay up to date with the latest Kodi features. 

(2020-02-04, 09:35)oldpainless Wrote: @jogal  - I get your point on good quality 4k material. The problem, for me anyway, is sub 4k material using stock Kodi scalers does not come anywhere close to what MadVr can do.

(2020-02-04, 09:07)Cinephile Wrote:

(2020-02-03, 00:57)Mordred Wrote:

(2020-02-03, 00:47)fandangos Wrote: I was doing exactly the same, by hand after greping all the ifdef has_ds_player but if you look at the araxis merge I can see files that were not on that list.

I have this going for v19 missing 20 files or so. 
I can upload it to you. I was just copying and pasting and commenting the ifdef has_ds_player. I haven't started to translate this yet. 
I stopped because I got the tip about Araxis Merge. 

If you've got a branch that's ahead of where I am, put it up as a branch and I'll take a look.

MadVR is definitely the best way to watch stuff, and it's a shame we have to compromise to stay up to date with the latest Kodi features. 

I find madVR + mpc external player to be the perfect compromise. You get all of the good stuff from both sides.