Kodi Community Forum
Release Retrospect v5.3.2 Video Add-On - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Video Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=154)
---- Thread: Release Retrospect v5.3.2 Video Add-On (/showthread.php?tid=25522)



RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-05

(2015-12-05, 16:54)Martijn Wrote: i'd say you use totally unrecommended way of calling the player. A plugin should not decide what player to use.

if you see this
Quote:AttributeError: 'module' object has no attribute 'PLAYER_CORE_DVDPLAYER'
you are doing it wrong since many versions. Certainly not a Kodi problem cause that method was deprecated long time ago and now finally killed from core code.

Edit:

PHP Code:
def GetPlayer(textOnly=False):
        
""" Get's the default player. this is only used for raspberry pi. """

        
try:
            
settingIndex int(AddonSettings.__GetSetting(AddonSettings.__RPI_PLAYER) or 0)
            if 
textOnly:
                return [
"Auto""DVDPlayer"][settingIndex]
            else:
                return [
xbmc.PLAYER_CORE_AUTOxbmc.PLAYER_CORE_DVDPLAYER][settingIndex]
        
except Exceptione:
            
Logger.Warning("Error determining the Player Core in Kodi, falling back to PLAYER_CORE_AUTO:\n%s"e.message)
            return 
xbmc.PLAYER_CORE_AUTO 

Seriously this is just plain wrong and i will make sure that code dies from the Python API soon.

Don't get me wrong, you are right and I changed it in the new version. But I test with the official Kodi nightly builds and they are working just fine, so initially I thought there was no need for changes. This is just old code from the Xbox era where there was a mplayer and dvdplayer and back then some streams worked better with DVDplayer, others with Mplayer.

So it will all be fine, I just found it weird that the Milhouse removed a lot of stuff that was still in the Kodi main code. That is all.

EDIT: about the API, yes, please remove old stuff. I keep an eye out on http://kodi.wiki/view/Jarvis_API_changes (or newer one) and try to keep up with that. Besides that, I have the feeling that you are offended somewhat (taking it from the "Seriously this is just plain wrong and i will make sure that code dies from the Python API soon." ? I don't know why, did I say something, or do something wrong?


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Milhouse - 2015-12-05

(2015-12-05, 17:04)Basje Wrote: I just found it weird that the Milhouse removed a lot of stuff that was still in the Kodi main code. That is all.

As explained in my test thread, my builds for a few months now have been based on code targeting Kodi 17, and a lot of crusty old legacy code has been dropped as a result. This has afforded add-on and skin developers plenty of time to bring their code up to speed with what is coming, if they choose to do so. Kodi 17a1 is here now (master branched earlier today) so at least you're in good shape. Smile


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-05

(2015-12-05, 17:32)Milhouse Wrote:
(2015-12-05, 17:04)Basje Wrote: I just found it weird that the Milhouse removed a lot of stuff that was still in the Kodi main code. That is all.

As explained in my test thread, my builds for a few months now have been based on code targeting Kodi 17, and a lot of crusty old legacy code has been dropped as a result. This has afforded add-on and skin developers plenty of time to bring their code up to speed with what is coming, if they choose to do so. Kodi 17a1 is here now (master branched earlier today) so at least you're in good shape. Smile

Good to hear that. I will certainly go and install it as soon as there is a Windows build (or is there one already?). Do you happen to have an overview of what legacy stuff was removed from the API?


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Milhouse - 2015-12-05

VideoPlayer replaces DVDPlayer: http://forum.kodi.tv/forumdisplay.php?fid=240 which has had an effect on the Python API.

Not sure when VideoPlayer will merge to master, should be real soon now, but when it does you should be able to find a Windows build. Ever thought about acquiring a cheap RPi as a test device? Smile


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-05

(2015-12-05, 17:57)Milhouse Wrote: VideoPlayer replaces DVDPlayer: http://forum.kodi.tv/forumdisplay.php?fid=240 which has had an effect on the Python API.

Not sure when VideoPlayer will merge to master, should be real soon now, but when it does you should be able to find a Windows build. Ever thought about acquiring a cheap RPi as a test device? Smile

Great. I have 2 actually, a rPi B and an rPi 2. The rPi B is not doing anything at the moment, so you are right and I should make it my test device.


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Milhouse - 2015-12-05

Keep an eye on PR8486.


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - filigran - 2015-12-05

Hi.
I'm trying to add some shows as favourites by using the context menu, but all I get is "no favourites available". It's as if it is going to the "show favourites" screen each time instead of adding it. Bug, or am I doing it wrong? I cannot find any documentation about it. This is on 4.0.0.

Edit: found this: https://bitbucket.org/basrieter/xbmc-online-tv/issues/582/favorites-wont-show-after-351-update

My folder is empty, but it still doesn't work.


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-05

(2015-12-05, 23:29)filigran Wrote: Hi.
I'm trying to add some shows as favourites by using the context menu, but all I get is "no favourites available". It's as if it is going to the "show favourites" screen each time instead of adding it. Bug, or am I doing it wrong? I cannot find any documentation about it. This is on 4.0.0.

Edit: found this: https://bitbucket.org/basrieter/xbmc-online-tv/issues/582/favorites-wont-show-after-351-update

My folder is empty, but it still doesn't work.

Nope, it is a know issue. In the mediaitem.py edit find the line that reads: "httpHeaders" and change it to have a capital H: "HttpHeaders" (don't change anything else, especially whitespaces (spaces, tabs)).


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Martijn - 2015-12-06

(2015-12-05, 17:38)Basje Wrote:
(2015-12-05, 17:32)Milhouse Wrote:
(2015-12-05, 17:04)Basje Wrote: I just found it weird that the Milhouse removed a lot of stuff that was still in the Kodi main code. That is all.

As explained in my test thread, my builds for a few months now have been based on code targeting Kodi 17, and a lot of crusty old legacy code has been dropped as a result. This has afforded add-on and skin developers plenty of time to bring their code up to speed with what is coming, if they choose to do so. Kodi 17a1 is here now (master branched earlier today) so at least you're in good shape. Smile

Good to hear that. I will certainly go and install it as soon as there is a Windows build (or is there one already?). Do you happen to have an overview of what legacy stuff was removed from the API?

fyi this post in add-on dev section already told to not use player selection any more (2013-09-29)
http://forum.kodi.tv/showthread.php?tid=173887&pid=1516662#pid1516662


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-06

(2015-12-06, 21:48)Martijn Wrote:
(2015-12-05, 17:38)Basje Wrote:
(2015-12-05, 17:32)Milhouse Wrote: As explained in my test thread, my builds for a few months now have been based on code targeting Kodi 17, and a lot of crusty old legacy code has been dropped as a result. This has afforded add-on and skin developers plenty of time to bring their code up to speed with what is coming, if they choose to do so. Kodi 17a1 is here now (master branched earlier today) so at least you're in good shape. Smile

Good to hear that. I will certainly go and install it as soon as there is a Windows build (or is there one already?). Do you happen to have an overview of what legacy stuff was removed from the API?

fyi this post in add-on dev section already told to not use player selection any more (2013-09-29)
http://forum.kodi.tv/showthread.php?tid=173887&pid=1516662#pid1516662

Thanks Martijn! I just subscribed to that thread and will read through it. And again, I am sorry if I offended you (or anybody else).


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Martijn - 2015-12-06

np Smile
Things might get missed from time to time. Keep an eye on this as well
http://forum.kodi.tv/showthread.php?tid=250936


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - filigran - 2015-12-09

(2015-12-05, 23:39)Basje Wrote:
(2015-12-05, 23:29)filigran Wrote: Hi.
I'm trying to add some shows as favourites by using the context menu, but all I get is "no favourites available". It's as if it is going to the "show favourites" screen each time instead of adding it. Bug, or am I doing it wrong? I cannot find any documentation about it. This is on 4.0.0.

Edit: found this: https://bitbucket.org/basrieter/xbmc-online-tv/issues/582/favorites-wont-show-after-351-update

My folder is empty, but it still doesn't work.

Nope, it is a know issue. In the mediaitem.py edit find the line that reads: "httpHeaders" and change it to have a capital H: "HttpHeaders" (don't change anything else, especially whitespaces (spaces, tabs)).

Works great, thanks!
Btw, a feature request if I may: possibility to add episodes to favorites, not just shows. And perhaps an option to add a list item to access favorites, both at the root (all channels) and per channel, not just through the context menu (wife friendly :-)).


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-09

(2015-12-09, 23:07)filigran Wrote:
(2015-12-05, 23:39)Basje Wrote:
(2015-12-05, 23:29)filigran Wrote: Hi.
I'm trying to add some shows as favourites by using the context menu, but all I get is "no favourites available". It's as if it is going to the "show favourites" screen each time instead of adding it. Bug, or am I doing it wrong? I cannot find any documentation about it. This is on 4.0.0.

Edit: found this: https://bitbucket.org/basrieter/xbmc-online-tv/issues/582/favorites-wont-show-after-351-update

My folder is empty, but it still doesn't work.

Nope, it is a know issue. In the mediaitem.py edit find the line that reads: "httpHeaders" and change it to have a capital H: "HttpHeaders" (don't change anything else, especially whitespaces (spaces, tabs)).

Works great, thanks!
Btw, a feature request if I may: possibility to add episodes to favorites, not just shows. And perhaps an option to add a list item to access favorites, both at the root (all channels) and per channel, not just through the context menu (wife friendly :-)).
Good to hear. The shows as favorites are a bit of a problem. As those URL's tend to change over time and it will be hard to guarantee a working video after some time.


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - UnusualKid - 2015-12-15

Basje,

I love your work on Retrospect, but I was wondering if it's possible to add videos from Ketnet as well...
Would this be hard to do?


RE: Retrospect v4.0.0 (formerly XBMC Online TV) add-on - Basje - 2015-12-15

(2015-12-15, 12:24)UnusualKid Wrote: Basje,

I love your work on Retrospect, but I was wondering if it's possible to add videos from Ketnet as well...
Would this be hard to do?

It was present once, but I removed it due to site changes. Can you create an "enhancement request" on the issue tracker: https://bitbucket.org/basrieter/xbmc-online-tv/issues/new


This forum uses Lukasz Tkacz MyBB addons.