Kodi Community Forum
[split] Improved Classical Music Browsing - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Music Support (https://forum.kodi.tv/forumdisplay.php?fid=263)
--- Thread: [split] Improved Classical Music Browsing (/showthread.php?tid=275795)

Pages: 1 2 3 4 5 6 7 8 9 10 11


RE: Improved Classical Music Browsing - DaveBlake - 2016-02-01

Tommy, we know that Kodi does not yet handle the TIT1 tag, but if you had used mood tag (TMOO or TXXX:MOOD) or comments (COMM) tag for the same personal data then Kodi would be able to do exactly what you want. Thinking mood may not be in 2.3, is in 2.4, not sure. But also could use TCON multi genre values e.g. "Xmas / rocking" rather than TCON only one of "Music" or "Xmas". Or you could put all Xmas music in a separate folder and make a playlist based on path. Many ways to do what you want.

Theme and style are artist and album properties (not tags), that can be scraped from NFO (local files) or online databases. You can them use them in smart playlist rules too. I suspect that the scraped values from databases may not be what you want, so you would need to create NFO. But personally, I don't agree with zag, I find using custom tags in my song files far easier for categorising my music.

More confused?


RE: Improved Classical Music Browsing - tommyp - 2016-02-01

Things are getting clearer, and thanks for helping the noobie. I think the root problem is that I don't understand the ID3 lingo that kodi uses. Once I figure out, I think I will be golden and be a happy user. Smile
Is it possible that the wiki page get updated so it reflects exactly what ID tags kodi reads in along with the kodi friendly description? For example, TMOO or TXXX:MOOD equals MOOD. TMOD and the musicbrainz stuff aren't part of the idv2.3 spec so I'm assuming that kodi is reading in a mess of custom id tags that I don't know about or use.


RE: Improved Classical Music Browsing - DaveBlake - 2016-02-01

TMOO is a standard ID3 v2.4 tag. Yes the musicbrainz tags are a common custom tag. Not sure I would call it a mess. You could probably do what you want using multiple genre (TCON) values with space-slash-space separators.

I have not tried the comments tag (COMM in v2.3) but that should work too.

Wiki could certainly be improved. I also think there are other wiki pages from the one you referenced that already say more, just not sure where they are. Zag I have a table in Word if you can put it somewhere?


RE: Improved Classical Music Browsing - zag - 2016-02-01

Sure send me any info and see here and I can edit:

Music_tagging (wiki)

Obviously since its a wiki, anyone can sign up and edit too Smile


RE: Improved Classical Music Browsing - DarkHelmet - 2016-02-01

Dave, zag and everyone else involved, just a heads up. You do a great job. It's all appreciated.


RE: Improved Classical Music Browsing - zag - 2016-02-01

I've updated the wiki again with all the tags Kodi reads

http://kodi.wiki/view/Music_tagging#Tags_Kodi_reads

Just need to find out what database fields they fill now. This page helps but is way out of date:

http://kodi.wiki/view/Databases#artist


RE: Improved Classical Music Browsing - Razze - 2016-02-01

(2016-02-01, 17:23)zag Wrote: I've updated the wiki again with all the tags Kodi reads

http://kodi.wiki/view/Music_tagging#Tags_Kodi_reads

Just need to find out what database fields they fill now. This page helps but is way out of date:

http://kodi.wiki/view/Databases#artist

That's your artist table.
https://github.com/xbmc/xbmc/blob/master/xbmc/music/MusicDatabase.cpp#L123

The composer stuff is probably done in the role table (correct me dave)
https://github.com/xbmc/xbmc/blob/master/xbmc/music/MusicDatabase.cpp#L170


RE: Improved Classical Music Browsing - zag - 2016-02-01

Thanks Razze, that let me find a few more fields.

@tommyp although I know you would rather use tags, your statements prompted me to finish the "Theme" support on TADB.

See an example of a Christmas album here (notice the "Theme" on the left side): http://www.theaudiodb.com/album/2127240

You can now add a theme to any album or track, so hopefully in the future we can search for "Christmas" albums with "Rock" genre and "Fast" speed as a node or smart playlist. This info would come from metadata sites though and you would have to scrape with something like the universal music scraper.

Kodi already has a strThemes database field in its album table.

Of course you can still also use the tags such as tit1 or comment if you want. That just seemed a bit of a hack to me.


RE: Improved Classical Music Browsing - DaveBlake - 2016-02-01

(2016-02-01, 17:23)zag Wrote: Just need to find out what database fields they fill now.

The joy of having a relational database is that there isn't necessarily a simple link between tags and fields. Kodi processes the tag data, not just copy it. Initial artist and album data is derrived from the song tag data, so you could say one tag goes in many places, data is normalised, so many tag values go in one place. There is processing, for example to decide if an album is a compilation it uses
1) album name is non-empty AND
2a. the songs have different artists OR
2b. all tracks are marked as part of compilation AND
3a. a unique primary artist is specified as "various" or "various artists" OR
3b. we have at least two primary artists and no album artist specified.

So can we not try to put database field names next to tags, it isn't going to help anyone.


RE: Improved Classical Music Browsing - joethefox - 2016-02-01

it seems that someone has started to support the artist's roles in a remote control app:



\m/


RE: Improved Classical Music Browsing - zag - 2016-02-01

Awesome!!

Image


RE: Improved Classical Music Browsing - tommyp - 2016-02-02

You guys rock! Thanks for the wiki page update. I don't mind retagging, now I know what tags to use!


RE: Improved Classical Music Browsing - zag - 2016-02-02

(2016-02-01, 19:44)DaveBlake Wrote:
(2016-02-01, 17:23)zag Wrote: Just need to find out what database fields they fill now.

The joy of having a relational database is that there isn't necessarily a simple link between tags and fields. Kodi processes the tag data, not just copy it. Initial artist and album data is derrived from the song tag data, so you could say one tag goes in many places, data is normalised, so many tag values go in one place. There is processing, for example to decide if an album is a compilation it uses
1) album name is non-empty AND
2a. the songs have different artists OR
2b. all tracks are marked as part of compilation AND
3a. a unique primary artist is specified as "various" or "various artists" OR
3b. we have at least two primary artists and no album artist specified.

So can we not try to put database field names next to tags, it isn't going to help anyone.

Thanks, I've removed the database tables for now from the wiki article.


RE: Improved Classical Music Browsing - pieterv - 2016-03-10

Hi DaveBlake, Thanks for the work. I am trying it out right now. I'm not able to test your EXE, but I'm running Kodi 17 from the Gentoo Ebuild 9999, and that's actually the kodi git main branch. So I don't know if my comments are still valid for you or not, but here goes:

I'm getting the following error when going over to the composer role:

Quote:19:17:26 T:140197194888960 ERROR: SQL: [MyMusic59] The table does not exist
Query: SELECT idRole FROM Role WHERE strRole like 'Composer'

The composers are then not correctly displayed. All artists are shown.

I noticed in phpmysql that the table is called "role" and not "Role". When I manually alter the table name to "Role" instead of "role", the error goes away and the composers are correctly shown.

(or my personal dirty temporary fix so i can test further: CREATE VIEW Role AS SELECT * FROM roleWink


RE: Improved Classical Music Browsing - DaveBlake - 2016-03-10

Thanks pieterv for the feedback. Glad to have as much testing as possible of the new features while Krypton is in alpha.

I am not familiar with "Gentoo Ebuild 9999", are you using a MySQL database and on what OS? You have obviously found a case sensitivity issue, thanks for that, I'll tidy that up and be more careful in future.