Kodi Community Forum
Release CleanSubs - (Clean subtitles from the ads and other rubbish) - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Service Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=152)
+---- Thread: Release CleanSubs - (Clean subtitles from the ads and other rubbish) (/showthread.php?tid=283342)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-24

v4.1
- Bug fix



OK, I found the error, should be updated in the repo, test it and let me know Smile


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - misa - 2017-01-25

DaLanik, first of all thank you very much for this addon but I got a question.

I am using this addon together with the script autosubs and have builsdin a delay of 3 seconds, so that autosubs is searching if there is already a subtitle. When there is a subtitle the popup is not appearing. But when I use it with the delay Cleansubs is not working then.


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-25

I use autosubs as well - it only opens the subs dialog - right? So delay shouldn't matter... at least in theory Smile I don't think I have delay, but I can take a look. Do you have the last version (4.1) installed?


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - misa - 2017-01-25

I got the Autosubs with some private adjustments, so with the delay in it. PM me for the link to the zip

I needed the delay because some addons had already autosubs in it Wink


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-27

Just tested your mod of autosubs and it works for me:

Code:
10:45:51 T:9388  NOTICE: CLEANSUBS >> PLAYBACK >>PLAYING<<
10:45:51 T:9388  NOTICE: CLEANSUBS >> EXSUBS: False
10:45:51 T:9388  NOTICE: CLEANSUBS >> CUSTOM DOWNLOAD PATH: (0) D:\_DOWNLOAD\
10:45:51 T:9388  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
10:45:58 T:9388  NOTICE: CLEANSUBS >> CURRENT WINDOW 10153 - STARTING TIMER
10:45:58 T:9388  NOTICE: CLEANSUBS >> EXSUBS: False
10:45:58 T:9388  NOTICE: CLEANSUBS >> CUSTOM DOWNLOAD PATH: (0) D:\_DOWNLOAD\
10:45:58 T:9388  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
10:46:13 T:11896  NOTICE: CLEANSUBS >> SUBS ADDED >>videoplayback.sr.srt
10:46:13 T:11896  NOTICE: CLEANSUBS >> SUB STATS WILL BE ADDED TO LOCAL DATABASE
10:46:13 T:11896  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING utf-8
10:46:13 T:11896  NOTICE: CLEANSUBS >> ENC >> TRYING ENCODING cp1250
10:46:13 T:11896  NOTICE: CLEANSUBS >> ENC >> OPENED WITH ENCODING: cp1251
10:46:14 T:11896  NOTICE: CLEANSUBS >> PROCESSED IN 0.14 SECONDS, REMOVED 6 LINES
10:46:14 T:11896  NOTICE: CLEANSUBS >> SUBS PROCESSED >>videoplayback.sr.srt
10:46:14 T:9388  NOTICE: CLEANSUBS >> PLAYBACK >>RESUMED<<
10:46:14 T:9388  NOTICE: CLEANSUBS >> EXSUBS: False
10:46:14 T:9388  NOTICE: CLEANSUBS >> CUSTOM DOWNLOAD PATH: (0) D:\_DOWNLOAD\
10:46:14 T:9388  NOTICE: CLEANSUBS >> SUBTITLES DOWNLOAD PATH SET TO: 'D:\_DOWNLOAD\'
10:46:14 T:9388  NOTICE: CLEANSUBS >> STOPPING TIMER - NOT IN SUBS DIALOG ANYMORE
10:46:19 T:11896  NOTICE: CLEANSUBS >> PROVIDER LOGO FOUND: C:\Users\lanik\AppData\Roaming\Kodi\addons\service.subtitles.opensubtitles_by_opensubtitles\logo.png



RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - HeresJohnny - 2017-01-29

Any possibility to make your add-on work with NFS paths?


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-29

I use Windows and Android and have no way of testing NFS functionality.... Managed to find NFS server for Windows, but client works only on Win 10 Ultimate and I have Win 10 Pro....


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - HeresJohnny - 2017-01-29

You can use the trial version of Hanewin NFS server for testing. However, on the client side there should be no difference to smb paths IMHO.
NFS paths are natively supported by Kodi.


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-29

Strange, somehow os.walk doesn't work on NFS path.... That's why I removed it... I dunno what to do about it, not a lot of room for experiments when my OS doesn't support NFS Sad In Kodi I see nfs://192.168.1.213/c/public/ and am able to map it, there are folders inside but os.walk just doesn't show anything...

I guess xbmcvfs functions would work, but they don't have any equivalent of reading whole path with subfolders like os.walk Sad

Hm just found dirs, files = xbmcvfs.listdir(path) so will try that...


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - HeresJohnny - 2017-01-29

Just to clarify, Windows also supports NFS natively, you can enable it under Settings/Programs/Add-remove Windows components. NFS server software only comes with Windows server OS, though. Hanewin NFS server does a great job in its stead and KODI library access over NFS is faster than SMB, too.


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-30

Nope, it does not - only Ultimate or Enterprise support NFS, Professional and Home do not..... Sad But I have something working, it'll be a bit slower but It'll work.


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-01-31

v4.2
- NFS paths work in Standalone mode, arbitrary folder

OK, here is 1st version that shoud work with NFS paths, for the time being only in arbitrary folder scan, please try out and let me know. It works only on 1 subfolder level depth!

D.


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-02-01

v4.3
- Set how many lines from start/end of subtitle heuristics will clean
- Small optimizations, better exception handling


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - User 325245 - 2017-02-02

v4.4
- Improve heuristic search (thanx Peter!)


RE: CleanSubs - (Clean subtitles from the ads and other rubbish) - misa - 2017-02-02

(2017-02-02, 12:11)DaLanik Wrote: v4.4
- Improve heuristic search (thanx Peter!)

Yes I am stupid Smile But what does this mean > heuristic search