Kodi Community Forum
[Kodi 17 Krypton] RAW format - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Picture Support (https://forum.kodi.tv/forumdisplay.php?fid=265)
--- Thread: [Kodi 17 Krypton] RAW format (/showthread.php?tid=299034)

Pages: 1 2


[Kodi 17 Krypton] RAW format - drswe - 2016-12-05

can not see my photos taken in RAW format


RE: [Kodi 17 Krypton] RAW format - CiNcH - 2016-12-05

See Krypton changelog:
Code:
Removed support for RAW image decoding (with removal of CxImage as FFmpeg do not support RAW)



RE: [Kodi 17 Krypton] RAW format - drswe - 2016-12-06

okay then you can not update to krypton because I only Photograph of raw


RE: [Kodi 17 Krypton] RAW format - himisk71 - 2016-12-06

(2016-12-05, 09:43)CiNcH Wrote: See Krypton changelog:
Code:
Removed support for RAW image decoding (with removal of CxImage as FFmpeg do not support RAW)

Confused


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2016-12-06

i tried to hinder this regression but my code was "ignored" sadly.


RE: [Kodi 17 Krypton] RAW format - fritsch - 2016-12-06

(2016-12-06, 13:37)ironic_monkey Wrote: i tried to hinder this regression but my code was "ignored" sadly.

I interpreted that differently back at that time: https://github.com/xbmc/xbmc/pull/9918 (Edit: More precisely this: https://github.com/xbmc/xbmc/pull/8583 ) I think we discussed and decided some more work needs to happend so that we can support generic image addons. So my conclusion was: the addon way is the way to go and in order to properly support that, we need to provide an interface for image scaling.


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2016-12-07

right, i understood the actions as dismissal since nobody ever commented on my image addons at all when i opened the pr. it now seems i have confused myself, the pr was opened against retroplayer on request, and it's over there it went to die, https://github.com/garbear/xbmc/pull/47

i'd have to redo that header, it's nowhere to be found any more :/


RE: [Kodi 17 Krypton] RAW format - fritsch - 2016-12-07

I have high interest in bringing that back! Please PR against master and we can discuss open things (if there are any).

Edit: Looking at the code it's nice, really nice (as I have expected). Perhaps we can only check the addons if our internal available FFmpegPicture can't display it. Then could save us a bit of load / time when searching through all the addons available. As I see FCFS is used to determine the imageclass anyways I think that would be good?

Or do you see a usecase where we want to give some external imageaddon priority for formats that are supported internally, too?


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2016-12-07

yeah, it was written before the ffmpeg stuff hit mainline, so priority and such is probably not sane.

that being said, however, i think we should always prioritize externals. if you want to use libpng i'm not about to stop you, same for libjpeg(turbo) or the likes. and that would be impossible should we prioritize internal. we just need to cache that list to make the checks faster.


RE: [Kodi 17 Krypton] RAW format - fritsch - 2016-12-07

Jep, that's a good point. If user installs addons, he wants to use them.


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2016-12-07

pr opened https://github.com/xbmc/xbmc/pull/11086


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2017-01-05

it's now in a mergeable state. i have tested .cr2, .nef and .arw (just some samples from rawsamples.ch so your mileage may vary).


RE: [Kodi 17 Krypton] RAW format - fritsch - 2017-01-05

Thanks very much. Besides one minor question all fine with me.


RE: [Kodi 17 Krypton] RAW format - nerto - 2017-01-09

Is there any version for testing?


RE: [Kodi 17 Krypton] RAW format - ironic_monkey - 2017-02-08

Pr has been merged, raw image addon has been published. I have done what i can to fix the regression, distribution stuff is beyond my control.


This forum uses Lukasz Tkacz MyBB addons.