Bug - PNG image handling broken in Leia

Bug PNG image handling broken in Leia - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Bug PNG image handling broken in Leia (/showthread.php?tid=329375)

Pages: 1 2

PNG image handling broken in Leia - sualfred - 2018-03-09

Ticket already opened: https://trac.kodi.tv/ticket/17800
But to get the attention of the other skinners I'm going to post it here too.

Bug report:

I faced some empty image controls and found out that the art value is filled correctly and the images are working in a browser but not in the GUI. I guess something is broken with the image/PNG handling.

Easy to reproduce with these 2 test images:

https://i.imgur.com/E9scRif.png (doesn't work)
https://i.imgur.com/VBLJZl9.png (works)

Example code to display them in a test window

Code:
<?xml version="1.0" encoding="UTF-8"?>

<window id="1170">

<backgroundcolor>ff000000</backgroundcolor>

<controls>

     <control type="image">

          <width>200</width>

          <height>200</height>

          <texture>https://i.imgur.com/VBLJZl9.png</texture>

     </control>

     <control type="image">

          <top>250</top>

          <width>200</width>

          <height>200</height>

          <texture>https://i.imgur.com/E9scRif.png</texture>

     </control>

</controls>

</window>

Edit:
Wooohooo .. my 2000 post was a bug report ^^
I also added the images to the ticket to test it locally.

RE: PNG image handling broken in Leia - ronie - 2018-03-09

i don't see any requests being made to imgur in your Debug Log?
likely they are cached already, so please delete the tumbnail cache and recreate a Debug Log.

on my end (linux) the code you've posted works ok, both images show up fine in the gui.

RE: PNG image handling broken in Leia - sualfred - 2018-03-09

(2018-03-09, 20:07)ronie Wrote: i don't see any requests being made to imgur in your Debug Log?
likely they are cached already, so please delete the tumbnail cache and recreate a Debug Log.

on my end (linux) the code you've posted works ok, both images show up fine in the gui.

Already deleted it before. I'm facing it on my office PC and at home. Both are running Win10 and I tried x32 and x64.
But as requested I've deleted the texture db again and put the test images in a custom window. Locally and stored on imgur (4 image controls).

https://paste.ubuntu.com/p/X2WP5hT2BK/

There are a lot of fffmpeg/png errors

Code:

ERROR: ffmpeg[2810]: [png] inflate returned error -3

DEBUG: Error [-542398533] while decoding frame: Unknown error

RE: PNG image handling broken in Leia - sualfred - 2018-03-12

@ronie

Sorry to ping you, I just want to be sure you noticed my reply. Have you had the chance to take a look at it again and/or do you need any other information from me?

RE: PNG image handling broken in Leia - ronie - 2018-03-14

yup, you're latest debug log is ok, it actually displays an error this time.
i don't know whether this would be a bug in kodi or an issue in ffmpeg.

RE: PNG image handling broken in Leia - sualfred - 2018-03-14

(2018-03-14, 10:25)ronie Wrote: yup, you're latest debug log is ok, it actually displays an error this time.
i don't know whether this would be a bug in kodi or an issue in ffmpeg.

I guess FFMPEG, because it works for you on Linux which has its own ffmpeg version.

-> Re-save the same broken image as JPG = works
-> Re-save the same broken image as normal PNG via Photoshop with "biggest size / fastest saving" setting = works
-> Re-save the same broken image via Photoshop export "quick export as png" (smaller size, for web etc) = still broken

Edit:
I also analyzed the png for errors via pngcheck but they are OK. In Krytpon they are also handled correctly.

RE: PNG image handling broken in Leia - angelblue05 - 2018-03-22

I can confirm this is an issue in Leia only. Krypton works.

RE: PNG image handling broken in Leia - sualfred - 2018-04-02

@ronie
Any updates on this? Or is it on the list to be fixed later? Just want to be sure it's not going to be missed.

It's also happening on the oldest and still available nightlies on mirrors.kodi.tv. So it's broken since a long time.

RE: PNG image handling broken in Leia - badaas - 2018-04-05

Problem in both 32bit and 64bit Leia?

RE: PNG image handling broken in Leia - sualfred - 2018-04-05

@badass
yep

RE: PNG image handling broken in Leia - sualfred - 2018-04-16

Just a few screenshot how this issue affects the GUI.

RE: PNG image handling broken in Leia - sualfred - 2018-04-18

@ronie

It's the zlib.dll. It's working if I use the one of Krypton in Leia.

Edit:1.2.8 = working (Krypton)1.2.11 = broken (Leia)

I guess it's broken since this PR https://github.com/xbmc/xbmc/pull/12751 ( @wsnipex )

RE: PNG image handling broken in Leia - ronie - 2018-04-18

thanx for looking into it!

you can leave a comment on the PR to notify @Rechi of the issue

RE: PNG image handling broken in Leia - sualfred - 2018-04-18

Oops I meant to highlight Rechi instead of wsnipex. Thanks. I've commented his PR.

RE: PNG image handling broken in Leia - sualfred - 2018-04-18

False alarm. x32 is still built with 1.2.8. And Adam of zlib has no problems to decompress the test images with 1.2.11. It has to something different because it's happening on x32 and x64. I'm running out of ideas with my little knowledge of all those stuff and I don't know how can assist you guys.