Is there some sort of xml hard limit when it comes to skinning?

Is there some sort of xml hard limit when it comes to skinning? - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Is there some sort of xml hard limit when it comes to skinning? (/showthread.php?tid=330522)

Is there some sort of xml hard limit when it comes to skinning? - bkury - 2018-04-04

Thread title says it all, is there some sort of hard limit when it comes to skinning? e.g. maximum number of <controls>, <variables>, <includes>, xml code size or other tags / memory reservation for xml tags?

I have a weird problem with my skin, as soon as I load/go into more than 3 different skin windows (e.g. movies, music, addons) KODI stops rendering NEW skin windows/dialogs (text, infolabels and textures won't load/render anymore). Skin Windows that are already in memory still work fine though ...

Of course all windows/dialogs work fine on their own after a startup or ReloadSkin(), also there are no warnings or errors in KODIs (full) debug log.
Tested with Leia nightly but it also happens with Krypton stable on both Linux and Windows ...

This is a pretty big skin, so I wouldn't be surprised if I hit some sort of hard limit.
(some stats which might help to identify this problem: ~12mb xml code, 160k lines of xml code, 2k <variables>, 61k <includes/conditions>, 8k <controls>)

Any help or hint would be greatly appreciated, thanks!

RE: Is there some sort of xml hard limit when it comes to skinning? - ronie - 2018-04-04

some limits i'm aware of:
- listitem properties are limited (due to a bug) to 200: https://github.com/xbmc/xbmc/pull/8922
- variables are limited to 1000: https://github.com/xbmc/xbmc/pull/10527

RE: Is there some sort of xml hard limit when it comes to skinning? - bkury - 2018-04-04

(2018-04-04, 18:02)ronie Wrote: some limits i'm aware of:
- listitem properties are limited (due to a bug) to 200: https://github.com/xbmc/xbmc/pull/8922
- variables are limited to 1000: https://github.com/xbmc/xbmc/pull/10527

Thanks for your reply!

Is there any chance to increase these limits even further? Otherwise I'm pretty much screwed ...

Code:
fgrep -i "<variable name" *.xml | wc -l

1998

I'm already at 2k variables, not all of them are included from the start (user specific stuff) so this is possibly the reason why my skin still works at all and why it fails after loading other skin windows/dialogs.
edit: I'm also having quite a few <property name=""> tags (yes, way more than 200) ... so, this is pretty bad, right? Undecided

I know that this is a very specific issue affecting only my skin for now, but it would be great if you can address this problem ...

Thanks!

RE: Is there some sort of xml hard limit when it comes to skinning? - ronie - 2018-04-08

this pr should fix the bug that limits listitem properties:
https://github.com/xbmc/xbmc/pull/13754

i've requested to expand the range for variables to 2500 as well.

RE: Is there some sort of xml hard limit when it comes to skinning? - bkury - 2018-04-09

Thanks, I really appreciate your help!

I'm going to test it as soon as possible ...