Kodi Community Forum
Important Skinners: Please test PR13754 - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
--- Thread: Important Skinners: Please test PR13754 (/showthread.php?tid=330696)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15


Skinners: Please test PR13754 - ronie - 2018-04-08

we could use some skinners who are willing to test a pending change for Kodi Leia: 13754 (PR)
this is a rather big refactor of the code that handles infolabels, variables, boolean conditions, etc...
please check your skin(s) for unexpected behaviour.


test builds are available:

Windows:
http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20180408-cd1e3825-PR13754-merge-x64.exe

OSX:
http://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20180408-cd1e3825-PR13754-merge-x86_64.dmg

Windows:
Pre-merge build


RE: Skinners: Please test PR13754 - braz - 2018-04-09

I just tried it out for a few minutes and noticed quite a few issues...

In my Omni skin, posters aren't displaying in the video info dialog.

In jurialmunkey's Aura skin, the focused texture for the main menu doesn't work, nor do widgets labels or fanart on the video info dialog.

Will test some more as time permits...


RE: Skinners: Please test PR13754 - ronie - 2018-04-09

(2018-04-09, 01:35)braz Wrote: In my Omni skin, posters aren't displaying in the video info dialog.
 confirmed, thx! happens in Estuary as well.


RE: Skinners: Please test PR13754 - Hitcher - 2018-04-09

Only had a very quick look but so far literally no poster or fanart show up in the info dialogs.


RE: Skinners: Please test PR13754 - DaveBlake - 2018-04-09

Seems this thread got split and lost some relevent bits.

If you do spot issues with the test version, can you also check against this nightly to see that it was PR13754 that introduced the issue before reporting it:

Nightly Windows:
http://mirrors.kodi.tv/nightlies/windows/win64/master/KodiSetup-20180408-ff02b71b-master-x64.exe

Nightly OSX:
http://mirrors.kodi.tv/nightlies/osx/x86_64/master/kodi-20180408-ff02b71b-master-x86_64.dmg


RE: Skinners: Please test PR13754 - Hitcher - 2018-04-09

(2018-04-09, 08:36)Hitcher Wrote: Only had a very quick look but so far literally no poster or fanart show up in the info dialogs.
Also noticed my home screen widgets aren't displaying.

Retested with the non-PR13754 build and all the above work fine.

EDIT: I use a button to control a hidden list when setting the user rating and this no longer works either. I'll check later to see if it's because the list only has the bare minimum controls.


RE: Skinners: Please test PR13754 - ronie - 2018-04-10

the issue with missing art in info dialogs has been fixed

new test builds available:

Windows:
http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20180409-df4c7fb8-PR13754-merge-x64.exe

OSX:
http://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20180409-df4c7fb8-PR13754-merge-x86_64.dmg


see below for newer builds


RE: Skinners: Please test PR13754 - DaveBlake - 2018-04-10

With recent test build 20180409-df4c7fb8-PR13754 on win64 having issues with fullscreen player OSD during music playback. Seeing just the fanart but not the song art/album cover or player controls. Current master this all works fine.

This is with Confluence but not Estuary, so maybe just something for @Hitcher  too?


RE: Skinners: Please test PR13754 - sualfred - 2018-04-10

Gave it a quick try and I cannot find any issue in my skin atm. But it's hard to say if I missed something, because I still have a lot of missing artworks because of my reported .PNG bug (https://trac.kodi.tv/ticket/17800). 
I'll do some further investigations and let you know if I find any new issues.


RE: Skinners: Please test PR13754 - ksooo - 2018-04-10

There are new test builds, which are supposed to fix all poster/fanart regressions and there are chances that the rating issue @Hitcher reported is fixed as well:

WIN64:
http://mirrors.xbmc.org/test-builds/windows/win64/KodiSetup-20180410-a7a146e0-guiinfo-interface-x64.exe

OSX:
http://mirrors.xbmc.org/test-builds/osx/x86_64/kodi-20180410-a7a146e0-guiinfo-interface-x86_64.dmg

Would be nice to get some feedback, especially re the regressions reported so far.


RE: Skinners: Please test PR13754 - ksooo - 2018-04-10

(2018-04-10, 09:31)ronie Wrote: the issue with missing art in info dialogs has been fixed

new test builds available:

Windows:
foo

OSX:
bar
Please test the latest builds I provided:

WIN64:
http://mirrors.xbmc.org/test-builds/windows/win64/KodiSetup-20180410-a7a146e0-guiinfo-interface-x64.exe

OSX:
http://mirrors.xbmc.org/test-builds/osx/x86_64/kodi-20180410-a7a146e0-guiinfo-interface-x86_64.dmg

 For those; I do know 100% what they contain. ;-)


RE: Skinners: Please test PR13754 - DaveBlake - 2018-04-10

Test build 20180410-a7a146e0-guiinfo-interface still has the player fullscreen OSD issue during music playback with Confluence (on Win10). No player controls etc. just the fanart fullscreen. Can't tell if setting song rating works as can't get to the controls/menu.

But I am seeing posters and fanart on video info dialog now (music was always fine with art).


RE: Skinners: Please test PR13754 - ksooo - 2018-04-10

(2018-04-10, 14:47)DaveBlake Wrote: Test build 20180410-a7a146e0-guiinfo-interface still has the player fullscreen OSD issue during music playback with Confluence (on Win10). No player controls etc. just the fanart fullscreen. Can't tell if setting song rating works as can't get to the controls/menu.

But I am seeing posters and fanart on video info dialog now (music was always fine with art).
Fresh Confluence installation + testbuild a7a146e0. No probems with music OSD. Controls are there and working.


RE: Skinners: Please test PR13754 - Hitcher - 2018-04-10

(2018-04-10, 14:27)ksooo Wrote:
(2018-04-10, 09:31)ronie Wrote: the issue with missing art in info dialogs has been fixed

new test builds available:

Windows:
foo

OSX:
bar
Please test the latest builds I provided:

WIN64:
http://mirrors.xbmc.org/test-builds/windows/win64/KodiSetup-20180410-a7a146e0-guiinfo-interface-x64.exe

OSX:
http://mirrors.xbmc.org/test-builds/osx/x86_64/kodi-20180410-a7a146e0-guiinfo-interface-x86_64.dmg

 For those; I do know 100% what they contain. ;-) 
Still not working with this build.


Skinners: Please test PR13754 - ksooo - 2018-04-10

(2018-04-10, 15:48)Hitcher Wrote:
(2018-04-10, 14:27)ksooo Wrote:
(2018-04-10, 09:31)ronie Wrote: the issue with missing art in info dialogs has been fixed

new test builds available:

Windows:
foo

OSX:
bar
Please test the latest builds I provided:

WIN64:
http://mirrors.xbmc.org/test-builds/windows/win64/KodiSetup-20180410-a7a146e0-guiinfo-interface-x64.exe

OSX:
http://mirrors.xbmc.org/test-builds/osx/x86_64/kodi-20180410-a7a146e0-guiinfo-interface-x86_64.dmg

 For those; I do know 100% what they contain. ;-) 
Still not working with this build.


Okay, can you give me step by step instructions how to reproduce, please.