+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Important Skinners: Please test PR13754 (/showthread.php?tid=330696)
RE: Skinners: Please test PR13754 - ksooo - 2018-08-29
https://github.com/xbmc/xbmc/pull/14375
RE: Skinners: Please test PR13754 - scott967 - 2018-09-13
Another one to check out:
In the music window when navigating to music library - music videos - nodes when titles (mv items) displayed, prior to PR13754 ListItem.DBType was set to "musicvideo" for music video items but now ListItem.DBType is empty. However, it does correctly show "musicvideo" for mixed playlists.
Update: ListItem.DBType works correctly in the videos window.
scott s.
.
RE: Skinners: Please test PR13754 - ksooo - 2018-09-13
I found what causes the problem and will come up with a fix soon.
RE: Skinners: Please test PR13754 - ksooo - 2018-09-13
@scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20180913-2ec6b0ae-guiinfo-fix-listitem-dbtype-x64.exe
It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
RE: Skinners: Please test PR13754 - scott967 - 2018-09-14
Got your build, and looking at your branch commit on github. Give me a day to do some regression testing unless I see something sooner.
scott s.
.
RE: Skinners: Please test PR13754 - sualfred - 2018-09-14
@ksooo
ListItem.Path is incorrectly filled. It was working before this PR. Tested on the nightly of today.
ListItem.Path example
Currently (wrong): plugin://?item_id=481612aecc0d9979ff94e3775c579d3d&mode=PLAY&session_id=1536916951.69
Should be: plugin://plugin.video.embycon/
It applies to all plugin based content/items.
RE: Skinners: Please test PR13754 - ksooo - 2018-09-14
@sualfred Is the example for a music or a video item? Or a musicvideo item?
RE: Skinners: Please test PR13754 - sualfred - 2018-09-14
@ksooo
Video. But that doesn't matter. All listitems - if folder, video, audio, program, etc - in no matter what kind of media window or widget is returning the listitem.path without the plugin id.
RE: Skinners: Please test PR13754 - ksooo - 2018-09-14
This is really very strange. Do you have the chance to test with the Sept. 11 nightly?
RE: Skinners: Please test PR13754 - ksooo - 2018-09-14
NVM, no need to test Sep. 11 nightly. You said ist works with Sept 14 nightly, right?
RE: Skinners: Please test PR13754 - sualfred - 2018-09-14
@ksooo
It worked with my test setup of before this PR has been merged. http://ftp.igh.cnrs.fr/pub/xbmc/xbmc/nightlies/windows/win64/master/KodiSetup-20180408-ff02b71b-master-x64.exe
I'll give Sep. 11 a quick try. Gimme a sec.
RE: Skinners: Please test PR13754 - sualfred - 2018-09-14
@ksooo
You are right. With https://mirrors.kodi.tv/nightlies/windows/win64/master/KodiSetup-20180910-65fee744-master-x64.exe everything is fine.
RE: Skinners: Please test PR13754 - sualfred - 2018-09-14
It also works with the nightly of Sep 12. But the latest two are having the problem.
It looks like ListItem.Path is returning now the ListItem.Filenameandpath but without the addon id. Before Sep 13 it was just the addon id without arguments.
RE: Skinners: Please test PR13754 - ksooo - 2018-09-14
Wait, are we on the same page? I understood that you gave my testbuild for the listitem.dbtype a test and that this testbuild kills listitem.path?
Now I understand that latest nightly build is broken, unrelated to my testbuild?
RE: Skinners: Please test PR13754 - ksooo - 2018-09-14
Yep, https://github.com/xbmc/xbmc/pull/14409 introduced the regression. I'm out. Not related to my test build.