Kodi Community Forum
Important Skinners: Please test PR13754 - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Important Skinners: Please test PR13754 (/showthread.php?tid=330696)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

RE: Skinners: Please test PR13754 - scott967 - 2019-09-22

(2019-09-21, 17:15)jasn Wrote:
(2019-04-18, 01:13)scott967 Wrote: MusicPlayer.Position(n).xyz  appears to return MusicPlayer.xyz (ignores the "position" element).  This worked prior to 13754 (tested 18 A1)
MusicPlayer.Offset(n).UserRating returns MusicPlayer.UserRatng (ignores the "offset" element).  This didn't return anything prior to 13754.  However, MusicPlayer.Offset(n).xyz does work (before and after) for any other infolabel than UserRating (tried a few, not all possible).

scott s.
.

@scott967, Has a fix been made for this issue? Would love to see one, as it appears to be an oversight and it greatly improves the application of track ratings for displays/playlists.

Thx in advance for a reply. 
Unfortunately, no AFAIK.  I kind of stopped looking at it as I had some other priorities.  i think it probably won't be changed in Kodi 18, but might revive it in 19.

scott s.
.

RE: Skinners: Please test PR13754 - DaveBlake - 2019-09-22

I don't think that @ksooo is watching this thread for feedback anymore, afterall it is many months after the PR merged and v18 released. If there is an issue with info labels in 18.4 then I suggest you raise an issue on Github, providing a simple skin example that shows the problem. There may not be anyone with time or expertise to solve the problem, but it gives it a possibility and fixes could be backported if we do a further point release.

Meanwhile @jasn and @scott967  I will have a quick look at the problems with MusicPlayer.offset(n).UserRating and MusicPlayer.Position(n).xyz and see if anything is obvious. A simple skin that uses these info labels would help!

RE: Skinners: Please test PR13754 - DaveBlake - 2019-09-22

(2019-04-18, 01:13)scott967 Wrote: MusicPlayer.Position(n).xyz  appears to return MusicPlayer.xyz (ignores the "position" element).  This worked prior to 13754 (tested 18 A1)
MusicPlayer.Offset(n).UserRating returns MusicPlayer.UserRatng (ignores the "offset" element).  This didn't return anything prior to 13754.  However, MusicPlayer.Offset(n).xyz does work (before and after) for any other infolabel than UserRating (tried a few, not all possible).

OK, PR riased https://github.com/xbmc/xbmc/pull/16657 testing welcome @scott967 @jasn

RE: Skinners: Please test PR13754 - ksooo - 2019-09-22

> I don't think that @ksooo is watching this thread for feedback anymore

 Oh well, I do. Just found no time to check / fix this.

> OK, PR raised 16657

  Thanks for @DaveBlake for beating me on this.

RE: Skinners: Please test PR13754 - DaveBlake - 2019-09-23

(2019-09-22, 22:42)ksooo Wrote:  Oh well, I do. Just found no time to check / fix this.
Good on you @ksooo, sorry for the presumption Smile
It possibly did me good to learn a little more about the working of info labels while attmpting to fix it.

RE: Skinners: Please test PR13754 - jasn - 2019-09-23

Thanks to you all @DaveBlake @scott967 $ @ksooo for circling back to address this glitch.  With this fix I can offer a couple of improvements to developers for a couple of skins that would benefit (Aeon MQ and Ace 2).  As Dave likely knows of me from other threads, I am not a heavy programmer in Kodi, merely a LibreElec dabbler in Music related visuals and info grabbers that asks more dumb questions than good.  Has a fix been generated that I can test?  What's the best way for me to try and confirm?

Dave, if you are still looking for some examples? I can post them here (or elsewhere) if helpful or send via PM.

Thx.  jasn

RE: Skinners: Please test PR13754 - scott967 - 2019-09-24

@DaveBlake  could you fire off a windows test build for 16657?  If you think it worthwhile will give it a run through.

scott s.
.

RE: Skinners: Please test PR13754 - DaveBlake - 2019-09-26

@scott967 and @jasn the offset/position fix PR16657 is now merged (into master) so will be in the next v19 nightly. I will get down to doing a backport to v18 too sometime over the next few days.

RE: Skinners: Please test PR13754 - scott967 - 2019-10-05

I am away from home so can't access my testing setups, but I do have MusicPlayer.Offset(n).UserRating in a skin for Kodi Matrix and it is working now.  I will add some testing labels for MusicPlayer.Position when I get a chance.

scott s.
.