Important - Skinners: Please test PR13754

Important Skinners: Please test PR13754 - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Skinning (https://forum.kodi.tv/forumdisplay.php?fid=12)
+--- Thread: Important Skinners: Please test PR13754 (/showthread.php?tid=330696)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

RE: Skinners: Please test PR13754 - sualfred - 2018-04-14

Works, thanks. Both issues are fixed.

RE: Skinners: Please test PR13754 - Milhouse - 2018-04-14

I've just built LibreELEC for RPi2 now that LIRC is (mostly) fixed.

I navigated to Favourites in stock Estuary, and I'm getting this log - notice the repeating errors at the end: http://ix.io/17Jq

Edit: Ah, just realised this is with PR13754 as it is in @popcornmix's newclock5 branch so any recent updates to PR13754 may not be in newclock5.

RE: Skinners: Please test PR13754 - ksooo - 2018-04-14

(2018-04-14, 10:28)Milhouse Wrote: I've just built LibreELEC for RPi2 now that LIRC is (mostly) fixed.

I navigated to Favourites in stock Estuary, and I'm getting this log - notice the repeating errors at the end: http://ix.io/17Jq

Edit: Ah, just realised this is with PR13754 as it is in @popcornmix's newclock5 branch so any recent updates to PR13754 may not be in newclock5.

Yep, the ERRORs are definitely caused by an outdated revision of PR13754. Should all be fixed with latest code.

RE: Skinners: Please test PR13754 - Mr. V - 2018-04-14

I am having some issues with Skin.String Boolean.

Code:
Skin.String(string1,string2)

If string1 is set, it will always return 'true' regardless of what value string2 has.

Code:
String.IsEqual(Skin.String(string1),string2)

Is working ok.

RE: Skinners: Please test PR13754 - ksooo - 2018-04-14

(2018-04-14, 12:17)Mr. V Wrote: I am having some issues with Skin.String Boolean.

Code:
Skin.String(string1,string2)
If string1 is set, it will always return 'true' regardless of what value string2 has.

Can you please test that this does work in latest kodi Leia master build?

EDIT: I already found the problem. Yep, it's a regression I've introduced. Will be fixed with next test build.

RE: Skinners: Please test PR13754 - ksooo - 2018-04-14

New (hopefully really really the last before merge) test builds available:

Windows:
http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20180414-b78eb6f7-guiinfo-interface-x64.exe

OSX:
http://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20180414-b78eb6f7-guiinfo-interface-x86_64.dmg

Following issues should be fixed:
* Skin.String(string1, string2) not working : reported by @Mr. V

It would be nice if the issue reporters could retest and report back. Thanks.

Are there any other open issues? I'm not aware of any and if there are no objections I plan to merge the PR this weekend.

RE: Skinners: Please test PR13754 - Mr. V - 2018-04-15

Working now.

Cheers

RE: Skinners: Please test PR13754 - ksooo - 2018-04-15

I just merged the PR. Thanks for your support, guys.

RE: Skinners: Please test PR13754 - mikeSiLVO - 2018-04-15

Awesome!

Thanks @ksooo!

RE: Skinners: Please test PR13754 - sualfred - 2018-04-15

@ksooo

Sorry mate, found another one in the pvr guide.

Code:
<itemlayout height="83" width="60">

                        <control type="image" id="2">

                            <height>83</height>

                            <texture colordiffuse="grid_label_inprogress">common/white.jpg</texture>

                            <visible>Integer.IsGreater(ListItem.Progress,0) + Integer.IsLess(ListItem.Progress,100)</visible>

                        </control>

...

ListItem.Progress uses the value of the focused item instead of the listitem.
Easy to reproduce in Embuary if you walk through the guide.

Working in master:

Broken in your builds:

RE: Skinners: Please test PR13754 - ksooo - 2018-04-15

(2018-04-15, 18:39)sualfred Wrote: @ksooo

Sorry mate, found another one in the pvr guide.

Code:
<itemlayout height="83" width="60"> <control type="image" id="2"> <height>83</height> <texture colordiffuse="grid_label_inprogress">common/white.jpg</texture> <visible>Integer.IsGreater(ListItem.Progress,0) + Integer.IsLess(ListItem.Progress,100)</visible> </control> ...

ListItem.Progress uses the value of the focused item instead of the listitem.
Easy to reproduce in Embuary if you walk through the guide.

Thanks for letting me know. I found the problem and will open a PR for the fix.

EDIT: https://github.com/xbmc/xbmc/pull/13772

RE: Skinners: Please test PR13754 - MarcosQui - 2018-04-19

Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

Skinners: Please test PR13754 - ksooo - 2018-04-19

(2018-04-19, 01:00)MarcosQui Wrote: Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

which build do you use exactly?

RE: Skinners: Please test PR13754 - sualfred - 2018-04-19

Works on my end with the nightly of today.

RE: Skinners: Please test PR13754 - MarcosQui - 2018-04-19

(2018-04-19, 08:38)ksooo Wrote:
(2018-04-19, 01:00)MarcosQui Wrote: Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

which build do you use exactly?

In the build of April 16 does not work - KodiSetup-20180415-d23e30ed-master-x86 / KodiSetup-20180415-d23e30ed-master-x64
Already in the build on April 5th works perfectly - KodiSetup-20180405-c691ac1d-master-x86

I have not tested with other builds yet.

Ps. I only see the problem if I use the generic container (without id). If I specify the container, such as $INFO[Container(x).ListItem.Label] then it works.