+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67)
+---- Forum: Skin Archive (https://forum.kodi.tv/forumdisplay.php?fid=179)
+----- Forum: Titan (https://forum.kodi.tv/forumdisplay.php?fid=212)
+----- Thread: Mod Titan M O D ( last Updated 19-12-2019) (/showthread.php?tid=330749)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-19
(2021-10-19, 01:20)charettepa Wrote:What do you mean by "force refresh"?(2021-09-26, 17:03)burekas Wrote: Hi, @Fuchs2468
Regarding Artwork Downloader / Artwork Beef.
I made the old Artwork Downloader addon back to life with Matrix supported and some code fixes (Personally, I prefer this than Beef in the DialogVideoInfo.xml screen)
In order to be able to use it again, I made a modification on these skin files:
- 1080i / IncludesSkinSetings.xml, IncludesDialogVideoInfo.xml, IncludesDialogMusicInfo.xml
- extras / skinsettings.xml
Can you add this officialy to your skin version?
It works perfectly:
Skin xml files:
https://f2h.io/cihb4um5d76v
Artwork Downloader 15.5.0.0 (Matrix) (Made by me) :
zip: https://f2h.io/orl5efswxyia
Beef (Matrix) :
zip: https://henryjfry.github.io/repository.thenewdiamond/zips/script.artwork.beef/script.artwork.beef-0.28.6.zip
Thanks.
I followed this after updating to 19.2 and loosing my pvr artwork and info details
everything applied succesfully
however
when i perform a force refresh the artwork and details are applied to every item in the pvr list
so all shows appear to be the same
has anyone else had this issue
This is happens only in Titan or also in the default skin?
My PVR data comes from an external file that my Simple Client loads with all the relevant data (logos, url, titles etc...)
RE: Titan M O D ( last Updated 19-12-2019) - charettepa - 2021-10-19
(2021-10-19, 11:00)burekas Wrote:yes I am using titan mod for matrix (this version)(2021-10-19, 01:20)charettepa Wrote:What do you mean by "force refresh"?(2021-09-26, 17:03)burekas Wrote: Hi, @Fuchs2468
Regarding Artwork Downloader / Artwork Beef.
I made the old Artwork Downloader addon back to life with Matrix supported and some code fixes (Personally, I prefer this than Beef in the DialogVideoInfo.xml screen)
In order to be able to use it again, I made a modification on these skin files:
- 1080i / IncludesSkinSetings.xml, IncludesDialogVideoInfo.xml, IncludesDialogMusicInfo.xml
- extras / skinsettings.xml
Can you add this officialy to your skin version?
It works perfectly:
Skin xml files:
https://f2h.io/cihb4um5d76v
Artwork Downloader 15.5.0.0 (Matrix) (Made by me) :
zip: https://f2h.io/orl5efswxyia
Beef (Matrix) :
zip: https://henryjfry.github.io/repository.thenewdiamond/zips/script.artwork.beef/script.artwork.beef-0.28.6.zip
Thanks.
I followed this after updating to 19.2 and loosing my pvr artwork and info details
everything applied succesfully
however
when i perform a force refresh the artwork and details are applied to every item in the pvr list
so all shows appear to be the same
has anyone else had this issue
This is happens only in Titan or also in the default skin?
My PVR data comes from an external file that my Simple Client loads with all the relevant data (logos, url, titles etc...)
when the pvr has no artwork or the wrong artwork
you enter the context menu and choose artwork options
then you have several options but only the top 2 will help you
1- refresh auto 2- refresh manual
I guess when I said force I meant manual
if you choose auto, nothing happens at all (but worked in 19.1)
if you choose manual, you type the name, it finds the art for tmdb then finds it again for imdb or vise versa
then you are back to the pvr screen
at first its still blank then a moment later the artwork shows up
but that one that you selected is now active for every show
edit---
I can now confirm that the problem is the new (metadata and artwork module 1.0.43)
as I uninstalled Kodi
installed 19.1
updated all components one at a time verifying the pvr every time
it continues to properly get and display artwork and details
as soon as I updated the dependency (metadata and artwork module) from 1.0.42 to 1.0.43
it was broken again
starting over while kipping that dependency but upgrading everything else leaves it working
RE: Titan M O D ( last Updated 19-12-2019) - charettepa - 2021-10-19
** fixed **
the problem is a scripting error in utils.py in 1.0.43 of metadatautils
there is an issue with the if statement or condition and it causes it to have the error
line 38 and 39
if xbmc.getCondVisibility('system.platform.android')
SUPPORTS_POOL = False
it is missing a ":" at the end of the if statement
just add a ":" like below and it will work again
if xbmc.getCondVisibility('system.platform.android'):
SUPPORTS_POOL = False
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-19
@charettepa
If you think you find a bug so report that on the module git, describe there what you know so far.
RE: Titan M O D ( last Updated 19-12-2019) - charettepa - 2021-10-19
(2021-10-19, 16:04)burekas Wrote: @charettepa@burekas
If you think you find a bug so report that on the module git, describe there what you know so far.
I have just found and corrected the issue
I edited my post above
it was just a missing ":"
who do I notify to get it fixed for everyone
RE: Titan M O D ( last Updated 19-12-2019) - charettepa - 2021-10-19
(2021-10-19, 16:18)charettepa Wrote:@burekas(2021-10-19, 16:04)burekas Wrote: @charettepa@burekas
If you think you find a bug so report that on the module git, describe there what you know so far.
I have just found and corrected the issue
I edited my post above
it was just a missing ":"
who do I notify to get it fixed for everyone
weird
looks like this was reported 6 days ago by Viper67857
https://github.com/kodi-community-addons/script.module.metadatautils/commit/20471de3c698e1e123194789e7e8484f1e116d11
with correct syntax
but the file pushed by the addons update is missing the ":" at the end of the if statement
it looks like it was accepted and merged but its getting pushes without the ":"
how would i make a pull request on something that is already done and correct but its not pushing out that way
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-19
@Fuchs2468
Summary of my PRs until now:
PR #1: Artwork Downloader additional support.
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/3
PR #2: A new one with some fixes regarding the view modes: Such as Live TV preview fixes, etc..
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/4
PR #3: New color setting for widgets panel background for No Focus state (Currently relevant for SingleBox widget layout)
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/5
PR #4: A new colors settings for Main Settings window:
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/6
PR #5: Fix the presentation of the arrow back images
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/7
PR #6: Dialog Addon Info - "Versions" button fixed and buttons order changed
https://github.com/Fuchs246/skin.titan.mod.beta.matrix/pull/8
* Note: Each of the PRs is separated and independent, relative to the current code in the repo (19.10.2021)
For now I fix/modify what I can and know.
If you have question or something isn't clear enough, please ask.
Thanks.
RE: Titan M O D ( last Updated 19-12-2019) - mombasa123 - 2021-10-20
Just thinking, given that Titan Mod is well & alive on Matrix with all the work @Fuchs2468 has done, this forum should be moved out of archive and to the 'live' one no?
Kodi Forum Admin should be made aware no?
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-20
(2021-10-20, 09:53)mombasa123 Wrote: Just thinking, given that Titan Mod is well & alive on Matrix with all the work @Fuchs2468 has done, this forum should be moved out of archive and to the 'live' one no?I agree with you.
Kodi Forum Admin should be made aware no?
As a fan of Titan since its first days I think that Marcel (@"marcelveldt") did here a great job with this skin.
These days I think this skin is back to live thanks to @mardukL and @Fuchs2468.
I was a long time stuck with Kodi 17.6 because there was always some differences between Marcel original work and the Mods that were here.
This Mod here is the most identical to the original one and of course it's a Matrix supported.
Regarding the differences that I still notice I'm trying to fix by myself (If I know how. I'm studing the relevant code for each case), as you can see in my last comments here.
The issue is that there are two or three main Mods here,
I think we should decide which one is going to be the main one as it was before (3.5.x, 3.6.x, 3.7.x (kodi 17) ,3.8.x, (kodi 18), 3.9.x for Matrix...)
* In my opinion the Mod here should be the main one.\
And then ask the admins to return it.
RE: Titan M O D ( last Updated 19-12-2019) - Fuchs2468 - 2021-10-21
Hi Guys
It's nothing forgotten.
I work on the skin, at the moment I can not test as much as I would like.
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-22
(2021-10-21, 00:49)Fuchs2468 Wrote: Hi Guys
It's nothing forgotten.
I work on the skin, at the moment I can not test as much as I would like.
Hi,
What do you mean by "work on the skin"?
New things or bugs?
Becaue maybe there are things that I also think about to fix (As you can see in my PRs above)
RE: Titan M O D ( last Updated 19-12-2019) - Fuchs2468 - 2021-10-23
(2021-10-22, 01:05)burekas Wrote:(2021-10-21, 00:49)Fuchs2468 Wrote:
Hi,
What do you mean by "work on the skin"?
New things or bugs?
Becaue maybe there are things that I also think about to fix (As you can see in my PRs above)
I work on new things and bugs (and your PRs).
I have discovered a mistake in "script.skin.helper.service", which I have to report Angelinas first off.
Bug in "listitem_monitor.py" is "!IsEmpty":
python:# media window is opened or widgetcontainer set - start listitem monitoring!
elif getCondVisibility("Window.IsMedia | "
"!IsEmpty(Window(Home).Property(SkinHelper.WidgetContainer))"):
I have made a small change in "script.skin.helper.service", "Fix the Presentation of the Arrow Back Images # 7" is no longer necessary Through this.
My change in "Listitem_monitor.py":
python:# media window is opened or widgetcontainer set - start listitem monitoring!
elif getCondVisibility("[Window.IsMedia | "
"!String.IsEmpty(Window(Home).Property(SkinHelper.WidgetContainer))] + "
"!String.IsEqual(ListItem.Label,..) + "
"Control.HasFocus(77777)"):
This change also fixes other bugs in the skin.
It must still tested intensively.
To test "script.skin.helper.service" listitem_monitor.py replace: listitem_monitor.py
Update: edit listitem_monitor.py
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-23
@Fuchs2468
Thanks, I will check this out.
I'm mostly touching the skin files and less the "script.skin.helper.service" files, so I wasn't aware of this.
By thw way, If you can write down some of the bugs your are working on it will be nice,
So I won't start working on bugs we both noticed and you already work on them.
____________________________________________________________________________________________________________
I'm getting an error using your new listitem_monitor.py file:
(Tested with Kodi Matrix 19.2)
Code:
ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'ModuleNotFoundError'>
Error Contents: No module named 'thread'
Traceback (most recent call last):
File "D:\Program Files (x86)\Kodi v19.1 x64 Nightly\portable_data\addons\script.skin.helper.service\service.py", line 10, in <module>
from resources.lib.main_service import MainService
File "D:\Program Files (x86)\Kodi v19.1 x64 Nightly\portable_data\addons\script.skin.helper.service\resources\lib\main_service.py", line 13, in <module>
from resources.lib.listitem_monitor import ListItemMonitor
File "D:\Program Files (x86)\Kodi v19.1 x64 Nightly\portable_data\addons\script.skin.helper.service\resources\lib\listitem_monitor.py", line 11, in <module>
import thread
ModuleNotFoundError: No module named 'thread'
-->End of Python script error report<--In my previous file the condition was:
Code:
if sys.version_info.major == 3:
import _thread as thread
else:
import threadNow there is only:
Code:
import threadRE: Titan M O D ( last Updated 19-12-2019) - Fuchs2468 - 2021-10-23
(2021-10-23, 13:15)burekas Wrote: In my previous file the condition was:
Code:if sys.version_info.major == 3:
import _thread as thread
else:
import thread
Now there is only:
Code:import thread
Sorry it was the wrong version.
Here is the right one. listitem_monitor.py (Kodi 19)
The other version was for Kodi 18.
RE: Titan M O D ( last Updated 19-12-2019) - burekas - 2021-10-23
(2021-10-23, 18:24)Fuchs2468 Wrote:Ok, so I tried your change.(2021-10-23, 13:15)burekas Wrote: In my previous file the condition was:
Code:if sys.version_info.major == 3:
import _thread as thread
else:
import thread
Now there is only:
Code:import thread
Sorry it was the wrong version.
Here is the right one. listitem_monitor.py (Kodi 19)
The other version was for Kodi 18.
But it didn't fix the issue I mentioned in "Fix the Presentation of the Arrow Back Images # 7" , my PR is still required.