[Leia] Whitelist and interlaced output issue - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111) +---- Forum: Linux (https://forum.kodi.tv/forumdisplay.php?fid=52) +---- Thread: [Leia] Whitelist and interlaced output issue (/showthread.php?tid=332857) |
[Leia] Whitelist and interlaced output issue - the-dreamer - 2018-06-16 @fritsch, @lrusak, @FernetMenta, i want to continue the discussion which i have started here: https://github.com/xbmc/xbmc/pull/13274 after debug logging and code review i came to the conclusion that interlaced output is not feeded in Kodi anymore in the internal resolution list. I have an override rule in advancedsetting which is also not working anymore. Here a debug log from start: http://ix.io/1dut kodi-xrandr is working like before and has my interlace resolution included. <mode id="0x49" name="1920x1080i" w="1920" h="1080" hz="30.00000" current="false" preferred="true"/> <mode id="0x4d" name="1920x1080i" w="1920" h="1080" hz="25.00000" current="true" preferred="false"/> <mode id="0x4e" name="1920x1080i" w="1920" h="1080" hz="29.97010" current="false" preferred="false"/> As i understood, RES_DESKTOP is always included which made me possible to get any picture to my tv. But as mentioned already, when i select from Resolution dialog 1080i kodi switched to an unsupported resolution for my tv(60p). i could only get select 25p after i have connected to systemc via vnc. when i have switched to 30p via kodi-xrandr i could only select 30p. 25p dissapear. when i start a 23.97 movie i have following output with 25p: 23:10:36.761 T:139730418378880 DEBUG: ------ Window Init (VideoFullScreen.xml) ------ 23:10:36.761 T:139730418378880 INFO: Loading skin file: VideoFullScreen.xml, load type: KEEP_IN_MEMORY 23:10:36.765 T:139730418378880 DEBUG: Found Resolution 1920x1080@ 25.00 - Full Screen (16) from fallback (refreshmin:24.990 refreshmax:25.010) 23:10:36.765 T:139730418378880 NOTICE: Display resolution ADJUST : 1920x1080@ 25.00 - Full Screen (16) (weight: 0.043) same video with 30p via xrandr: 23:12:22.309 T:139730418378880 DEBUG: ------ Window Init (VideoFullScreen.xml) ------ 23:12:22.311 T:139730418378880 DEBUG: Trying to find exact refresh rate 23:12:22.311 T:139730418378880 DEBUG: No exact whitelisted resolution matched, trying double refresh rate 23:12:22.311 T:139730418378880 DEBUG: No double refresh rate whitelisted resolution matched, trying current resolution 23:12:22.311 T:139730418378880 DEBUG: No larger whitelisted resolution matched, trying current resolution with double refreshrate 23:12:22.311 T:139730418378880 DEBUG: No whitelisted resolution matched 23:12:22.311 T:139730418378880 NOTICE: Display resolution ADJUST : 1920x1080@ 30.00 - Full Screen (16) (weight: -28558484583144905327075535595264540672.000) I have nothing selected in whitelist. Also Whitelist has no interlaced frequencies. I tried to find the issue in code but have not found it yet. If you need more information, please let me know. System: x86_64/libreelec build from master on 9 june RE: [Leia] Whitelist and interlaced output issue - fritsch - 2018-06-16 https://github.com/xbmc/xbmc/blob/master/xbmc/settings/DisplaySettings.cpp#L687 Kodi cannot output interlaced. It renders full frames. Therefore "interlaced modes" which are fields not frames are skipped. If you think to know better what your TV does, add a custom mode to xorg.conf with 25 hz progressive. Quote:fritsch@L380:~$ gtf 1920 1080 25 RE: [Leia] Whitelist and interlaced output issue - the-dreamer - 2018-06-16 Yes i know Kodi is outputting only full frames. 1080@25p is not possible on my tv. Already tried it in the past. i don't complain the output is not the best, when have interlaced output. I complain i cannot choose it anymore. But maybe i found the bug at least one bug: https://github.com/xbmc/xbmc/blob/f43d6db5d5d3a9d8971b5c01bfe689fbafbaacac/xbmc/settings/DisplaySettings.cpp#L612 the string format has been changed from SWWWWWHHHHHRRR.RRRRRP333 to WWWWWHHHHHRRR.RRRRRP333 and the resolution and refresh was adapted but everything after line 620 would needed also be moved for one character. So the interlace and 3d mode won't get detected anymore here. RE: [Leia] Whitelist and interlaced output issue - fritsch - 2018-06-16 I linked you the line where interlaced modes are skipped in the whitelist. RE: [Leia] Whitelist and interlaced output issue - fritsch - 2018-06-16 The bug you found is valid. I will fix it. Thx for that. RE: [Leia] Whitelist and interlaced output issue - the-dreamer - 2018-06-16 (2018-06-16, 09:17)fritsch Wrote: I linked you the line where interlaced modes are skipped in the whitelist.is this intentionally done? Whitelist is not working with interlanced refresh rates? RE: [Leia] Whitelist and interlaced output issue - fritsch - 2018-06-16 (2018-06-16, 10:10)the-dreamer Wrote:I try again: kodi only outputs progressive. We don't want to have interlaced mode used at all.(2018-06-16, 09:17)fritsch Wrote: I linked you the line where interlaced modes are skipped in the whitelist.is this intentionally done? Whitelist is not working with interlanced refresh rates? RE: [Leia] Whitelist and interlaced output issue - the-dreamer - 2018-06-17 That the whitelist has no interlace resolution support is fine for me. With your fix my problem is solved. I can select all resolution with 25p/29.97p/30p. fps override from my advance settings is also working again. Thank you! RE: [Leia] Whitelist and interlaced output issue - fritsch - 2018-06-17 (2018-06-17, 11:33)the-dreamer Wrote: That the whitelist has no interlace resolution support is fine for me. With your fix my problem is solved. I can select all resolution with 25p/29.97p/30p. fps override from my advance settings is also working again. Thank you!You are welcome. |