Infolabel for skin name - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: Skins Support (https://forum.kodi.tv/forumdisplay.php?fid=67) +--- Thread: Infolabel for skin name (/showthread.php?tid=342740) |
Infolabel for skin name - edit4ever - 2019-04-05 Is there not a way to easily pull the skin name for use in conditional visibility? I see options for theme/color/font/string/aspect-ratio but nothing to grab the current active skin name. I'm hoping I am missing something - or maybe this could be an easy add? I would like to be able to hide/show certain controls/windows based on the active skin. Thanks! RE: Infolabel for skin name - Hitcher - 2019-04-05 Show them in what? If it's an addon then just use the resources/skins/ folder and make a skin folder for each the skin you want to have different designs for. RE: Infolabel for skin name - edit4ever - 2019-04-05 Wouldn't that mean a lot of duplicate code? IN this case - the way the addon was built references a couple of Estuary's includes and variables (like Top Bar, Bottom Bar, HomeFanartVar,etc). I'm looking to just ignore/replace those couple of lines for a skin like confluence (which doesn't have the same includes and variables) using the condition/visible options. It seems like that would be simpler and less code to execute than recreating for each skin. I wrote a patch that I believe would work - but I don't have access to a build system right now to test. https://github.com/edit4ever/xbmc/commit/2a064b053487482cb824344ae6d7c529ada9b3b7 I realize that the likely fix is skinners should be building off the Estuary naming convention - but there are a lot of older/other skins that are being adapted and I'm trying to keep things looking good/working. Maybe there's a better way I'm missing? RE: Infolabel for skin name - edit4ever - 2019-04-07 Ignore the previous patch - it was a mess due to whitespace cleaning. I sill believe it can be handy to be able to use the skin name as an infolabel. Here is a patch that adds this functionality: Code:
I hope you can consider adding this! RE: Infolabel for skin name - Hitcher - 2019-04-07 If you're running an addon can't it read the guisettings.xml to find out which skin is currently be used?
Also, best way to get your patch seen is to make a pull request on GitHub. RE: Infolabel for skin name - ronie - 2019-04-07 not sure if it suits your needs, but python addons can use:
RE: Infolabel for skin name - edit4ever - 2019-04-07 Thanks for the suggestions - I'm not dealing with the python files in the addon - but the xml files that control the windows. There are a lot of references to specific includes that exist in Estuary that do not exist in other skins. Therefore, I'm looking to disable those functions so the other skins don't fill the log with errors. I'll update the patch (there were Kodi 18.1 changes) and submit a PR after testing. |