(2019-12-21, 16:45)bsoriano Wrote: @jurialmunkey , I am testing the latest version from GitHub running in the latest Matrix nightly.  I am getting the following error whenbrowsing the plugin and trying to get details for a cast member:

(2019-12-21, 13:27)nessus Wrote: The only info that are missing now are the media flags, eg ListItem.VideoResolution for the local items.
...
What about this one?

(2019-12-21, 19:51)nessus Wrote: That's fine. I am already closing the info dialog when an item is playable. IMHO this is proper behavior and makes it clear to the user that it opens the info dialog for a different item. If you don't want to add this then we will need a click action to run the script and show the video info for that clicked item.

1. Use the custom window implementation for TMDbHelper as done in AZ2
   
2. Use Sualfred's extended info replacement "script.embuary.info" - https://forum.kodi.tv/showthread.php?tid=346034
   

xml:


<?xml version="1.0" encoding="UTF-8"?>

<window type="window" id="1137">

    <defaultcontrol always="true">9999</defaultcontrol>

    <controls>

        <control type="button" id="9999">

            <onfocus>ReplaceWindow(1136)</onfocus>

        </control>

    </controls>

</window>

xml:


<?xml version="1.0" encoding="UTF-8"?>

<window type="window" id="1136">

    <defaultcontrol always="true">9999</defaultcontrol>

    <controls>

        <control type="list" id="9999">

            <width>1</width>

            <height>1</height>

            <left>-1000</left>

            <top>-1000</top>

            <onfocus condition="!Integer.IsEqual(Container(9999).NumItems,0) + !Container(9999).IsUpdating + !String.IsEmpty(Window(Home).Property(TMDbHelper.Path.Current))">Action(Info)</onfocus>

            <onfocus condition="[Integer.IsEqual(Container(9999).NumItems,0) | Container(9999).IsUpdating] + !String.IsEmpty(Window(Home).Property(TMDbHelper.Path.Current))">AlarmClock(doinfo,SetFocus(9999),00:01,silent)</onfocus>

            <onfocus condition="String.IsEmpty(Window(Home).Property(TMDbHelper.Path.Current))">Action(Back)</onfocus>

            <itemlayout />

            <focusedlayout />

            <content limit="1" target="videos">$INFO[Window(Home).Property(TMDbHelper.Path.Current)]</content>

        </control>

    </controls>

</window>

(2019-12-22, 01:32)jurialmunkey Wrote:

(2019-12-21, 13:27)nessus Wrote: The only info that are missing now are the media flags, eg ListItem.VideoResolution for the local items.
...
What about this one?

Would only be available if I merged local info with online info, which I'm avoiding. If it is something that is desperately needed, I could add a param to merge with local info but it will add additional overhead.  

(2019-12-22, 01:32)jurialmunkey Wrote: This method will keep a history of the paths used. Look at AZ2 for some advanced tricks that I do to add actor info page (https://github.com/jurialmunkey/skin.arctic.zephyr.2/blob/master/1080i/Custom_1136_TMDB_Info.xml) and also add paths for local items into the history by using some additional onclick actions and url encoded library nodes (https://github.com/jurialmunkey/skin.arctic.zephyr.2/blob/master/1080i/Includes_Defs.xml#L96-L106) - though these are both advanced features that aren't necessary. The above implementation will work to replace extended info.

(2019-12-22, 13:11)nessus Wrote: I understand, but in my dialog layout i have a place holder for media flags when it's open from videos section (on movies & episodes) and that will be empty when opened from widgets. Can you add that param to test it?. My system it's not so new and powerful so i can have good picture if the additional overhead notically affects the performance.

(2019-12-22, 13:11)nessus Wrote: Now...TV Shows widgets questions:
1. The ListItem.DBID it's empty for all TMDB tv shows lists. In Trakt lists  it's working fine.
3. I always missed the trailer option for tv shows from most of the scrapers. On my surprise with your plugin shows the trailers for tv shows. The weird thing is that are available only in widgets lists. In video library are missing for all shows (cached or not) even for shows that are in one of the widgets lists. Can this be fixed.

(2019-12-23, 03:51)nessus Wrote: You see the missing ListItem.Trailer in tv shows (which is missing from all shows in tv shows section)

(2019-12-23, 03:51)nessus Wrote: ... and the missing DBID in widgets ("Trending TV SHows" in this case) ...

(2019-12-23, 04:37)jurialmunkey Wrote: "videodb://tvshows/titles" - The mystery is solved! That's not a path from the plugin. Only scrapers can change values in your library.
That's the whole reason why Window(Home).Property(TMDbHelper.ListItem.Infolabel) is needed in the first place!
If I could edit listitems directly, I would.

(2019-12-23, 04:37)jurialmunkey Wrote: DBID shows fine for me on trending tv shows widget.

(2019-12-23, 04:40)jurialmunkey Wrote: @nessus - Also, can you test latest commit. I've added an option in settings to retrieve additional details from local kodi db, so you should get codec info for dbid items with that on. Let me know if the setting is enough or if you also need a per widget param.

(2019-12-23, 12:40)nessus Wrote: Yea... for all the others except... "Game of Thrones". This is the only show that for some weird reason the DBID is empty. Not a big issue but i am curious why it happens only for this one. My DBID checking (in home.xml) it's working properly because like i said, in all the others it's showing fine.

(2019-12-23, 12:40)nessus Wrote: Well, i don't see any noticeable overhead with setting enabled. It will be nice to have a widget param for this so if the skinner wants it can work out of the box.

(2019-12-20, 22:52)jurialmunkey Wrote: Sorry I misunderstood what you were suggesting. You can already change the default action to play with the &widget=True param.
This param makes Movies|Episode = Play and TvShows = Browse Seasons.

(2019-12-24, 10:15)nessus Wrote: The TvShows = Browse Seasons action it's not working. Movies|Episode = Play it's working fine. Don't know if it was like that from the beginning or it broke after the latest commits. Can you please check it out?

xml:


<onclick condition="ListItem.IsFolder">Dialog.Close(12003)</onclick>

<onclick condition="ListItem.IsFolder + Window.IsVisible(MyVideoNav.xml)">Container.Update($INFO[ListItem.FolderPath])</onclick>

<onclick condition="ListItem.IsFolder + !Window.IsVisible(MyVideoNav.xml)">ActivateWindow(videos,$INFO[ListItem.FolderPath],return)</onclick>

(2019-12-24, 10:15)nessus Wrote: EDIT: Also ListItem.Property(UnWatchedEpisodes) is empty in widgets lists. The &widget=True and &localdb=True param are set and working properly.

(2019-12-24, 23:35)jurialmunkey Wrote: You need an onclick action that closes the info dialog and opens the folderpath. Any info dialog widget with folder items, regardless of whether it is from a plugin or local library, will require a custom onclick action that closes the info dialog and then opens the folder path for it to work.

(2019-12-20, 22:52)jurialmunkey Wrote: You can already change the default action to play with the &widget=True param. This param makes Movies|Episode = Play and TvShows = Browse Seasons.

Quote:I wasn't merging any watched information, just the scraped metadata - but I can merged watched status if you like.

(2019-12-25, 02:49)nessus Wrote: Sorry, i was not clear enough in my message. I didn't mean Browse from inside the info dialog. I meant from outside, in widget lists, when you click on an item that is in the local library....

xml:
<onclick condition="!String.IsEmpty(ListItem.DBID) + String.IsEqual(ListItem.DBType,tvshow)">ActivateWindow(videos,videodb://tvshows/titles/$INFO[ListItem.DBID]/,return)</onclick>

(2019-12-25, 02:49)nessus Wrote: Didn't those were the default actions provided by the script when clicking on widget item ?

(2019-12-25, 02:49)nessus Wrote: If it is not so much trouble i would like to have the option to show these for local items in widgets lists.

(2019-12-25, 02:49)nessus Wrote: EDIT: Also ListItem.MPAA in TV Shows widgets lists it's empty for non-local library items.

xml:


<!-- Custom Cast panel item: either container 50 (default) or container 5100 (tmdb online info) -->

    <include name="CustomCastItemOnline">

        <param name="CastListItemID" />

        <definition>

            <item>

                <label>$INFO[Window(Home).Property(TMDbHelper.ListItem.Cast.$PARAM[CastListItemID].Name)]</label>

                <label2>$INFO[Window(Home).Property(TMDbHelper.ListItem.Cast.$PARAM[CastListItemID].Role)]</label2>

                <icon>$INFO[Window(Home).Property(TMDbHelper.ListItem.Cast.$PARAM[CastListItemID].Thumb)]</icon>

                <visible>!String.IsEmpty(Window(Home).Property(TMDbHelper.ListItem.Cast.$PARAM[CastListItemID].Name))</visible>

            </item>

        </definition>

    </include>

    <!-- Custom Cast panel items -->

    <include name="CustomCastListContentOnline">

        <include content="CustomCastItemOnline">

            <param name="CastListItemID">1</param>

        </include>

        <include content="CustomCastItemOnline">

            <param name="CastListItemID">2</param>

        </include>

        <include content="CustomCastItemOnline">

            <param name="CastListItemID">3</param>

        </include>

        <include content="CustomCastItemOnline">

            <param name="CastListItemID">4</param>

        </include>

        <include content="CustomCastItemOnline">

            <param name="CastListItemID">5</param>

    </include>

    <!-- Cast Panel: Always use a custom cast to have control over actions -->

    <include name="CustomCast">

        <control type="group" id="90049">

            <top>44</top>

            <height>44</height>

            <visible>Container(90050).IsUpdating | Integer.IsGreater(Container(90050).NumItems,0) | String.IsEmpty(Window(Home).Property(TMDbHelper.IsUpdating))</visible>

            <control type="label">

                <left>8</left>

                <top>0</top>

                <height>30</height>

                <label>$LOCALIZE[206] $INFO[Container(90050).NumItems,(,)]</label>

                <font>ListDetails</font>

            </control>

            <control type="image" description="Line Split">

                <top>40</top>

                <left>10</left>

                <width>1180</width>

                <height>1</height>

                <texture>img/LineL.png</texture>

                <aspectratio>stretch</aspectratio>

            </control>

        </control>    

        <control type="panel" id="90050">

            <top>44</top>

            <left>10</left>

            <width>1180</width>

            <height>410</height>

            <onup>9000</onup>

            <onback>9000</onback>

            <preloaditems>2</preloaditems>

            <scrolltime tween="quadratic" easing="out">300</scrolltime>

            <orientation>horizontal</orientation>

            <visible>Container(90050).IsUpdating | Integer.IsGreater(Container(90050).NumItems,0) | String.IsEmpty(Window(Home).Property(TMDbHelper.IsUpdating))</visible>

            <!-- select online tmdb search or local search -->

            <onclick>SetProperty(Dialog.1.Label,$LOCALIZE[32018])</onclick>

            <onclick>SetProperty(Dialog.1.BuiltIn,RunScript(plugin.video.themoviedb.helper,add_query=$INFO[Container(90050).ListItem.Label],type=person,call_id=1129,prevent_del))</onclick>

            <onclick>SetProperty(Dialog.2.Label,$LOCALIZE[32017])</onclick>

            <onclick>SetProperty(Dialog.2.BuiltIn,Skin.SetString(CustomSearchTerm,$ESCINFO[Container(90050).ListItem.Label])||Dialog.Close(all)||ActivateWindow(1122))</onclick>

            <onclick>RunScript(script.embuary.helper,action=createselect,header=$LOCALIZE[137])</onclick>

            <include content="ActorLayout">

                <param name="viewid">90050</param>

            </include>

            <content>

                <include>CustomCastListContentOnline</include>

            </content>

        </control>

    </include>