(2020-01-14, 19:28)nessus Wrote: I have another one.... when browsing inside TMDB Helper Addon lists or by selecting one of them as widget through skin shortcuts select widget dialog, the media flags are empty. All the other info are showing fine except this one. Is this too much of hassle to add?

xml:


<onclick>SetProperty(SingleSearchType,OnlineTotals,Home)</onclick>

<onclick>Skin.SetString(SingleSearchID,$INFO[ListItem.Property(tmdb_id)])</onclick>

<onclick>Skin.SetString(SingleSearchTerm,$INFO[ListItem.Label])</onclick>

<onclick>Skin.SetString(OnlineTotalsCall,crew_in_movies)</onclick>

<onclick>Skin.SetString(SingleSearchHeader,$LOCALIZE[32201])</onclick>

<onclick>Dialog.Close(movieinformation)</onclick>

<onclick>ActivateWindow(1131)</onclick>

(2020-01-15, 23:14)jurialmunkey Wrote: @bsoriano -

If you close the videoinfo dialog, the script thinks that you are pressing back, which removes the current path and replaces it with the previous path (or nothing if its the first).
If you close window 1134 the script clears all properties and exits. Activating another window closes the current window.
Basically, you can't close 1134 or videoinfo if you would like to keep the script active.

What might work is if you change your search window to a dialog and just open it on top of the videoinfo dialog without closing videoinfo or 1134. i.e. Remove the Dialog.Close onclick and add the following to your search window:

Code:

<window type="dialog" id="1131">

RE: Repo.
I have a repo with TMDbHelper beta versions maintained by @drinfernoo
https://jurialmunkey.github.io/repository.jurialmunkey/repository.jurialmunkey-1.2.zip

It is currently on 2.2.16 but it will get updated soon with the most recent version.
I'll be making a PR to official repo with the latest updates in the next week - just need to do a little bit more testing to make sure all the latest changes are stable.

(2020-01-15, 13:03)jurialmunkey Wrote:

(2020-01-14, 19:28)nessus Wrote: I have another one.... when browsing inside TMDB Helper Addon lists or by selecting one of them as widget through skin shortcuts select widget dialog, the media flags are empty. All the other info are showing fine except this one. Is this too much of hassle to add?

By media flags, do you mean codec info? Because that's working fine for me for items in the library (as long as the option for kodi library info is enabled in TMDbHelper settings) 

(2020-01-15, 23:38)bsoriano Wrote:

(2020-01-15, 23:14)jurialmunkey Wrote: @bsoriano -

If you close the videoinfo dialog, the script thinks that you are pressing back, which removes the current path and replaces it with the previous path (or nothing if its the first).
If you close window 1134 the script clears all properties and exits. Activating another window closes the current window.
Basically, you can't close 1134 or videoinfo if you would like to keep the script active.

What might work is if you change your search window to a dialog and just open it on top of the videoinfo dialog without closing videoinfo or 1134. i.e. Remove the Dialog.Close onclick and add the following to your search window:

Code:

<window type="dialog" id="1131">

RE: Repo.
I have a repo with TMDbHelper beta versions maintained by @drinfernoo
https://jurialmunkey.github.io/repository.jurialmunkey/repository.jurialmunkey-1.2.zip

It is currently on 2.2.16 but it will get updated soon with the most recent version.
I'll be making a PR to official repo with the latest updates in the next week - just need to do a little bit more testing to make sure all the latest changes are stable.

@jurialmunkey , thanks! I will be trying this right away.  Understood about your repo; I will place a link to it in the Amber thread.

Regards,

Bart

EDIT: @jurialmunkey, thatnks again, this solved the navigation issue.  However, it brought other issues, like the fact that ListItem.xxxx now is the one from dialogvideoinfo.xml and not from the custom search window.  I solved that by replacing with Container.ListItem.xxxx.  What I have not solved is that now, if it is an online tmdb custom search, when you press i on any of the items, nothing happens, until I press Back or Esc, and then the info for that movie is shown.  Since the custom search is now a dialog and not a window, do I need to add a custom onclick to the results panel/list? Do I need to close the dialog for tmdb helper to properly open the info for the item?

A similar issue is happening if the custom search is local.  If I press Enter, the movie starts playing, but in the background.  I figure I can solve this like in the video info dialog Play/Close/Browse button.  However, if I press i, I do not get an info dialog for the item, until I press Back or Esc, and then it is shown.

Any ideas? Thanks again for your help.

(2020-01-16, 16:51)nessus Wrote:

(2020-01-15, 13:03)jurialmunkey Wrote:

(2020-01-14, 19:28)nessus Wrote: I have another one.... when browsing inside TMDB Helper Addon lists or by selecting one of them as widget through skin shortcuts select widget dialog, the media flags are empty. All the other info are showing fine except this one. Is this too much of hassle to add?

By media flags, do you mean codec info? Because that's working fine for me for items in the library (as long as the option for kodi library info is enabled in TMDbHelper settings)

Yes, codec, resolution etc. Indeed, it's working with that setting enabled but i was looking for some more out-of-the-box solution. But then again if it's too much hassle... no problem. Leave it like it is

Cheers
Nessus

(2020-01-17, 00:56)jurialmunkey Wrote:

(2020-01-15, 23:38)bsoriano Wrote:

(2020-01-15, 23:14)jurialmunkey Wrote: @bsoriano -

If you close the videoinfo dialog, the script thinks that you are pressing back, which removes the current path and replaces it with the previous path (or nothing if its the first).
If you close window 1134 the script clears all properties and exits. Activating another window closes the current window.
Basically, you can't close 1134 or videoinfo if you would like to keep the script active.

What might work is if you change your search window to a dialog and just open it on top of the videoinfo dialog without closing videoinfo or 1134. i.e. Remove the Dialog.Close onclick and add the following to your search window:

Code:

<window type="dialog" id="1131">

RE: Repo.
I have a repo with TMDbHelper beta versions maintained by @drinfernoo
https://jurialmunkey.github.io/repository.jurialmunkey/repository.jurialmunkey-1.2.zip

It is currently on 2.2.16 but it will get updated soon with the most recent version.
I'll be making a PR to official repo with the latest updates in the next week - just need to do a little bit more testing to make sure all the latest changes are stable.

@jurialmunkey , thanks! I will be trying this right away.  Understood about your repo; I will place a link to it in the Amber thread.

Regards,

Bart

EDIT: @jurialmunkey, thatnks again, this solved the navigation issue.  However, it brought other issues, like the fact that ListItem.xxxx now is the one from dialogvideoinfo.xml and not from the custom search window.  I solved that by replacing with Container.ListItem.xxxx.  What I have not solved is that now, if it is an online tmdb custom search, when you press i on any of the items, nothing happens, until I press Back or Esc, and then the info for that movie is shown.  Since the custom search is now a dialog and not a window, do I need to add a custom onclick to the results panel/list? Do I need to close the dialog for tmdb helper to properly open the info for the item?

A similar issue is happening if the custom search is local.  If I press Enter, the movie starts playing, but in the background.  I figure I can solve this like in the video info dialog Play/Close/Browse button.  However, if I press i, I do not get an info dialog for the item, until I press Back or Esc, and then it is shown.

Any ideas? Thanks again for your help.    

You will need to close your search dialog window first before any actions. To open info you will need to run the call_auto method after

Code:


<onclick>Dialog.Close(1131)</onclick>
<onclick>RunScript(plugin.video.themoviedb.helper,add_path=$INFO[ListItem.FolderPath],call_auto=1134)</onclick>


You won't be able to do anything about <oninfo> - so you will need to make a decision about whether keeping the script active is more important.
 

(2020-01-16, 16:51)nessus Wrote:

(2020-01-15, 13:03)jurialmunkey Wrote: By media flags, do you mean codec info? Because that's working fine for me for items in the library (as long as the option for kodi library info is enabled in TMDbHelper settings)

Yes, codec, resolution etc. Indeed, it's working with that setting enabled but i was looking for some more out-of-the-box solution. But then again if it's too much hassle... no problem. Leave it like it is

Cheers
Nessus    

Anything that adds overhead which isn't absolutely necessary is disabled by default in the script. I leave it up to users to decide what options they need. Having anything that decreases performance disabled by default makes it clear that there is a trade off between additional features and performance.    

xml:


<onclick>Dialog.Close(1131)</onclick>

                        <onclick condition="String.IsEmpty(Container.ListItem.DBID) | [!String.IsEqual(Container.ListItem.DBType,movie) + !String.IsEqual(Container.ListItem.DBType,tvshow) + !String.IsEqual(Container.ListItem.DBType,episode)]">RunScript(plugin.video.themoviedb.helper,add_path=$INFO[Container.ListItem.FolderPath],call_auto=1134)</onclick>

                        <onclick condition="!String.IsEmpty(Container.ListItem.DBID) + String.IsEqual(Container.ListItem.DBType,movie)">RunScript(plugin.video.themoviedb.helper,add_path=$INFO[Container.ListItem.Label,videodb://movies/titles/?xsp=%7B%22order%22%3A%7B%22direction%22%3A%22ascending%22%2C%22ignorefolders%22%3A0%2C%22method%22%3A%22sorttitle%22%7D%2C%22rules%22%3A%7B%22and%22%3A%5B%7B%22field%22%3A%22title%22%2C%22operator%22%3A%22is%22%2C%22value%22%3A%5B%22,%22%5D%7D%5D%7D%2C%22type%22%3A%22movies%22%7D],call_auto=1134)</onclick>

                        <onclick condition="!String.IsEmpty(Container.ListItem.DBID) + String.IsEqual(Container.ListItem.DBType,tvshow)">RunScript(plugin.video.themoviedb.helper,add_path=$INFO[Container.ListItem.Label,videodb://tvshows/titles/?xsp=%7B%22order%22%3A%7B%22direction%22%3A%22ascending%22%2C%22ignorefolders%22%3A0%2C%22method%22%3A%22sorttitle%22%7D%2C%22rules%22%3A%7B%22and%22%3A%5B%7B%22field%22%3A%22title%22%2C%22operator%22%3A%22is%22%2C%22value%22%3A%5B%22,%22%5D%7D%5D%7D%2C%22type%22%3A%22tvshows%22%7D],call_auto=1134)</onclick>

                        

(2020-01-20, 18:00)dingdongdynamo Wrote: Been getting some errors related to TheMovieDbHelper lately. Happens when I go to the information page of movies. Here's the log that happening to a specific movie: https://paste.kodi.tv/puqagapuca.kodi

(2020-01-20, 23:20)jurialmunkey Wrote:

(2020-01-20, 18:00)dingdongdynamo Wrote: Been getting some errors related to TheMovieDbHelper lately. Happens when I go to the information page of movies. Here's the log that happening to a specific movie: https://paste.kodi.tv/puqagapuca.kodi

Update to latest git version - I already fixed this error I'm pretty sure.

(2020-01-21, 07:12)dingdongdynamo Wrote:

(2020-01-20, 23:20)jurialmunkey Wrote:

(2020-01-20, 18:00)dingdongdynamo Wrote: Been getting some errors related to TheMovieDbHelper lately. Happens when I go to the information page of movies. Here's the log that happening to a specific movie: https://paste.kodi.tv/puqagapuca.kodi

Update to latest git version - I already fixed this error I'm pretty sure.

I have your repository installed and it says that it's already up to date (v2.2.24).