Kodi Community Forum
18.4 not skipping commercials - Printable Version

Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: PVR & Live TV Support (https://forum.kodi.tv/forumdisplay.php?fid=167)
--- Thread: 18.4 not skipping commercials (/showthread.php?tid=346896)

Pages: 1 2


18.4 not skipping commercials - doktourtv - 2019-09-02

This happens with most updates that tout "pvr fixes". The commercial skipping stops working and you have to go back to the previous build to get it working again.

When 18 was first released it did not skip the commercials, however 18.3 DOES skip them properly.

18.4 - the issue returns..commercials are not skipped.

I happen to be using Nextpvr  however it is not a Nextpvr issue, as it happens with any recording. The standard edl files are created with comskip and 18.4 ignores them.

Does anyone have any suggestion on how to correct this?

Thank you


RE: 18.4 not skipping commericals - emveepee - 2019-09-03

First upload you debug Kodi log from NextPVR and I will confirm it is broken from what I see.  Then you open the issue on git hub.

Martin


RE: 18.4 not skipping commericals - doktourtv - 2019-09-03

(2019-09-03, 01:29)emveepee Wrote: First upload you debug Kodi log from NextPVR and I will confirm it is broken from what I see.  Then you open the issue on git hub.

Martin
 

I have submitted a bug report to github: 16564 (GH issue)


RE: 18.4 not skipping commericals - emveepee - 2019-09-03

I was hoping to see a test in the Video Library showing that the EDL support was not working in general and to separate this from a PVR problem.

Martin


RE: 18.4 not skipping commericals - doktourtv - 2019-09-03

(2019-09-03, 19:08)emveepee Wrote: I was hoping to see a test in the Video Library showing that the EDL support was not working in general and to separate this from a PVR problem.

Martin
Here are two debug logs:

Kodi 18.4 NOT skipping commercials: https://pastebin.com/bm16xrJi
Kodi 18.3 SKIPPING commercials on the same video file: https://pastebin.com/6svNXgUW

Kodi 18.4 is never reading the .edl file


RE: 18.4 not skipping commericals - emveepee - 2019-09-03

I already saw your pastebin's on the ticket.  I was just suggesting that since edl support seems broken in general (for me it is the Video Library and PVR Recordings)  it might get more attention showing the bigger issue.

Martin


RE: 18.4 not skipping commericals - acegolfer - 2019-09-03

(2019-09-02, 22:30)doktourtv Wrote: This happens with most updates that tout "pvr fixes". The commercial skipping stops working and you have to go back to the previous build to get it working again.

When 18 was first released it did not skip the commercials, however 18.3 DOES skip them properly.

18.4 - the issue returns..commercials are not skipped.

I happen to be using Nextpvr  however it is not a Nextpvr issue, as it happens with any recording. The standard edl files are created with comskip and 18.4 ignores them.

Does anyone have any suggestion on how to correct this?

Thank you

Didn't know that Kodi PVR client allows commercial skip. Is it PVR addon dependent? I am using TVH on Win10 machine and Kodi is in RPi3. If needed, I can run comskip in either windows or WSL.


RE: 18.4 not skipping commericals - emveepee - 2019-09-04

There is a PVR API call that the addon has to support to pass the edl file from the host to Kodi. 

The 18.4 issue can likely be tested from the Video Library I am not seeing it working on a Windows client.

Martin


RE: 18.4 not skipping commericals - doktourtv - 2019-09-04

(2019-09-03, 23:58)acegolfer Wrote:
(2019-09-02, 22:30)doktourtv Wrote: This happens with most updates that tout "pvr fixes". The commercial skipping stops working and you have to go back to the previous build to get it working again.

When 18 was first released it did not skip the commercials, however 18.3 DOES skip them properly.

18.4 - the issue returns..commercials are not skipped.

I happen to be using Nextpvr  however it is not a Nextpvr issue, as it happens with any recording. The standard edl files are created with comskip and 18.4 ignores them.

Does anyone have any suggestion on how to correct this?

Thank you

Didn't know that Kodi PVR client allows commercial skip. Is it PVR addon dependent? I am using TVH on Win10 machine and Kodi is in RPi3. If needed, I can run comskip in either windows or WSL. 
The commercial skip has been working for several releases and it is not PVR addon dependent. I have used it with MediaPortal and NextPVR as well on recordings I have made out of Kodi with VLC and ProgDVB. The key is to create a valid .edl file, as is done by comskip. Both MediaPortal and NextpVR support post processing and have instructions on how to configure comskip to run automatically after or during each recording made with that server.

However, although this all works properly in 18.3 something seems to have been broken in 18.4 as it has stopped working. So until this issue is addressed, if you want to test it I would suggest you use 18.3 or earlier.


RE: 18.4 not skipping commericals - doktourtv - 2019-09-04

(2019-09-04, 00:27)emveepee Wrote: There is a PVR API call that the addon has to support to pass the edl file from the host to Kodi. 

The 18.4 issue can likely be tested from the Video Library I am not seeing it working on a Windows client.

Martin
The failure to read .edl files is not a new issue. It happened when 17 was first released as well and I opened a bug ticket and it was resolved.
With that failure (17) playing the video from the video library WOULD skip the commercials and only playing the recordings would fail.
In this case (18.4) I have just tested it and confirmed that it is NOT working in either the recordings playback OR the video library playback.


RE: 18.4 not skipping commericals - phunkyfish - 2019-11-08

This should be fixed in Leia 18.5

16596 (PR)


RE: 18.4 not skipping commericals - lovemyram4x4 - 2019-11-20

(2019-11-08, 11:34)phunkyfish Wrote: This should be fixed in Leia 18.5

16596 (PR)

Seems to auto skip in 18.5, unfortunately all the functions that haven't worked since 16.x still seem to not work.


RE: 18.4 not skipping commericals - phunkyfish - 2019-11-20

Which functions?


RE: 18.4 not skipping commericals - doktourtv - 2019-11-20

(2019-11-20, 03:18)lovemyram4x4 Wrote:
(2019-11-08, 11:34)phunkyfish Wrote: This should be fixed in Leia 18.5

16596 (PR)

Seems to auto skip in 18.5, unfortunately all the functions that haven't worked since 16.x still seem to not work.   

I can confirm that com skip is working in 18.5. Please check your .edl file.


RE: 18.4 not skipping commericals - lovemyram4x4 - 2019-11-21

(2019-11-20, 14:39)doktourtv Wrote:
(2019-11-20, 03:18)lovemyram4x4 Wrote:
(2019-11-08, 11:34)phunkyfish Wrote: This should be fixed in Leia 18.5

16596 (PR)

Seems to auto skip in 18.5, unfortunately all the functions that haven't worked since 16.x still seem to not work.    

I can confirm that com skip is working in 18.5. Please check your .edl file. 
So if you hit big skip back after an auto skip it goes back to were it skipped from and if then hit big skip forward it goes back to were it auto skipped to because it doesn't do that for me.

I don't know what you want to check about my EDL file, it seems fine to me because it auto skips. I'd just like to have things work like they used to since at times (usually if there's a lot of bark frames) the skips are to soon or too long and being able to use the big skip back to make sure it did skip too soon and the big skip forward to get if you verified it didn't was a great feature.