Kodi Community Forum
Kodi 18.4 not scraping media flags from iso files on initial playback - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Windows (https://forum.kodi.tv/forumdisplay.php?fid=59)
+---- Thread: Kodi 18.4 not scraping media flags from iso files on initial playback (/showthread.php?tid=348338)

Pages: 1 2


Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2019-10-12

First I thought this was only on my Libreelec Dist the case but now I discovered that since the latest update this does not work anymore even on Windows.

Can you please fix that?
Thank you.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - PatK - 2019-10-12

(2019-10-12, 17:31)_novalis Wrote: First I thought this was only on my Libreelec Dist the case but now I discovered that since the latest update this does not work anymore even on Windows.

Can you please fix that?
Thank you.
I can confirm this behaviour with .iso files, the meta-data is properly pulled in, but the media flags are missing in both 18.4 and 19 A1 versions. Perhaps a trac report pointing back to this thread might bring some attention to this issue and perhaps a solve.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2019-10-12

(2019-10-12, 18:10)PatK Wrote: the meta-data is properly pulled in

but wouldn't that mean that the meta data should be exported to the nfo file with a library export (separat files)?
Because that is not the case.
Usually you find the data here
<fileinfo>
<streamdetails>
<video>
<codec>hevc</codec>
<aspect>0.000000</aspect>
<width>3840</width>
<height>2160</height>
</video>
<audio>
<codec>dtshd_ma</codec>
<language>eng</language>
<channels>6</channels>
</audio>
</streamdetails>
</fileinfo>


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - Karellen - 2019-10-12

Maybe related to this... https://github.com/xbmc/xbmc/pull/16555

Might be worth asking in that PR if ISO could be looked at also.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - Radar - 2020-03-15

18.6 doesn't load any of the info now. Same as subject line, ISO files for DVD and Bluray.  <Fileinfo> <streamdetails> are not populated when you play the ISO. If the import of NFO had the details, it will remain (no overide and delete like previous versions), press 'I' when playing the movie displays the media flags.

I've seen posts by Karellen linking various PR's indicating it been difficult to fix, just thought I'd mention it's worse in 18.6.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - Karellen - 2020-03-15

@Radar

It's been a while since I looked at this, but IIRC the big issue with ISO files is there is no way to know which stream in the ISO file is the correct one to parse. An ISO file is 1:1 rip of a disk that can contain dozens and dozens of audio and video clips- trailers, bloopers, interviews, alternate endings etc which can all have different streamdetails. There is no way to know which is the correct stream to parse.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2020-03-15

Well, in 95% it would probably be the largest file on disc. Also it stopped working with 18.4 so in my opinion the change that has been made was not very good in regards to this issue.
Maybe this would be a good starting point for revision.
I don't know how others think about this, but since I don't see any advantage of the change that was responsible for this feature not working anymore, for me this is a -1. I really miss it.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - Radar - 2020-03-27

I concur with _novalis, start with 18.4 as a good starting point.

@Karellen thank you for mentioning that it would be difficult to know which stream to parse, but shouldn't that come down to what I chose to play and change the flags to suit that ?. To me that would make more sense to read the stream I was playing rather than picking a stream from an ISO.

My backups are minus the menu's and bonus materials, if I need to watch those I'll pull the discs out to watch them. Granted many probably don't do just the movie but irrespective of that I would have thought as mentioned above that reading the media info as it does when playing the video, would be what was used to populate media flags.. If I play bonus material than I'd expect it to change according to this. If I didn't like the media flags from the bonus material than I'd play the movie again to correct it.

I'm no programmer and it's obviously it's not as simple as that, I'm just surprised it's gone backwards (what was working to some degree in earlier 18 builds) than in these later builds..


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2020-03-27

I flipped back. The older version just works. The newer doesn't. I don't have issues. That's the way to solve the problem. I don't understand the implications either. Still dissatisfied though.

Also radar is certainly right. It was never about parsing iso files. It works the way that the media flags are read on first play from the m2ts file played.

So my request still is: Please fix the bug.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - black_eagle - 2020-03-27

Here is a list of all the PR's between 18.3 and 18.4, so presumably one of these introduces the issue. https://github.com/xbmc/xbmc/pulls?page=1&q=is%3Apr+label%3A%22v18+Leia%22+is%3Aclosed+merged%3A2019-06-17..2019-08-31


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2020-03-27

Oh interesting, but it doesn't look like anything to me. Not a technician.
But maybe the devs could bring some light to it.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - jjd-uk - 2020-03-28

This most likely broke it https://github.com/xbmc/xbmc/pull/16378 which is a back port from Master of https://github.com/xbmc/xbmc/pull/16342

This change means media flag details are no longer updated on playback, however in the case of ISO's Kodi does not have access to the media stream details until playback is initiated. This is because ISO is a image file format and not a media file format.

I'm not sure if ISO was considered when making that change so best to raise an issue on Github to see if it was intentional.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - Radar - 2020-06-20

(2020-03-28, 01:35)jjd-uk Wrote: This most likely broke it https://github.com/xbmc/xbmc/pull/16378 which is a back port from Master of https://github.com/xbmc/xbmc/pull/16342

This change means media flag details are no longer updated on playback, however in the case of ISO's Kodi does not have access to the media stream details until playback is initiated. This is because ISO is a image file format and not a media file format.

I'm not sure if ISO was considered when making that change so best to raise an issue on Github to see if it was intentional.

Thanks @jjd-uk I've created an account with Github since 18.7 was no different. Lets hope it gets sorted either in another 18 update, or in 19. Cross fingers anyway as I really don't want to remain on an older version of Kodi.


RE: Kodi 18.4 not scraping media flags from iso files on initial playback - _novalis - 2020-06-20

thanks


Kodi 18.4 not scraping media flags from iso files on initial playback - PatK - 2020-06-20

And with that, I presume your issue has been taken care of.

Thread marked solved.